You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@calcite.apache.org by "silundong (via GitHub)" <gi...@apache.org> on 2026/02/25 06:55:03 UTC

[PR] [CALCITE-7386] An error occurred while using TopDownGeneralDecorrelator to process the aggregate(col) filter [calcite]

silundong opened a new pull request, #4806:
URL: https://github.com/apache/calcite/pull/4806

   In fact, this issue is unrelated to the new decorrelation algorithm. In `TopDownGeneralDecorrelator`, there is preprocessing and postprocessing around decorrelation, and both of these use the `FILTER_PROJECT_TRANSPOSE` rule. For the test case mentioned in the JIRA issue, the `Filter` is pushed down under a `Project` that contains a `V2M` expression, which produces an incorrect result; if the `FILTER_PROJECT_TRANSPOSE` rule is removed, the result is correct.
   
   I am not familiar with the measure features, and it seems to be a special syntax feature. Considering the following points:
   
   - The preprocessing and postprocessing in `TopDownGeneralDecorrelator` do require the `FILTER_PROJECT_TRANSPOSE` rule.
   - I am not sure whether the `FILTER_PROJECT_TRANSPOSE` rule should avoid the `Project` that contains `V2M`. I observed that some test cases in measure.iq are still wrapped in `!if (false)`, which suggests the related functionality still needs further work. 
   
   I temporarily modified `CoreQuidemTest2` to skip this test in measure.iq.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [CALCITE-7386] An error occurred while using TopDownGeneralDecorrelator to process the aggregate(col) filter [calcite]

Posted by "xiedeyantu (via GitHub)" <gi...@apache.org>.
xiedeyantu commented on PR #4806:
URL: https://github.com/apache/calcite/pull/4806#issuecomment-3957966943

   I think we can wait 24-48 hours and see if anyone else has commented.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [CALCITE-7386] An error occurred while using TopDownGeneralDecorrelator to process the aggregate(col) filter [calcite]

Posted by "sonarqubecloud[bot] (via GitHub)" <gi...@apache.org>.
sonarqubecloud[bot] commented on PR #4806:
URL: https://github.com/apache/calcite/pull/4806#issuecomment-3957326674

   ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate Passed')](https://sonarcloud.io/dashboard?id=apache_calcite&pullRequest=4806) **Quality Gate passed**  
   Issues  
   ![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/passed-16px.png '') [0 New issues](https://sonarcloud.io/project/issues?id=apache_calcite&pullRequest=4806&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)  
   ![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/accepted-16px.png '') [0 Accepted issues](https://sonarcloud.io/project/issues?id=apache_calcite&pullRequest=4806&issueStatuses=ACCEPTED)
   
   Measures  
   ![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/passed-16px.png '') [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_calcite&pullRequest=4806&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)  
   ![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/passed-16px.png '') [0.0% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_calcite&pullRequest=4806&metric=new_coverage&view=list)  
   ![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/passed-16px.png '') [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_calcite&pullRequest=4806&metric=new_duplicated_lines_density&view=list)  
     
   [See analysis details on SonarQube Cloud](https://sonarcloud.io/dashboard?id=apache_calcite&pullRequest=4806)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org