[jira] [Commented] (AMBARI-6294) Python client is broken when pycurl isn't installed

["subin (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/AMBARI-6294?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14050008#comment-14050008 ] 

subin commented on AMBARI-6294:
-------------------------------

This is not a issue.
 mock package is bundled  in the ambari source.
Path: ambari/ambari-common/src/test/python.

You might need to uninstall the pypi mock,
try  
mvn versions:set -DnewVersion=1.3.0-SNAPSHOT
mvn -B clean install package rpm:rpm -DnewVersion=1.3.0-SNAPSHOT -DskipTests -Pcentos6 -Dpython.ver="python >= 2.6" -Preplaceurl
you should find all the testcases to run



> Python client is broken when pycurl isn't installed
> ---------------------------------------------------
>
>                 Key: AMBARI-6294
>                 URL: https://issues.apache.org/jira/browse/AMBARI-6294
>             Project: Ambari
>          Issue Type: Bug
>          Components: client
>    Affects Versions: 1.6.0
>            Reporter: Greg Hill
>
> If you don't have pycurl installed, trying to use the client causes a lot of problems.  This line in http_client.py is at fault:
> try:
>   import pycurl
> except ImportError:
>   from mock.mock import MagicMock
>   pycurl = MagicMock() 
> There are a few problems here:
> 1. The tests should do the mocking, it shouldn't be done automatically when running outside of tests.
> 2. mock.mock does not appear to be a valid module.  I can't install it via pip.  Did you mean 'from mock import MagicMock'?
> 3. There is no dependency set on either pycurl or mock.mock, so using pip to install ambari-client does not install it in a working state.



--
This message was sent by Atlassian JIRA
(v6.2#6252)