You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by GitBox <gi...@apache.org> on 2022/02/23 02:18:52 UTC

[GitHub] [iceberg] happyprg commented on a change in pull request #4203: fix: change invalid typo commited to committed

happyprg commented on a change in pull request #4203:
URL: https://github.com/apache/iceberg/pull/4203#discussion_r812511839



##########
File path: python_legacy/iceberg/core/base_transaction.py
##########
@@ -60,13 +60,13 @@ def __init__(self, ops, start):
     def table(self):
         return self.transaction_table
 
-    def check_last_operation_commited(self, operation):
+    def check_last_operation_committed(self, operation):

Review comment:
       @kbendick 
   
   > may I suggest to add a note above each saying that they are misspelled?
   
   Yes 
   
   >  That way, if anybody goes to copy this code to the new python library / API, they will update it.
   
   If then, do I close this PR, and you are going to comment about it on another PR?
   




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org