You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomcat.apache.org by Mark Thomas <ma...@apache.org> on 2010/05/17 19:25:14 UTC

About to tag Tomcat 7.0.0-RC2

I've just completed testing of trunk.

Unit tests - pass

Servlet 3.0 TCK
 - BIO with security manager - pass
 - NIO with security manager - pass (expected failures due to bug 49284)
 - APR/native with security manager - pass

JSP 2.2 TCK
 - APR/native with security manager - pass

EL 2.2 TCK
 - with security manager - pass

I am therefore going to tag trunk as 7.0.0-RC2 and roll a release candidate.

Mark



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


Re: About to tag Tomcat 7.0.0-RC2

Posted by jean-frederic clere <jf...@gmail.com>.
On 05/17/2010 07:25 PM, Mark Thomas wrote:
> I've just completed testing of trunk.
> 
> Unit tests - pass
> 
> Servlet 3.0 TCK
>  - BIO with security manager - pass
>  - NIO with security manager - pass (expected failures due to bug 49284)
>  - APR/native with security manager - pass

I am still working on a better fix for this one... Probably for RC3.

Cheers

Jean-Frederic

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


Re: About to tag Tomcat 7.0.0-RC2

Posted by Rainer Jung <ra...@kippdata.de>.
On 17.05.2010 19:56, Konstantin Kolinko wrote:
> 2010/5/17 Mark Thomas<ma...@apache.org>:
>> I've just completed testing of trunk.
>>
>> Unit tests - pass
>>
>
> They also pass for me, but Gump fails at TestCoyoteAdaptor:
>
> http://vmgump.apache.org/gump/public/tomcat-trunk/tomcat-trunk-test/gump_work/build_tomcat-trunk_tomcat-trunk-test.html
>
> Do not know what is the deal.
> I done a clean run, but the tests are still succeeding.
>
> Is there access to
> /srv/gump/public/workspace/tomcat-trunk/output/build/logs/
> to look at the output file from the test run?

Page

http://vmgump.apache.org/gump/public/tomcat-trunk/tomcat-trunk-test/index.html

contains links at the bottom. Directory listing:

http://vmgump.apache.org/gump/public/tomcat-trunk/tomcat-trunk-test/gump_file/logs.html

and the one file that's there:

http://vmgump.apache.org/gump/public/tomcat-trunk/tomcat-trunk-test/gump_file/TEST-org.apache.catalina.connector.TestCoyoteAdaptor.txt.html

Error message:

Testcase: testPathParams took 11.004 sec
	FAILED
expected:<1234> but was:<none>
junit.framework.ComparisonFailure: expected:<1234> but was:<none>
	at 
org.apache.catalina.connector.TestCoyoteAdaptor.testPath(TestCoyoteAdaptor.java:58)
	at 
org.apache.catalina.connector.TestCoyoteAdaptor.testPathParams(TestCoyoteAdaptor.java:49)

Regards,

Rainer

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


Re: About to tag Tomcat 7.0.0-RC2

Posted by Mark Thomas <ma...@apache.org>.
On 17/05/2010 18:56, Konstantin Kolinko wrote:
> 2010/5/17 Mark Thomas <ma...@apache.org>:
>> I've just completed testing of trunk.
>>
>> Unit tests - pass
>>
> 
> They also pass for me, but Gump fails at TestCoyoteAdaptor:
> 
> http://vmgump.apache.org/gump/public/tomcat-trunk/tomcat-trunk-test/gump_work/build_tomcat-trunk_tomcat-trunk-test.html
> 
> Do not know what is the deal.
> I done a clean run, but the tests are still succeeding.
> 
> Is there access to
> /srv/gump/public/workspace/tomcat-trunk/output/build/logs/
> to look at the output file from the test run?

Testsuite: org.apache.catalina.connector.TestCoyoteAdaptor
Tests run: 1, Failures: 1, Errors: 0, Time elapsed: 11.023 sec
------------- Standard Error -----------------
May 17, 2010 2:40:44 AM org.apache.catalina.core.StandardService
startInternal
INFO: Starting service Tomcat
May 17, 2010 2:40:44 AM org.apache.catalina.core.StandardEngine
startInternal
INFO: Starting Servlet Engine: Apache Tomcat/7.0.0-dev
May 17, 2010 2:40:44 AM org.apache.coyote.http11.Http11Protocol init
INFO: Initializing Coyote HTTP/1.1 on http-8001
May 17, 2010 2:40:44 AM org.apache.coyote.http11.Http11Protocol start
INFO: Starting Coyote HTTP/1.1 on http-8001
May 17, 2010 2:40:44 AM org.apache.coyote.http11.AbstractHttp11Protocol
pause
INFO: Pausing Coyote HTTP/1.1 on http-8001
May 17, 2010 2:40:45 AM org.apache.catalina.core.StandardService
stopInternal
INFO: Stopping service Tomcat
May 17, 2010 2:40:46 AM org.apache.coyote.http11.AbstractHttp11Protocol
destroy
INFO: Stopping Coyote HTTP/1.1 on http-8001
------------- ---------------- ---------------

Testcase: testPathParams took 11.004 sec
        FAILED
expected:<1234> but was:<none>
junit.framework.ComparisonFailure: expected:<1234> but was:<none>
        at
org.apache.catalina.connector.TestCoyoteAdaptor.testPath(TestCoyoteAdaptor.java:58)
        at
org.apache.catalina.connector.TestCoyoteAdaptor.testPathParams(TestCoyoteAdaptor.java:49)


I can't see why it is failing.

Mark



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


Re: About to tag Tomcat 7.0.0-RC2

Posted by Mark Thomas <ma...@apache.org>.
On 17/05/2010 21:43, Konstantin Kolinko wrote:
> 1) I had to remove ${catalina.home}/conf/web.xml, because otherwise
> http://localhost:8080/;jsessionid=1234
> gives Error 404

I think the mapper fixes fixed this one. At least I can't recreate this
on a clean build from trunk.

Mark



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


Re: About to tag Tomcat 7.0.0-RC2

Posted by Mark Thomas <ma...@apache.org>.
On 17/05/2010 21:43, Konstantin Kolinko wrote:
> 2) If I touch webapps/ROOT/WEB-INF/web.xml  Tomcat tries to reload the
> ROOT application.
> It results in a series of SEVERE messages from
> org.apache.tomcat.util.http.mapper.Mapper
> 
> 18.05.2010 0:10:25 org.apache.tomcat.util.http.mapper.Mapper removeWelcomeFile
> SEVERE: No context found:
> etc.

This was fixed in r945722

Mark



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


Re: About to tag Tomcat 7.0.0-RC2

Posted by Konstantin Kolinko <kn...@gmail.com>.
2010/5/17 Rainer Jung <ra...@kippdata.de>:
> On 17.05.2010 19:56, Konstantin Kolinko wrote:
>>
>> 2010/5/17 Mark Thomas<ma...@apache.org>:
>>>
>>> I've just completed testing of trunk.
>>>
>>> Unit tests - pass
>>>
>>
>> They also pass for me, but Gump fails at TestCoyoteAdaptor:
>>
>>
>> http://vmgump.apache.org/gump/public/tomcat-trunk/tomcat-trunk-test/gump_work/build_tomcat-trunk_tomcat-trunk-test.html
>>
>> Do not know what is the deal.
>> I done a clean run, but the tests are still succeeding.
>>
>> Is there access to
>> /srv/gump/public/workspace/tomcat-trunk/output/build/logs/
>> to look at the output file from the test run?
>
> In addition to my previous mail: it seems Gump ran before Mark's changes.
> Gump says it ran at "Mon, 17 May 2010 02:40:24 (PDT)", which seems to be
> around 12 hours ago.
>
> I just now ran the unit tests also, and they passed except for
> TestContextConfigAnnotation. That's broken by your observation in a previous
> mail, I responded to it separately.
>

I downloaded the jars produced by /tomcat-trunk/ run,
http://vmgump.apache.org/gump/public-jars/

and then configured a ROOT application with a copy of PathParamServlet
class (from TestCoyoteAdaptor) which I moved to another package, and
run the requests from the testcase manually from a browser.

I was not able to observe the failure as the Gump did.
They gave the expected results.


I notices two issues, unrelated to Gump runs:

1) I had to remove ${catalina.home}/conf/web.xml, because otherwise
http://localhost:8080/;jsessionid=1234
gives Error 404

I suppose that is because it tries to open a welcome file,
which I do not have in the ROOT webapp.

I tried to add empty <welcome-file-list> -- see web.xml below,
but it did not help.

Note, that a comment in  ${catalina.home}/conf/web.xml  says that
webapp's welcome files list "replaces" the welcome files list
specified in the default web.xml

web.xml:
[[[
<?xml version="1.0" encoding="ISO-8859-1"?>
<web-app xmlns="http://java.sun.com/xml/ns/javaee"
  xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
  xsi:schemaLocation="http://java.sun.com/xml/ns/javaee
                      http://java.sun.com/xml/ns/javaee/web-app_3_0.xsd"
  version="3.0"
  metadata-complete="true">
    <servlet>
        <servlet-name>default</servlet-name>
        <servlet-class>foo.PathParamServlet</servlet-class>
    </servlet>
    <servlet-mapping>
        <servlet-name>default</servlet-name>
        <url-pattern>/</url-pattern>
    </servlet-mapping>
    <welcome-file-list>
    </welcome-file-list>
</web-app>
]]]


2) If I touch webapps/ROOT/WEB-INF/web.xml  Tomcat tries to reload the
ROOT application.
It results in a series of SEVERE messages from
org.apache.tomcat.util.http.mapper.Mapper

18.05.2010 0:10:25 org.apache.tomcat.util.http.mapper.Mapper removeWelcomeFile
SEVERE: No context found:
etc.

It does not occur if I touch web.xml in any other web application,
e.g. in the manager or in the examples.


Best regards,
Konstantin Kolinko

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


Re: About to tag Tomcat 7.0.0-RC2

Posted by Rainer Jung <ra...@kippdata.de>.
On 17.05.2010 19:56, Konstantin Kolinko wrote:
> 2010/5/17 Mark Thomas<ma...@apache.org>:
>> I've just completed testing of trunk.
>>
>> Unit tests - pass
>>
>
> They also pass for me, but Gump fails at TestCoyoteAdaptor:
>
> http://vmgump.apache.org/gump/public/tomcat-trunk/tomcat-trunk-test/gump_work/build_tomcat-trunk_tomcat-trunk-test.html
>
> Do not know what is the deal.
> I done a clean run, but the tests are still succeeding.
>
> Is there access to
> /srv/gump/public/workspace/tomcat-trunk/output/build/logs/
> to look at the output file from the test run?

In addition to my previous mail: it seems Gump ran before Mark's 
changes. Gump says it ran at "Mon, 17 May 2010 02:40:24 (PDT)", which 
seems to be around 12 hours ago.

I just now ran the unit tests also, and they passed except for 
TestContextConfigAnnotation. That's broken by your observation in a 
previous mail, I responded to it separately.

Regards,

Rainer

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


Re: About to tag Tomcat 7.0.0-RC2

Posted by Konstantin Kolinko <kn...@gmail.com>.
2010/5/17 Mark Thomas <ma...@apache.org>:
> I've just completed testing of trunk.
>
> Unit tests - pass
>

They also pass for me, but Gump fails at TestCoyoteAdaptor:

http://vmgump.apache.org/gump/public/tomcat-trunk/tomcat-trunk-test/gump_work/build_tomcat-trunk_tomcat-trunk-test.html

Do not know what is the deal.
I done a clean run, but the tests are still succeeding.

Is there access to
/srv/gump/public/workspace/tomcat-trunk/output/build/logs/
to look at the output file from the test run?

Best regards,
Konstantin Kolinko

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org