You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2022/07/13 15:32:38 UTC

[GitHub] [superset] dpgaspar commented on a diff in pull request #20700: fix(releases): docker build on M1 npm run build fails

dpgaspar commented on code in PR #20700:
URL: https://github.com/apache/superset/pull/20700#discussion_r920223172


##########
RELEASING/test_run_tarball.sh:
##########
@@ -26,7 +26,7 @@ if [ -z "${SUPERSET_SVN_DEV_PATH}" ]; then
   SUPERSET_SVN_DEV_PATH="$HOME/svn/superset_dev"
 fi
 
-if [ ${1} == "local" ]; then
+if [[ -n ${1} ]] && [[ ${1} == "local" ]]; then

Review Comment:
   fixes `./test_run_tarball.sh: line 29: [: ==: unary operator expected`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org