You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Jason Golieb <jg...@hortonworks.com> on 2018/01/17 19:33:08 UTC
Add reviewers to PR as a non-committer?
As a non-committer, is it possible to add reviewers to a pull request? It doesn’t look like it to me. What’s the suggested procedure for getting eyes on my PRs?
Re: Add reviewers to PR as a non-committer?
Posted by Jonathan Hurley <jh...@hortonworks.com>.
Spark also has over 400 PRs open :)
Taking a quick look, we have ones like this: https://github.com/apache/spark/pull/20161
Which have been open for 2 weeks with no reviews (even with an @mention) in the comments.
I think it's a shame that the GitHub PR model doesn't allow picking reviewers, especially since it negates their very own filters. I suppose we'll just have to use the @mention for now.
On Jan 17, 2018, at 3:08 PM, Vivek Ratnavel <vi...@apache.org>> wrote:
I have seen some other very active Apache projects including Apache Spark
using this model successfully for a long time now. They have a portal to
keep track of open PRs and stale PRs categorized by components -
https://spark-prs.appspot.com/
The contributors open PRs and wait for the community to review it. For
instance, take a look at this - https://github.com/apache/spark/pull/20297
On Wed, Jan 17, 2018 at 12:00 PM, Jonathan Hurley <jh...@hortonworks.com>
wrote:
We have a very active project with potentially dozens of new PRs coming in
every day - I don't think relying on the community to look is a very
sustainable model. Is there no way to add reviewers without tagging them?
There seems to be a way to filter by reviews needing attention - seems
silly that non-committers can't add committers ...
On Jan 17, 2018, at 2:51 PM, Vivek Ratnavel <vi...@gmail.com>
wrote:
Hi Jason,
Thanks for bringing this up. For contributors, the best way to notify
people would be to tag them in comments. This is another good reason to
add
[component] tags to the PR title, so that committers who are working on
those components can pro-actively take a look at the newly opened pull
requests. The committers of the community should actively check newly
created PRs and resolve them. If the PR is not reviewed by any committer
for a long time, then the contributor can try pinging the committers by
tagging them in comments as I mentioned before. Relevant committers can
be
found by doing a git blame on the files contributed in the patch.
Thanks,
Vivek Ratnavel
On Wed, Jan 17, 2018 at 11:33 AM, Jason Golieb <jg...@hortonworks.com>
wrote:
As a non-committer, is it possible to add reviewers to a pull request?
It
doesn’t look like it to me. What’s the suggested procedure for getting
eyes
on my PRs?
--
-Vivek Ratnavel S
Re: Add reviewers to PR as a non-committer?
Posted by Vivek Ratnavel <vi...@apache.org>.
I have seen some other very active Apache projects including Apache Spark
using this model successfully for a long time now. They have a portal to
keep track of open PRs and stale PRs categorized by components -
https://spark-prs.appspot.com/
The contributors open PRs and wait for the community to review it. For
instance, take a look at this - https://github.com/apache/spark/pull/20297
On Wed, Jan 17, 2018 at 12:00 PM, Jonathan Hurley <jh...@hortonworks.com>
wrote:
> We have a very active project with potentially dozens of new PRs coming in
> every day - I don't think relying on the community to look is a very
> sustainable model. Is there no way to add reviewers without tagging them?
> There seems to be a way to filter by reviews needing attention - seems
> silly that non-committers can't add committers ...
>
> > On Jan 17, 2018, at 2:51 PM, Vivek Ratnavel <vi...@gmail.com>
> wrote:
> >
> > Hi Jason,
> >
> > Thanks for bringing this up. For contributors, the best way to notify
> > people would be to tag them in comments. This is another good reason to
> add
> > [component] tags to the PR title, so that committers who are working on
> > those components can pro-actively take a look at the newly opened pull
> > requests. The committers of the community should actively check newly
> > created PRs and resolve them. If the PR is not reviewed by any committer
> > for a long time, then the contributor can try pinging the committers by
> > tagging them in comments as I mentioned before. Relevant committers can
> be
> > found by doing a git blame on the files contributed in the patch.
> >
> > Thanks,
> > Vivek Ratnavel
> >
> > On Wed, Jan 17, 2018 at 11:33 AM, Jason Golieb <jg...@hortonworks.com>
> > wrote:
> >
> >> As a non-committer, is it possible to add reviewers to a pull request?
> It
> >> doesn’t look like it to me. What’s the suggested procedure for getting
> eyes
> >> on my PRs?
> >>
> >
> >
> >
> > --
> > -Vivek Ratnavel S
>
>
Re: Add reviewers to PR as a non-committer?
Posted by Jonathan Hurley <jh...@hortonworks.com>.
We have a very active project with potentially dozens of new PRs coming in every day - I don't think relying on the community to look is a very sustainable model. Is there no way to add reviewers without tagging them? There seems to be a way to filter by reviews needing attention - seems silly that non-committers can't add committers ...
> On Jan 17, 2018, at 2:51 PM, Vivek Ratnavel <vi...@gmail.com> wrote:
>
> Hi Jason,
>
> Thanks for bringing this up. For contributors, the best way to notify
> people would be to tag them in comments. This is another good reason to add
> [component] tags to the PR title, so that committers who are working on
> those components can pro-actively take a look at the newly opened pull
> requests. The committers of the community should actively check newly
> created PRs and resolve them. If the PR is not reviewed by any committer
> for a long time, then the contributor can try pinging the committers by
> tagging them in comments as I mentioned before. Relevant committers can be
> found by doing a git blame on the files contributed in the patch.
>
> Thanks,
> Vivek Ratnavel
>
> On Wed, Jan 17, 2018 at 11:33 AM, Jason Golieb <jg...@hortonworks.com>
> wrote:
>
>> As a non-committer, is it possible to add reviewers to a pull request? It
>> doesn’t look like it to me. What’s the suggested procedure for getting eyes
>> on my PRs?
>>
>
>
>
> --
> -Vivek Ratnavel S
Re: Add reviewers to PR as a non-committer?
Posted by Vivek Ratnavel <vi...@gmail.com>.
Hi Jason,
Thanks for bringing this up. For contributors, the best way to notify
people would be to tag them in comments. This is another good reason to add
[component] tags to the PR title, so that committers who are working on
those components can pro-actively take a look at the newly opened pull
requests. The committers of the community should actively check newly
created PRs and resolve them. If the PR is not reviewed by any committer
for a long time, then the contributor can try pinging the committers by
tagging them in comments as I mentioned before. Relevant committers can be
found by doing a git blame on the files contributed in the patch.
Thanks,
Vivek Ratnavel
On Wed, Jan 17, 2018 at 11:33 AM, Jason Golieb <jg...@hortonworks.com>
wrote:
> As a non-committer, is it possible to add reviewers to a pull request? It
> doesn’t look like it to me. What’s the suggested procedure for getting eyes
> on my PRs?
>
--
-Vivek Ratnavel S
Re: Add reviewers to PR as a non-committer?
Posted by "Doroszlai, Attila" <ad...@apache.org>.
> As a non-committer, is it possible to add reviewers to a pull request? It doesn’t look like it to me. What’s the suggested procedure for getting eyes on my PRs?
@mention some people in the PR. This also seems to be one way for
anybody to ask non-committers to review.
-Attila