You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by pellmont <gi...@git.apache.org> on 2017/09/03 07:09:13 UTC
[GitHub] zeppelin pull request #2563: ZEPPELIN-204 make scala code completion work ag...
GitHub user pellmont opened a pull request:
https://github.com/apache/zeppelin/pull/2563
ZEPPELIN-204 make scala code completion work again
### What is this PR for?
Spark Scala interpreter didn't show any useful completion proposals (besides some keywords)
### What type of PR is it?
Bug Fix
### Todos
### What is the Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-204
### How should this be tested?
Open a note with spark interpreter. Write some (multiline) code. Open code completion with ctrl-.
There are also some additional unit tests...
### Screenshots (if appropriate)
### Questions:
* Does the licenses files need update? No
* Is there breaking changes for older versions? No
* Does this needs documentation? No
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/pellmont/zeppelin master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/2563.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2563
----
commit 94858b5de0129d77a125adfb9157dcc2f6171508
Author: Pascal Pellmont <gi...@ppo2.ch>
Date: 2017-09-03T06:57:34Z
ZEPPELIN-204 make scala code completion work again
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2563: ZEPPELIN-204 make scala code completion work again
Posted by pellmont <gi...@git.apache.org>.
Github user pellmont commented on the issue:
https://github.com/apache/zeppelin/pull/2563
do I have to do something else before it can be merged? or just wait?
---
[GitHub] zeppelin issue #2563: ZEPPELIN-204 make scala code completion work again
Posted by pellmont <gi...@git.apache.org>.
Github user pellmont commented on the issue:
https://github.com/apache/zeppelin/pull/2563
Hey guys
I finally found why some integration tests fail!
In scala 2.11.8 the REPL had been improved a lot. So the tests work well with either scala 2.10 (with SparkJLineCompletion) or scala >=2.11.8 (with cala.tools.nsc.interpreter.JLineCompletion).
I'll investigate further to see whether I find a solution for scala 2.11 <=2.11.7.
Otherwise I'll disable the (extended) tests for the scala versions below 2.11.8 (via Assume)
---
[GitHub] zeppelin issue #2563: ZEPPELIN-204 make scala code completion work again
Posted by felixcheung <gi...@git.apache.org>.
Github user felixcheung commented on the issue:
https://github.com/apache/zeppelin/pull/2563
we are just wrapping up, shouldn't need anything at this point.
---
[GitHub] zeppelin issue #2563: ZEPPELIN-204 make scala code completion work again
Posted by pellmont <gi...@git.apache.org>.
Github user pellmont commented on the issue:
https://github.com/apache/zeppelin/pull/2563
finally a green build :-)
---
[GitHub] zeppelin pull request #2563: ZEPPELIN-204 make scala code completion work ag...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/zeppelin/pull/2563
---
[GitHub] zeppelin issue #2563: ZEPPELIN-204 make scala code completion work again
Posted by Leemoonsoo <gi...@git.apache.org>.
Github user Leemoonsoo commented on the issue:
https://github.com/apache/zeppelin/pull/2563
@pellmont Cool!
LGTM and merge to master if no further comment.
---
[GitHub] zeppelin issue #2563: ZEPPELIN-204 make scala code completion work again
Posted by Leemoonsoo <gi...@git.apache.org>.
Github user Leemoonsoo commented on the issue:
https://github.com/apache/zeppelin/pull/2563
Tested manually and it works well.
@pellmont could you setup CI and see all tests become green?
```
Looks like travis-ci is not configured for your fork.
Please setup by swich on 'zeppelin' repository at https://travis-ci.org/profile and travis-ci.
And then make sure 'Build branch updates' option is enabled in the settings https://travis-ci.org/pellmont/zeppelin/settings.
To trigger CI after setup, you will need ammend your last commit with
git commit --amend
git push your-remote HEAD --force
See http://zeppelin.apache.org/contribution/contributions.html#continuous-integration.
```
---