You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@drill.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2014/10/08 06:15:34 UTC

[jira] [Commented] (DRILL-18) Parser has some breakage

    [ https://issues.apache.org/jira/browse/DRILL-18?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14163036#comment-14163036 ] 

ASF GitHub Bot commented on DRILL-18:
-------------------------------------

Github user asfgit closed the pull request at:

    https://github.com/apache/incubator-drill/pull/3


> Parser has some breakage
> ------------------------
>
>                 Key: DRILL-18
>                 URL: https://issues.apache.org/jira/browse/DRILL-18
>             Project: Apache Drill
>          Issue Type: Bug
>            Reporter: Ted Dunning
>             Fix For: 0.4.0
>
>         Attachments: DRILL-18.patch
>
>
> Hi, I wrote some codes for query parser. These diffs are aimed to pass test
> case of query parser, especially org.apache.drill.parsers.DrqlParserTest.
> To do that, I modified the DrqlAntlr.g and AntlrParser.java.
> - Add some rules (N_AGGREGATE_FUNCTION, aggregateFunc, ... )
> - Swap groupbyClause rule and havingCaluse rule in selectStatement
> - Modify some parsing routine in AntlrParser.java
> I think that the defined grammar still has some problems even if this diff
> is applied. Also, it is not important thing. However, you can pass test
> case ;)



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)