You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Will Berkeley (Code Review)" <ge...@cloudera.org> on 2019/06/03 09:34:21 UTC
[kudu-CR] [backup] Deflake TestKuduBackup.testRandomBackupAndRestore
Will Berkeley has uploaded this change for review. ( http://gerrit.cloudera.org:8080/13499
Change subject: [backup] Deflake TestKuduBackup.testRandomBackupAndRestore
......................................................................
[backup] Deflake TestKuduBackup.testRandomBackupAndRestore
TestKuduBackup.testRandomBackupAndRestore was flaky because it the
DataGenerator sometimes generated duplicate rows, which caused count
mismatches between the number of rows upserted and the number of rows
scanned from the table (particularly when the random schema had a single
INT8 primary key). This fix works around the problem by eliminating the
validation of backups against the generated rows, reducing the set of
validations to just the validation of the final state of the table
against the restored table.
Change-Id: Ic8500f884b05d09a8679863c380dd89f1675519f
---
M java/kudu-backup/src/test/scala/org/apache/kudu/backup/TestKuduBackup.scala
1 file changed, 8 insertions(+), 5 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/99/13499/1
--
To view, visit http://gerrit.cloudera.org:8080/13499
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ic8500f884b05d09a8679863c380dd89f1675519f
Gerrit-Change-Number: 13499
Gerrit-PatchSet: 1
Gerrit-Owner: Will Berkeley <wd...@gmail.com>
[kudu-CR] [backup] Deflake TestKuduBackup.testRandomBackupAndRestore
Posted by "Will Berkeley (Code Review)" <ge...@cloudera.org>.
Will Berkeley has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/13499 )
Change subject: [backup] Deflake TestKuduBackup.testRandomBackupAndRestore
......................................................................
[backup] Deflake TestKuduBackup.testRandomBackupAndRestore
TestKuduBackup.testRandomBackupAndRestore was flaky because it the
DataGenerator sometimes generated duplicate rows, which caused count
mismatches between the number of rows upserted and the number of rows
scanned from the table (particularly when the random schema had a single
INT8 primary key). This fix works around the problem by eliminating the
validation of backups against the generated rows, reducing the set of
validations to just the validation of the final state of the table
against the restored table.
Change-Id: Ic8500f884b05d09a8679863c380dd89f1675519f
Reviewed-on: http://gerrit.cloudera.org:8080/13499
Tested-by: Kudu Jenkins
Reviewed-by: Grant Henke <gr...@apache.org>
---
M java/kudu-backup/src/test/scala/org/apache/kudu/backup/TestKuduBackup.scala
1 file changed, 9 insertions(+), 5 deletions(-)
Approvals:
Kudu Jenkins: Verified
Grant Henke: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/13499
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic8500f884b05d09a8679863c380dd89f1675519f
Gerrit-Change-Number: 13499
Gerrit-PatchSet: 4
Gerrit-Owner: Will Berkeley <wd...@gmail.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
[kudu-CR] [backup] Deflake TestKuduBackup.testRandomBackupAndRestore
Posted by "Will Berkeley (Code Review)" <ge...@cloudera.org>.
Hello Mike Percy, Kudu Jenkins, Adar Dembo, Grant Henke,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/13499
to look at the new patch set (#3).
Change subject: [backup] Deflake TestKuduBackup.testRandomBackupAndRestore
......................................................................
[backup] Deflake TestKuduBackup.testRandomBackupAndRestore
TestKuduBackup.testRandomBackupAndRestore was flaky because it the
DataGenerator sometimes generated duplicate rows, which caused count
mismatches between the number of rows upserted and the number of rows
scanned from the table (particularly when the random schema had a single
INT8 primary key). This fix works around the problem by eliminating the
validation of backups against the generated rows, reducing the set of
validations to just the validation of the final state of the table
against the restored table.
Change-Id: Ic8500f884b05d09a8679863c380dd89f1675519f
---
M java/kudu-backup/src/test/scala/org/apache/kudu/backup/TestKuduBackup.scala
1 file changed, 9 insertions(+), 5 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/99/13499/3
--
To view, visit http://gerrit.cloudera.org:8080/13499
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ic8500f884b05d09a8679863c380dd89f1675519f
Gerrit-Change-Number: 13499
Gerrit-PatchSet: 3
Gerrit-Owner: Will Berkeley <wd...@gmail.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
[kudu-CR] [backup] Deflake TestKuduBackup.testRandomBackupAndRestore
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/13499 )
Change subject: [backup] Deflake TestKuduBackup.testRandomBackupAndRestore
......................................................................
Patch Set 3: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/13499
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic8500f884b05d09a8679863c380dd89f1675519f
Gerrit-Change-Number: 13499
Gerrit-PatchSet: 3
Gerrit-Owner: Will Berkeley <wd...@gmail.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Comment-Date: Mon, 03 Jun 2019 16:10:11 +0000
Gerrit-HasComments: No