You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/11/18 23:31:24 UTC
[GitHub] [airflow] potiuk opened a new pull request #19693: Fix failures with recent moto library 2.2.15
potiuk opened a new pull request #19693:
URL: https://github.com/apache/airflow/pull/19693
The recent moto library is more picky about parameters
passed to it:
* when you are sending too old logs they are rejected
* when you are passing cloud formation template they are parsed
and validated for correctness
Our tests had artifficial values for those, which caused failures
with the recent moto version.
This PR provides realistic values in tests to pass moto validation
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/main/UPDATING.md).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk merged pull request #19693: Fix failures with recent moto library 2.2.15
Posted by GitBox <gi...@apache.org>.
potiuk merged pull request #19693:
URL: https://github.com/apache/airflow/pull/19693
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #19693: Fix failures with recent moto library 2.2.15
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #19693:
URL: https://github.com/apache/airflow/pull/19693#issuecomment-973444690
That should fix `main` failures with the most recent moto library (for example here: https://github.com/apache/airflow/runs/4256547245?check_suite_focus=true#step:6:12964
I also bumped min moto version, partially to get the "eager upgrade" and partilly to make sure recent versions are forced.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #19693: Fix failures with recent moto library 2.2.15
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #19693:
URL: https://github.com/apache/airflow/pull/19693#issuecomment-973635612
Failure is for different reason - badly merged PR due to "false positiive" test results in tests merged. Fixing in the follow-up PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #19693: Fix failures with recent moto library 2.2.15
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #19693:
URL: https://github.com/apache/airflow/pull/19693#issuecomment-973496301
The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest main at your convenience, or amend the last commit of the PR, and push it with --force-with-lease.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org