[GitHub] markusthoemmes commented on a change in pull request #3795: Allow Elasticsearch 'must' query to take an array of 'ranges'

[GitBox <gi...@apache.org>]

markusthoemmes commented on a change in pull request #3795: Allow Elasticsearch 'must' query to take an array of 'ranges'
URL: https://github.com/apache/incubator-openwhisk/pull/3795#discussion_r199944445
 
 

 ##########
 File path: common/scala/src/main/scala/whisk/core/containerpool/logging/ElasticSearchRestClient.scala
 ##########
 @@ -59,7 +59,8 @@ case class EsQueryBoolMatch(key: String, value: String)
 case class EsQueryOrder(field: String, kind: EsOrder)
 case class EsQuerySize(size: Integer)
 case class EsQueryAll() extends EsQueryMethod
-case class EsQueryMust(matches: Vector[EsQueryBoolMatch], range: Option[EsQueryRange] = None) extends EsQueryMethod
+case class EsQueryMust(matches: Vector[EsQueryBoolMatch], range: Option[Vector[EsQueryRange]] = None)
 
 Review comment:
   Can `range` be "just" be a `Vector` defaulting to `empty`? Since the jsonformat is manual anyway, we can just omit the whole thing if the list is empty. Thoughts?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services