You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mynewt.apache.org by GitBox <gi...@apache.org> on 2018/09/07 21:15:31 UTC
[GitHub] ccollins476ad commented on a change in pull request #1390:
sys/console/full: Prevent permanent rx stall
ccollins476ad commented on a change in pull request #1390: sys/console/full: Prevent permanent rx stall
URL: https://github.com/apache/mynewt-core/pull/1390#discussion_r216089104
##########
File path: sys/console/full/src/uart_console.c
##########
@@ -230,19 +230,16 @@ uart_console_rx_char_event(struct os_event *ev)
static int b = -1;
int sr;
int ret;
+ bool full;
+
+ full = uart_console_ring_is_full(&cr_rx);
/* We may have unhandled character - try it first */
if (b >= 0) {
ret = console_handle_char(b);
if (ret < 0) {
- return;
+ goto done;
Review comment:
Good point.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services