You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by patrickmcgloin <gi...@git.apache.org> on 2018/06/29 14:57:56 UTC
[GitHub] spark pull request #21670: [SPARK-24682] [SQL] from_json / to_json now handl...
GitHub user patrickmcgloin opened a pull request:
https://github.com/apache/spark/pull/21670
[SPARK-24682] [SQL] from_json / to_json now handle java.sql.Date/Timestamp as Map key
## What changes were proposed in this pull request?
When generating JSON the key is not just converted to a String now, instead the type is checked and for Dates and Timestamps the formatting happens first (if provided). When reading JSON, if the Schema says that a Map has a Date or Timestamp as the key then once again the formatting is done before the String is converted to the correct value for a Date or Timestamp.
## How was this patch tested?
I have added Unit Tests.
Please review http://spark.apache.org/contributing.html before opening a pull request.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/patrickmcgloin/spark master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/21670.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #21670
----
commit 58576fabf7b3ba93c177c78356bb17492e8b3d80
Author: Patrick McGloin <mc...@...>
Date: 2018-03-30T14:09:25Z
SPARK-23565: Improved error message for when the number of sources for a query changes
commit 7e88efab0c1479c1bf1e2df42906873ed2f5e050
Author: Patrick McGloin <mc...@...>
Date: 2018-04-25T16:51:09Z
Only one space after the period / dot
commit b35acf543cc0af66a56081457c53ab450b4cdcdb
Author: Patrick McGloin <mc...@...>
Date: 2018-04-25T16:52:57Z
Removed UNT as not needed for logging change
----
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #21670: [SPARK-24682] [SQL] from_json / to_json now handl...
Posted by patrickmcgloin <gi...@git.apache.org>.
Github user patrickmcgloin closed the pull request at:
https://github.com/apache/spark/pull/21670
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #21670: [SPARK-24682] [SQL] from_json / to_json now handle java....
Posted by patrickmcgloin <gi...@git.apache.org>.
Github user patrickmcgloin commented on the issue:
https://github.com/apache/spark/pull/21670
This is mistake. I have not put the correct code changes with the pull request. Will close.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org