You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@commons.apache.org by "Adam Heath (JIRA)" <ji...@apache.org> on 2007/05/14 17:29:16 UTC
[jira] Created: (VFS-156) Use a set to hold the listeners in
AbstractFileSystem
Use a set to hold the listeners in AbstractFileSystem
-----------------------------------------------------
Key: VFS-156
URL: https://issues.apache.org/jira/browse/VFS-156
Project: Commons VFS
Issue Type: Improvement
Affects Versions: 1.1
Reporter: Adam Heath
Priority: Minor
Use a set(from commons-collections) to hold the listeners, so that a listener isn't added multiple times.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org
[jira] Updated: (VFS-156) Use a set to hold the listeners in
AbstractFileSystem
Posted by "Adam Heath (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/VFS-156?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Adam Heath updated VFS-156:
---------------------------
Attachment: feature_ListOrderedSet-listeners.patch
Against svn 501759.
> Use a set to hold the listeners in AbstractFileSystem
> -----------------------------------------------------
>
> Key: VFS-156
> URL: https://issues.apache.org/jira/browse/VFS-156
> Project: Commons VFS
> Issue Type: Improvement
> Affects Versions: 1.1
> Reporter: Adam Heath
> Priority: Minor
> Attachments: feature_ListOrderedSet-listeners.patch
>
>
> Use a set(from commons-collections) to hold the listeners, so that a listener isn't added multiple times.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org
[jira] Resolved: (VFS-156) Use a set to hold the listeners in
AbstractFileSystem
Posted by "Mario Ivankovits (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/VFS-156?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Mario Ivankovits resolved VFS-156.
----------------------------------
Resolution: Won't Fix
Adding a new (non optional) dependency is a no go.
If we would like to avoid duplicate adds of listeners we can add a if (list.contains), though, I am fine with leaving this responsibility at the user.
> Use a set to hold the listeners in AbstractFileSystem
> -----------------------------------------------------
>
> Key: VFS-156
> URL: https://issues.apache.org/jira/browse/VFS-156
> Project: Commons VFS
> Issue Type: Improvement
> Affects Versions: 1.1
> Reporter: Adam Heath
> Priority: Minor
> Attachments: feature_ListOrderedSet-listeners.patch
>
>
> Use a set(from commons-collections) to hold the listeners, so that a listener isn't added multiple times.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org
[jira] Commented: (VFS-156) Use a set to hold the listeners in
AbstractFileSystem
Posted by "Adam Heath (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/VFS-156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12495758 ]
Adam Heath commented on VFS-156:
--------------------------------
Well, how can the user detect whether a listener is already added? Such a method does not exist in FileSystem. Then, you have the problem of synchronization and locking.
It's not a new dependency; see LRUFilesCache. It uses commons-collections already.
If my patch had required a new dependency, I would have said so.
> Use a set to hold the listeners in AbstractFileSystem
> -----------------------------------------------------
>
> Key: VFS-156
> URL: https://issues.apache.org/jira/browse/VFS-156
> Project: Commons VFS
> Issue Type: Improvement
> Affects Versions: 1.1
> Reporter: Adam Heath
> Priority: Minor
> Attachments: feature_ListOrderedSet-listeners.patch
>
>
> Use a set(from commons-collections) to hold the listeners, so that a listener isn't added multiple times.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org
[jira] Commented: (VFS-156) Use a set to hold the listeners in
AbstractFileSystem
Posted by "Mario Ivankovits (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/VFS-156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12495763 ]
Mario Ivankovits commented on VFS-156:
--------------------------------------
reg LRUFileCache: I'll deprecate any cache other than the SoftRef, WeakRef as with any other implementation VFS will leak memory too ... it will never free the FileSystem map .... if you don't come up with a patch for this too :-)
Even then LRUFileCache is optional.
Might it be sufficient to add a method e.g. hasFileListener(xx) ?
> Use a set to hold the listeners in AbstractFileSystem
> -----------------------------------------------------
>
> Key: VFS-156
> URL: https://issues.apache.org/jira/browse/VFS-156
> Project: Commons VFS
> Issue Type: Improvement
> Affects Versions: 1.1
> Reporter: Adam Heath
> Priority: Minor
> Attachments: feature_ListOrderedSet-listeners.patch
>
>
> Use a set(from commons-collections) to hold the listeners, so that a listener isn't added multiple times.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org