You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/01/26 14:54:28 UTC
[GitHub] [arrow] okadakk opened a new pull request #12271: ARROW-15463: [GLib] Add arrow::compute::Utf8NormalizeOptions bindings
okadakk opened a new pull request #12271:
URL: https://github.com/apache/arrow/pull/12271
This PR adds utf8 normalize options bindings.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot edited a comment on pull request #12271: ARROW-15463: [GLib] Add arrow::compute::Utf8NormalizeOptions bindings
Posted by GitBox <gi...@apache.org>.
ursabot edited a comment on pull request #12271:
URL: https://github.com/apache/arrow/pull/12271#issuecomment-1024014621
Benchmark runs are scheduled for baseline = 3663971f17cc5cc32bb389ad959eb5b30dacb1e1 and contender = c692c8842a959c2af0e68bc2f20f72d5f2a2ec67. c692c8842a959c2af0e68bc2f20f72d5f2a2ec67 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished :arrow_down:0.0% :arrow_up:0.0%] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/69f8be77e75049108670eb249c832996...1f967bfbef1d4c8a84d3a756db4508d2/)
[Finished :arrow_down:0.0% :arrow_up:0.0%] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/9752d6b458324331a1ad492b012253a3...12eaf260b414465bab0844f8b09cd72a/)
[Finished :arrow_down:0.22% :arrow_up:0.13%] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/b38b93db8b7449d78f31a382fe964945...5a9250140d1c474c85189891c69bc45e/)
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python. Runs only benchmarks with cloud = True
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou commented on a change in pull request #12271: ARROW-15463: [GLib] Add arrow::compute::Utf8NormalizeOptions bindings
Posted by GitBox <gi...@apache.org>.
kou commented on a change in pull request #12271:
URL: https://github.com/apache/arrow/pull/12271#discussion_r794293854
##########
File path: c_glib/arrow-glib/compute.cpp
##########
@@ -5192,3 +5301,21 @@ garrow_round_to_multiple_options_get_raw(GArrowRoundToMultipleOptions *options)
return static_cast<arrow::compute::RoundToMultipleOptions *>(
garrow_function_options_get_raw(GARROW_FUNCTION_OPTIONS(options)));
}
+
+
+GArrowUTF8NormalizeOptions *
+garrow_utf8_normalize_options_new_raw(
+ const arrow::compute::Utf8NormalizeOptions *arrow_options)
+{
+ auto options = g_object_new(GARROW_TYPE_UT_F8_NORMALIZE_FORM,
Review comment:
`glib-mkenums` guesses wrong identifier.
I added an annotation to specify correct identifier explicitly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot commented on pull request #12271: ARROW-15463: [GLib] Add arrow::compute::Utf8NormalizeOptions bindings
Posted by GitBox <gi...@apache.org>.
ursabot commented on pull request #12271:
URL: https://github.com/apache/arrow/pull/12271#issuecomment-1024014621
Benchmark runs are scheduled for baseline = 3663971f17cc5cc32bb389ad959eb5b30dacb1e1 and contender = c692c8842a959c2af0e68bc2f20f72d5f2a2ec67. c692c8842a959c2af0e68bc2f20f72d5f2a2ec67 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Scheduled] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/69f8be77e75049108670eb249c832996...1f967bfbef1d4c8a84d3a756db4508d2/)
[Scheduled] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/9752d6b458324331a1ad492b012253a3...12eaf260b414465bab0844f8b09cd72a/)
[Scheduled] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/b38b93db8b7449d78f31a382fe964945...5a9250140d1c474c85189891c69bc45e/)
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python. Runs only benchmarks with cloud = True
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #12271: ARROW-15463: [GLib] Add arrow::compute::Utf8NormalizeOptions bindings
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #12271:
URL: https://github.com/apache/arrow/pull/12271#issuecomment-1022289470
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou commented on a change in pull request #12271: ARROW-15463: [GLib] Add arrow::compute::Utf8NormalizeOptions bindings
Posted by GitBox <gi...@apache.org>.
kou commented on a change in pull request #12271:
URL: https://github.com/apache/arrow/pull/12271#discussion_r793183358
##########
File path: c_glib/test/test-utf8-normalize-options.rb
##########
@@ -0,0 +1,30 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+class TestUtf8NormalizeOptions < Test::Unit::TestCase
Review comment:
```suggestion
class TestUTF8NormalizeOptions < Test::Unit::TestCase
```
##########
File path: c_glib/test/test-utf8-normalize-options.rb
##########
@@ -0,0 +1,30 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+class TestUtf8NormalizeOptions < Test::Unit::TestCase
+ include Helper::Buildable
+
+ def setup
+ @options = Arrow::Utf8NormalizeOptions.new
+ end
+
+ def test_mode
Review comment:
```suggestion
def test_form
```
##########
File path: c_glib/arrow-glib/compute.h
##########
@@ -675,6 +675,40 @@ GArrowRoundToMultipleOptions *
garrow_round_to_multiple_options_new(void);
+/**
+ * GArrowUtf8NormalizeForm:
Review comment:
Could you use `UTF` not `Utf`? We don't want to capitalize acronym such as HTTP and CSV.
```suggestion
* GArrowUtf8NormalizeForm:
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou closed pull request #12271: ARROW-15463: [GLib] Add arrow::compute::Utf8NormalizeOptions bindings
Posted by GitBox <gi...@apache.org>.
kou closed pull request #12271:
URL: https://github.com/apache/arrow/pull/12271
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] okadakk commented on a change in pull request #12271: ARROW-15463: [GLib] Add arrow::compute::Utf8NormalizeOptions bindings
Posted by GitBox <gi...@apache.org>.
okadakk commented on a change in pull request #12271:
URL: https://github.com/apache/arrow/pull/12271#discussion_r793684657
##########
File path: c_glib/arrow-glib/compute.cpp
##########
@@ -5192,3 +5301,21 @@ garrow_round_to_multiple_options_get_raw(GArrowRoundToMultipleOptions *options)
return static_cast<arrow::compute::RoundToMultipleOptions *>(
garrow_function_options_get_raw(GARROW_FUNCTION_OPTIONS(options)));
}
+
+
+GArrowUTF8NormalizeOptions *
+garrow_utf8_normalize_options_new_raw(
+ const arrow::compute::Utf8NormalizeOptions *arrow_options)
+{
+ auto options = g_object_new(GARROW_TYPE_UT_F8_NORMALIZE_FORM,
Review comment:
I don't know why i can use 'GARROW_TYPE_UTF8_NORMALIZE_FORM' macros.
When compiling, I get the following error: ``use of undeclared identifier 'GARROW_TYPE_UTF8_NORMALIZE_FORM``
Could you tell me how to fix it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou commented on pull request #12271: ARROW-15463: [GLib] Add arrow::compute::Utf8NormalizeOptions bindings
Posted by GitBox <gi...@apache.org>.
kou commented on pull request #12271:
URL: https://github.com/apache/arrow/pull/12271#issuecomment-1022774604
Could you mention `GArrowUTF8NormalizeOptions` in header document in `compute.cpp`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot edited a comment on pull request #12271: ARROW-15463: [GLib] Add arrow::compute::Utf8NormalizeOptions bindings
Posted by GitBox <gi...@apache.org>.
ursabot edited a comment on pull request #12271:
URL: https://github.com/apache/arrow/pull/12271#issuecomment-1024014621
Benchmark runs are scheduled for baseline = 3663971f17cc5cc32bb389ad959eb5b30dacb1e1 and contender = c692c8842a959c2af0e68bc2f20f72d5f2a2ec67. c692c8842a959c2af0e68bc2f20f72d5f2a2ec67 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished :arrow_down:0.0% :arrow_up:0.0%] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/69f8be77e75049108670eb249c832996...1f967bfbef1d4c8a84d3a756db4508d2/)
[Scheduled] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/9752d6b458324331a1ad492b012253a3...12eaf260b414465bab0844f8b09cd72a/)
[Scheduled] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/b38b93db8b7449d78f31a382fe964945...5a9250140d1c474c85189891c69bc45e/)
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python. Runs only benchmarks with cloud = True
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot edited a comment on pull request #12271: ARROW-15463: [GLib] Add arrow::compute::Utf8NormalizeOptions bindings
Posted by GitBox <gi...@apache.org>.
ursabot edited a comment on pull request #12271:
URL: https://github.com/apache/arrow/pull/12271#issuecomment-1024014621
Benchmark runs are scheduled for baseline = 3663971f17cc5cc32bb389ad959eb5b30dacb1e1 and contender = c692c8842a959c2af0e68bc2f20f72d5f2a2ec67. c692c8842a959c2af0e68bc2f20f72d5f2a2ec67 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished :arrow_down:0.0% :arrow_up:0.0%] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/69f8be77e75049108670eb249c832996...1f967bfbef1d4c8a84d3a756db4508d2/)
[Scheduled] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/9752d6b458324331a1ad492b012253a3...12eaf260b414465bab0844f8b09cd72a/)
[Finished :arrow_down:0.22% :arrow_up:0.13%] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/b38b93db8b7449d78f31a382fe964945...5a9250140d1c474c85189891c69bc45e/)
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python. Runs only benchmarks with cloud = True
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] okadakk commented on a change in pull request #12271: ARROW-15463: [GLib] Add arrow::compute::Utf8NormalizeOptions bindings
Posted by GitBox <gi...@apache.org>.
okadakk commented on a change in pull request #12271:
URL: https://github.com/apache/arrow/pull/12271#discussion_r793684657
##########
File path: c_glib/arrow-glib/compute.cpp
##########
@@ -5192,3 +5301,21 @@ garrow_round_to_multiple_options_get_raw(GArrowRoundToMultipleOptions *options)
return static_cast<arrow::compute::RoundToMultipleOptions *>(
garrow_function_options_get_raw(GARROW_FUNCTION_OPTIONS(options)));
}
+
+
+GArrowUTF8NormalizeOptions *
+garrow_utf8_normalize_options_new_raw(
+ const arrow::compute::Utf8NormalizeOptions *arrow_options)
+{
+ auto options = g_object_new(GARROW_TYPE_UT_F8_NORMALIZE_FORM,
Review comment:
I don't know why i can use 'GARROW_TYPE_UTF8_NORMALIZE_FORM' variable.
When compiling, I get the following error: ``use of undeclared identifier 'GARROW_TYPE_UTF8_NORMALIZE_FORM``
Could you tell me how to fix it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] okadakk commented on pull request #12271: ARROW-15463: [GLib] Add arrow::compute::Utf8NormalizeOptions bindings
Posted by GitBox <gi...@apache.org>.
okadakk commented on pull request #12271:
URL: https://github.com/apache/arrow/pull/12271#issuecomment-1023292758
@kou
Thank you for reviewing!
I faced an unsolvable problem...
Could you tell me how to fix it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org