You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@groovy.apache.org by jw...@apache.org on 2016/08/23 02:15:58 UTC
[3/5] groovy git commit: findbugs: impossible instanceof
findbugs: impossible instanceof
loop.getBooleanExpression() can't return a ConstantExpression and the if branch never executed.
Project: http://git-wip-us.apache.org/repos/asf/groovy/repo
Commit: http://git-wip-us.apache.org/repos/asf/groovy/commit/bf398af7
Tree: http://git-wip-us.apache.org/repos/asf/groovy/tree/bf398af7
Diff: http://git-wip-us.apache.org/repos/asf/groovy/diff/bf398af7
Branch: refs/heads/master
Commit: bf398af7a0a7cf8dfd8d3a6fedac61ff00ff766f
Parents: f175e34
Author: John Wagenleitner <jw...@apache.org>
Authored: Sun Aug 21 14:46:58 2016 -0700
Committer: John Wagenleitner <jw...@apache.org>
Committed: Mon Aug 22 19:11:09 2016 -0700
----------------------------------------------------------------------
.../org/codehaus/groovy/classgen/asm/StatementWriter.java | 7 ++++---
1 file changed, 4 insertions(+), 3 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/groovy/blob/bf398af7/src/main/org/codehaus/groovy/classgen/asm/StatementWriter.java
----------------------------------------------------------------------
diff --git a/src/main/org/codehaus/groovy/classgen/asm/StatementWriter.java b/src/main/org/codehaus/groovy/classgen/asm/StatementWriter.java
index a91ac4c..5c14e73 100644
--- a/src/main/org/codehaus/groovy/classgen/asm/StatementWriter.java
+++ b/src/main/org/codehaus/groovy/classgen/asm/StatementWriter.java
@@ -25,6 +25,7 @@ import org.codehaus.groovy.ast.ClassHelper;
import org.codehaus.groovy.ast.ClassNode;
import org.codehaus.groovy.ast.Parameter;
import org.codehaus.groovy.ast.expr.ArgumentListExpression;
+import org.codehaus.groovy.ast.expr.BooleanExpression;
import org.codehaus.groovy.ast.expr.ClosureListExpression;
import org.codehaus.groovy.ast.expr.ConstantExpression;
import org.codehaus.groovy.ast.expr.EmptyExpression;
@@ -228,10 +229,10 @@ public class StatementWriter {
Label breakLabel = controller.getCompileStack().getBreakLabel();
mv.visitLabel(continueLabel);
- Expression bool = loop.getBooleanExpression();
+ BooleanExpression bool = loop.getBooleanExpression();
boolean boolHandled = false;
- if (bool instanceof ConstantExpression) {
- ConstantExpression constant = (ConstantExpression) bool;
+ if (bool.getExpression() instanceof ConstantExpression) {
+ ConstantExpression constant = (ConstantExpression) bool.getExpression();
if (constant.getValue()==Boolean.TRUE) {
boolHandled = true;
// do nothing