You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@devlake.apache.org by GitBox <gi...@apache.org> on 2022/08/22 03:45:06 UTC

[GitHub] [incubator-devlake] klesh opened a new issue, #2788: [Feature][config-ui] Supports `db migration confirmation`

klesh opened a new issue, #2788:
URL: https://github.com/apache/incubator-devlake/issues/2788

   ### Search before asking
   
   - [X] I had searched in the [issues](https://github.com/apache/incubator-devlake/issues?q=is%3Aissue) and found no similar feature requirement.
   
   
   ### Description
   
   Currently, users have to `curl /api/proceed-db-migration` if there were pending migration scripts manually.
   
   ![image](https://user-images.githubusercontent.com/61080/185833787-04e7e738-f455-4590-8fb1-cd2febc3b3ae.png)
   
   We should offer a flow in to allow users to confirm the operation `config-ui`.
   For example: 
   redirect to a page which describe the risk of applying db-migration-scripts, telling them they could switch back to the previous version if they will. offer a button "confirm and proceed" on the page if they would like to upgrade.
   
   ### Use case
   
   Users could finish the upgrade in `config-ui`
   
   ### Related issues
   
   _No response_
   
   ### Are you willing to submit a PR?
   
   - [ ] Yes I am willing to submit a PR!
   
   ### Code of Conduct
   
   - [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [incubator-devlake] yumengwang03 commented on issue #2788: [Feature][config-ui] Supports `db migration confirmation`

Posted by GitBox <gi...@apache.org>.
yumengwang03 commented on issue #2788:
URL: https://github.com/apache/incubator-devlake/issues/2788#issuecomment-1230365994

   <img width="1011" alt="Screen Shot 2022-08-29 at 10 12 22 PM" src="https://user-images.githubusercontent.com/9535430/187221528-8aca23cd-1811-4525-987e-7dd7750480db.png">
   
   Just updated based on feedback. Does this look right? @klesh @e2corporation 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [incubator-devlake] klesh closed issue #2788: [Feature][config-ui] Supports `db migration confirmation`

Posted by GitBox <gi...@apache.org>.
klesh closed issue #2788: [Feature][config-ui] Supports `db migration confirmation`
URL: https://github.com/apache/incubator-devlake/issues/2788


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [incubator-devlake] tanninghan commented on issue #2788: [Feature][config-ui] Supports `db migration confirmation`

Posted by GitBox <gi...@apache.org>.
tanninghan commented on issue #2788:
URL: https://github.com/apache/incubator-devlake/issues/2788#issuecomment-1225363406

   ![image](https://user-images.githubusercontent.com/102040651/186367544-c0d64347-2459-4ab6-8cb8-23a1fef0a81b.png)
   See design here: https://www.figma.com/file/Eux4Dhorxp7M0TwzOnL6Yh/Config-UI-for-V1.0?node-id=1291%3A10778


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [incubator-devlake] klesh commented on issue #2788: [Feature][config-ui] Supports `db migration confirmation`

Posted by GitBox <gi...@apache.org>.
klesh commented on issue #2788:
URL: https://github.com/apache/incubator-devlake/issues/2788#issuecomment-1227057722

   @e2corporation Nothing... One would have to revert the docker-compose / k8s-deployment and then restart the containers. We don't need the Downgrade button, and the Error Message has to be Rephased in config-ui, do NOT use the original error message from the API response directly.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [incubator-devlake] e2corporation commented on issue #2788: [Feature][config-ui] Supports `db migration confirmation`

Posted by GitBox <gi...@apache.org>.
e2corporation commented on issue #2788:
URL: https://github.com/apache/incubator-devlake/issues/2788#issuecomment-1225654905

   @klesh What happens when Downgrade option is selected?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [incubator-devlake] e2corporation commented on issue #2788: [Feature][config-ui] Supports `db migration confirmation`

Posted by GitBox <gi...@apache.org>.
e2corporation commented on issue #2788:
URL: https://github.com/apache/incubator-devlake/issues/2788#issuecomment-1230376095

   @yumengwang03 Please see screenshots on this development PR for Migration feature, https://github.com/apache/incubator-devlake/pull/2859.
   
   It looks like additional information on how to manually approve the migration was removed from the initial notice?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org