You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@commons.apache.org by ah...@apache.org on 2020/06/30 13:38:22 UTC
[commons-numbers] branch master updated (ebbbf92 -> 6b0e82a)
This is an automated email from the ASF dual-hosted git repository.
aherbert pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/commons-numbers.git.
from ebbbf92 Use assertThrows
new e3712b4 Remove public modifiers for test fixtures.
new 2080a7b Remove commented out code.
new 6b0e82a Remove extra if statement.
The 3 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails. The revisions
listed as "add" were already present in the repository and have only
been added to this reference.
Summary of changes:
.../apache/commons/numbers/angle/PlaneAngleRadiansTest.java | 2 +-
.../org/apache/commons/numbers/angle/PlaneAngleTest.java | 2 +-
.../java/org/apache/commons/numbers/arrays/CosAngleTest.java | 2 +-
.../apache/commons/numbers/arrays/LinearCombinationTest.java | 2 +-
.../commons/numbers/arrays/MultidimensionalCounterTest.java | 2 +-
.../java/org/apache/commons/numbers/arrays/SafeNormTest.java | 2 +-
.../numbers/combinatorics/BinomialCoefficientDoubleTest.java | 2 +-
.../numbers/combinatorics/BinomialCoefficientTest.java | 2 +-
.../commons/numbers/combinatorics/CombinationsTest.java | 2 +-
.../commons/numbers/combinatorics/FactorialDoubleTest.java | 2 +-
.../apache/commons/numbers/combinatorics/FactorialTest.java | 2 +-
.../numbers/combinatorics/LogBinomialCoefficientTest.java | 2 +-
.../commons/numbers/combinatorics/LogFactorialTest.java | 2 +-
.../commons/numbers/complex/streams/ComplexUtilsTest.java | 2 +-
.../org/apache/commons/numbers/complex/CReferenceTest.java | 2 +-
.../org/apache/commons/numbers/complex/CStandardTest.java | 2 +-
.../apache/commons/numbers/complex/ComplexEdgeCaseTest.java | 2 +-
.../java/org/apache/commons/numbers/complex/ComplexTest.java | 2 +-
.../org/apache/commons/numbers/core/ArithmeticUtilsTest.java | 2 +-
.../java/org/apache/commons/numbers/core/PrecisionTest.java | 2 +-
.../numbers/examples/jmh/arrays/DoublePrecisionTest.java | 2 +-
.../examples/jmh/arrays/LinearCombinationAccuracyTest.java | 6 +++---
.../numbers/examples/jmh/arrays/LinearCombinationsTest.java | 12 ++++++------
.../test/java/org/apache/commons/numbers/field/FP64Test.java | 2 +-
.../apache/commons/numbers/field/FieldParametricTest.java | 2 +-
.../org/apache/commons/numbers/fraction/BigFractionTest.java | 2 +-
.../commons/numbers/fraction/ContinuedFractionTest.java | 2 +-
.../org/apache/commons/numbers/fraction/FractionTest.java | 2 +-
.../java/org/apache/commons/numbers/gamma/DigammaTest.java | 2 +-
.../org/apache/commons/numbers/gamma/ErfDifferenceTest.java | 2 +-
.../test/java/org/apache/commons/numbers/gamma/ErfTest.java | 2 +-
.../test/java/org/apache/commons/numbers/gamma/ErfcTest.java | 2 +-
.../java/org/apache/commons/numbers/gamma/GammaTest.java | 2 +-
.../org/apache/commons/numbers/gamma/InvGamma1pm1Test.java | 2 +-
.../org/apache/commons/numbers/gamma/InverseErfTest.java | 2 +-
.../org/apache/commons/numbers/gamma/InverseErfcTest.java | 2 +-
.../commons/numbers/gamma/LanczosApproximationTest.java | 2 +-
.../java/org/apache/commons/numbers/gamma/LogBetaTest.java | 2 +-
.../org/apache/commons/numbers/gamma/LogGamma1pTest.java | 2 +-
.../org/apache/commons/numbers/gamma/LogGammaSumTest.java | 2 +-
.../java/org/apache/commons/numbers/gamma/LogGammaTest.java | 2 +-
.../apache/commons/numbers/gamma/RegularizedBetaTest.java | 2 +-
.../apache/commons/numbers/gamma/RegularizedGammaTest.java | 2 +-
.../java/org/apache/commons/numbers/gamma/TrigammaTest.java | 2 +-
.../main/java/org/apache/commons/numbers/primes/Primes.java | 6 +-----
.../java/org/apache/commons/numbers/primes/PrimesTest.java | 2 +-
.../org/apache/commons/numbers/primes/SmallPrimesTest.java | 2 +-
.../apache/commons/numbers/quaternion/QuaternionTest.java | 2 +-
.../org/apache/commons/numbers/quaternion/SlerpTest.java | 2 +-
.../apache/commons/numbers/rootfinder/BrentSolverTest.java | 2 +-
50 files changed, 57 insertions(+), 61 deletions(-)
[commons-numbers] 01/03: Remove public modifiers for test fixtures.
Posted by ah...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
aherbert pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-numbers.git
commit e3712b4bd82dc11b581d7faac2a97da77334747e
Author: aherbert <ah...@apache.org>
AuthorDate: Tue Jun 30 14:00:42 2020 +0100
Remove public modifiers for test fixtures.
---
.../apache/commons/numbers/angle/PlaneAngleRadiansTest.java | 2 +-
.../org/apache/commons/numbers/angle/PlaneAngleTest.java | 2 +-
.../java/org/apache/commons/numbers/arrays/CosAngleTest.java | 2 +-
.../apache/commons/numbers/arrays/LinearCombinationTest.java | 2 +-
.../commons/numbers/arrays/MultidimensionalCounterTest.java | 2 +-
.../java/org/apache/commons/numbers/arrays/SafeNormTest.java | 2 +-
.../numbers/combinatorics/BinomialCoefficientDoubleTest.java | 2 +-
.../numbers/combinatorics/BinomialCoefficientTest.java | 2 +-
.../commons/numbers/combinatorics/CombinationsTest.java | 2 +-
.../commons/numbers/combinatorics/FactorialDoubleTest.java | 2 +-
.../apache/commons/numbers/combinatorics/FactorialTest.java | 2 +-
.../numbers/combinatorics/LogBinomialCoefficientTest.java | 2 +-
.../commons/numbers/combinatorics/LogFactorialTest.java | 2 +-
.../commons/numbers/complex/streams/ComplexUtilsTest.java | 2 +-
.../org/apache/commons/numbers/complex/CReferenceTest.java | 2 +-
.../org/apache/commons/numbers/complex/CStandardTest.java | 2 +-
.../apache/commons/numbers/complex/ComplexEdgeCaseTest.java | 2 +-
.../java/org/apache/commons/numbers/complex/ComplexTest.java | 2 +-
.../org/apache/commons/numbers/core/ArithmeticUtilsTest.java | 2 +-
.../java/org/apache/commons/numbers/core/PrecisionTest.java | 2 +-
.../numbers/examples/jmh/arrays/DoublePrecisionTest.java | 2 +-
.../examples/jmh/arrays/LinearCombinationAccuracyTest.java | 6 +++---
.../numbers/examples/jmh/arrays/LinearCombinationsTest.java | 12 ++++++------
.../test/java/org/apache/commons/numbers/field/FP64Test.java | 2 +-
.../apache/commons/numbers/field/FieldParametricTest.java | 2 +-
.../org/apache/commons/numbers/fraction/BigFractionTest.java | 2 +-
.../commons/numbers/fraction/ContinuedFractionTest.java | 2 +-
.../org/apache/commons/numbers/fraction/FractionTest.java | 2 +-
.../java/org/apache/commons/numbers/gamma/DigammaTest.java | 2 +-
.../org/apache/commons/numbers/gamma/ErfDifferenceTest.java | 2 +-
.../test/java/org/apache/commons/numbers/gamma/ErfTest.java | 2 +-
.../test/java/org/apache/commons/numbers/gamma/ErfcTest.java | 2 +-
.../java/org/apache/commons/numbers/gamma/GammaTest.java | 2 +-
.../org/apache/commons/numbers/gamma/InvGamma1pm1Test.java | 2 +-
.../org/apache/commons/numbers/gamma/InverseErfTest.java | 2 +-
.../org/apache/commons/numbers/gamma/InverseErfcTest.java | 2 +-
.../commons/numbers/gamma/LanczosApproximationTest.java | 2 +-
.../java/org/apache/commons/numbers/gamma/LogBetaTest.java | 2 +-
.../org/apache/commons/numbers/gamma/LogGamma1pTest.java | 2 +-
.../org/apache/commons/numbers/gamma/LogGammaSumTest.java | 2 +-
.../java/org/apache/commons/numbers/gamma/LogGammaTest.java | 2 +-
.../apache/commons/numbers/gamma/RegularizedBetaTest.java | 2 +-
.../apache/commons/numbers/gamma/RegularizedGammaTest.java | 2 +-
.../java/org/apache/commons/numbers/gamma/TrigammaTest.java | 2 +-
.../java/org/apache/commons/numbers/primes/PrimesTest.java | 2 +-
.../org/apache/commons/numbers/primes/SmallPrimesTest.java | 2 +-
.../apache/commons/numbers/quaternion/QuaternionTest.java | 2 +-
.../org/apache/commons/numbers/quaternion/SlerpTest.java | 2 +-
.../apache/commons/numbers/rootfinder/BrentSolverTest.java | 2 +-
49 files changed, 56 insertions(+), 56 deletions(-)
diff --git a/commons-numbers-angle/src/test/java/org/apache/commons/numbers/angle/PlaneAngleRadiansTest.java b/commons-numbers-angle/src/test/java/org/apache/commons/numbers/angle/PlaneAngleRadiansTest.java
index e4484f3..a320e26 100644
--- a/commons-numbers-angle/src/test/java/org/apache/commons/numbers/angle/PlaneAngleRadiansTest.java
+++ b/commons-numbers-angle/src/test/java/org/apache/commons/numbers/angle/PlaneAngleRadiansTest.java
@@ -22,7 +22,7 @@ import org.junit.jupiter.api.Test;
/**
* Test cases for the {@link PlaneAngleRadians} class.
*/
-public class PlaneAngleRadiansTest {
+class PlaneAngleRadiansTest {
@Test
@SuppressWarnings("squid:S3415")
void testConstants() {
diff --git a/commons-numbers-angle/src/test/java/org/apache/commons/numbers/angle/PlaneAngleTest.java b/commons-numbers-angle/src/test/java/org/apache/commons/numbers/angle/PlaneAngleTest.java
index c61d024..2b4fcae 100644
--- a/commons-numbers-angle/src/test/java/org/apache/commons/numbers/angle/PlaneAngleTest.java
+++ b/commons-numbers-angle/src/test/java/org/apache/commons/numbers/angle/PlaneAngleTest.java
@@ -22,7 +22,7 @@ import org.junit.jupiter.api.Test;
/**
* Test cases for the {@link PlaneAngle} class.
*/
-public class PlaneAngleTest {
+class PlaneAngleTest {
@Test
void testConversionTurns() {
final double value = 12.3456;
diff --git a/commons-numbers-arrays/src/test/java/org/apache/commons/numbers/arrays/CosAngleTest.java b/commons-numbers-arrays/src/test/java/org/apache/commons/numbers/arrays/CosAngleTest.java
index 33f9e54..697fcc0 100644
--- a/commons-numbers-arrays/src/test/java/org/apache/commons/numbers/arrays/CosAngleTest.java
+++ b/commons-numbers-arrays/src/test/java/org/apache/commons/numbers/arrays/CosAngleTest.java
@@ -22,7 +22,7 @@ import org.junit.jupiter.api.Test;
/**
* Test cases for the {@link CosAngle} class.
*/
-public class CosAngleTest {
+class CosAngleTest {
@Test
void testCosAngle2D() {
diff --git a/commons-numbers-arrays/src/test/java/org/apache/commons/numbers/arrays/LinearCombinationTest.java b/commons-numbers-arrays/src/test/java/org/apache/commons/numbers/arrays/LinearCombinationTest.java
index fedb4e3..fdb5573 100644
--- a/commons-numbers-arrays/src/test/java/org/apache/commons/numbers/arrays/LinearCombinationTest.java
+++ b/commons-numbers-arrays/src/test/java/org/apache/commons/numbers/arrays/LinearCombinationTest.java
@@ -26,7 +26,7 @@ import org.apache.commons.numbers.fraction.BigFraction;
/**
* Test cases for the {@link LinearCombination} class.
*/
-public class LinearCombinationTest {
+class LinearCombinationTest {
// MATH-1005
@Test
void testSingleElementArray() {
diff --git a/commons-numbers-arrays/src/test/java/org/apache/commons/numbers/arrays/MultidimensionalCounterTest.java b/commons-numbers-arrays/src/test/java/org/apache/commons/numbers/arrays/MultidimensionalCounterTest.java
index b8f05b6..7307eb5 100644
--- a/commons-numbers-arrays/src/test/java/org/apache/commons/numbers/arrays/MultidimensionalCounterTest.java
+++ b/commons-numbers-arrays/src/test/java/org/apache/commons/numbers/arrays/MultidimensionalCounterTest.java
@@ -25,7 +25,7 @@ import org.junit.jupiter.api.Test;
* Test cases for the {@link MultidimensionalCounter} class.
*
*/
-public class MultidimensionalCounterTest {
+class MultidimensionalCounterTest {
@Test
void testPreconditions() {
Assertions.assertThrows(IllegalArgumentException.class, () -> MultidimensionalCounter.of(0, 1));
diff --git a/commons-numbers-arrays/src/test/java/org/apache/commons/numbers/arrays/SafeNormTest.java b/commons-numbers-arrays/src/test/java/org/apache/commons/numbers/arrays/SafeNormTest.java
index b920918..293a96c 100644
--- a/commons-numbers-arrays/src/test/java/org/apache/commons/numbers/arrays/SafeNormTest.java
+++ b/commons-numbers-arrays/src/test/java/org/apache/commons/numbers/arrays/SafeNormTest.java
@@ -22,7 +22,7 @@ import org.junit.jupiter.api.Test;
/**
* Test cases for the {@link SafeNorm} class.
*/
-public class SafeNormTest {
+class SafeNormTest {
@Test
void testTiny() {
diff --git a/commons-numbers-combinatorics/src/test/java/org/apache/commons/numbers/combinatorics/BinomialCoefficientDoubleTest.java b/commons-numbers-combinatorics/src/test/java/org/apache/commons/numbers/combinatorics/BinomialCoefficientDoubleTest.java
index 606b8be..43bd7cf 100644
--- a/commons-numbers-combinatorics/src/test/java/org/apache/commons/numbers/combinatorics/BinomialCoefficientDoubleTest.java
+++ b/commons-numbers-combinatorics/src/test/java/org/apache/commons/numbers/combinatorics/BinomialCoefficientDoubleTest.java
@@ -22,7 +22,7 @@ import org.junit.jupiter.api.Test;
/**
* Test cases for the {@link BinomialCoefficient} class.
*/
-public class BinomialCoefficientDoubleTest {
+class BinomialCoefficientDoubleTest {
/** Verify that b(0,0) = 1 */
@Test
void test0Choose0() {
diff --git a/commons-numbers-combinatorics/src/test/java/org/apache/commons/numbers/combinatorics/BinomialCoefficientTest.java b/commons-numbers-combinatorics/src/test/java/org/apache/commons/numbers/combinatorics/BinomialCoefficientTest.java
index 341f9cc..a843fcb 100644
--- a/commons-numbers-combinatorics/src/test/java/org/apache/commons/numbers/combinatorics/BinomialCoefficientTest.java
+++ b/commons-numbers-combinatorics/src/test/java/org/apache/commons/numbers/combinatorics/BinomialCoefficientTest.java
@@ -27,7 +27,7 @@ import org.junit.jupiter.api.Test;
/**
* Test cases for the {@link BinomialCoefficient} class.
*/
-public class BinomialCoefficientTest {
+class BinomialCoefficientTest {
/** Cached binomial coefficients. */
private static final List<Map<Integer, Long>> binomialCache = new ArrayList<>();
diff --git a/commons-numbers-combinatorics/src/test/java/org/apache/commons/numbers/combinatorics/CombinationsTest.java b/commons-numbers-combinatorics/src/test/java/org/apache/commons/numbers/combinatorics/CombinationsTest.java
index a32a42f..b26f862 100644
--- a/commons-numbers-combinatorics/src/test/java/org/apache/commons/numbers/combinatorics/CombinationsTest.java
+++ b/commons-numbers-combinatorics/src/test/java/org/apache/commons/numbers/combinatorics/CombinationsTest.java
@@ -26,7 +26,7 @@ import org.junit.jupiter.api.Test;
/**
* Tests for the {@link Combinations} class.
*/
-public class CombinationsTest {
+class CombinationsTest {
@Test
void testGetN() {
final int n = 5;
diff --git a/commons-numbers-combinatorics/src/test/java/org/apache/commons/numbers/combinatorics/FactorialDoubleTest.java b/commons-numbers-combinatorics/src/test/java/org/apache/commons/numbers/combinatorics/FactorialDoubleTest.java
index 414ba0d..50be32a 100644
--- a/commons-numbers-combinatorics/src/test/java/org/apache/commons/numbers/combinatorics/FactorialDoubleTest.java
+++ b/commons-numbers-combinatorics/src/test/java/org/apache/commons/numbers/combinatorics/FactorialDoubleTest.java
@@ -22,7 +22,7 @@ import org.junit.jupiter.api.Test;
/**
* Test cases for the {@link FactorialDouble} class.
*/
-public class FactorialDoubleTest {
+class FactorialDoubleTest {
@Test
void testFactorialZero() {
Assertions.assertEquals(1, FactorialDouble.create().value(0), 0d, "0!");
diff --git a/commons-numbers-combinatorics/src/test/java/org/apache/commons/numbers/combinatorics/FactorialTest.java b/commons-numbers-combinatorics/src/test/java/org/apache/commons/numbers/combinatorics/FactorialTest.java
index 1579375..689739d 100644
--- a/commons-numbers-combinatorics/src/test/java/org/apache/commons/numbers/combinatorics/FactorialTest.java
+++ b/commons-numbers-combinatorics/src/test/java/org/apache/commons/numbers/combinatorics/FactorialTest.java
@@ -22,7 +22,7 @@ import org.junit.jupiter.api.Test;
/**
* Test cases for the {@link Factorial} class.
*/
-public class FactorialTest {
+class FactorialTest {
@Test
void testFactorialZero() {
Assertions.assertEquals(1, Factorial.value(0), "0!");
diff --git a/commons-numbers-combinatorics/src/test/java/org/apache/commons/numbers/combinatorics/LogBinomialCoefficientTest.java b/commons-numbers-combinatorics/src/test/java/org/apache/commons/numbers/combinatorics/LogBinomialCoefficientTest.java
index fa36927..0007430 100644
--- a/commons-numbers-combinatorics/src/test/java/org/apache/commons/numbers/combinatorics/LogBinomialCoefficientTest.java
+++ b/commons-numbers-combinatorics/src/test/java/org/apache/commons/numbers/combinatorics/LogBinomialCoefficientTest.java
@@ -22,7 +22,7 @@ import org.junit.jupiter.api.Test;
/**
* Test cases for the {@link LogBinomialCoefficient} class.
*/
-public class LogBinomialCoefficientTest {
+class LogBinomialCoefficientTest {
/** Verify that b(0,0) = 1 */
@Test
void test0Choose0() {
diff --git a/commons-numbers-combinatorics/src/test/java/org/apache/commons/numbers/combinatorics/LogFactorialTest.java b/commons-numbers-combinatorics/src/test/java/org/apache/commons/numbers/combinatorics/LogFactorialTest.java
index e7c84ce..8fd5a4f 100644
--- a/commons-numbers-combinatorics/src/test/java/org/apache/commons/numbers/combinatorics/LogFactorialTest.java
+++ b/commons-numbers-combinatorics/src/test/java/org/apache/commons/numbers/combinatorics/LogFactorialTest.java
@@ -24,7 +24,7 @@ import org.junit.jupiter.api.Test;
/**
* Test cases for the {@link LogFactorial} class.
*/
-public class LogFactorialTest {
+class LogFactorialTest {
@Test
void testNonPositiveArgumentWithCache() {
Assertions.assertThrows(IllegalArgumentException.class,
diff --git a/commons-numbers-complex-streams/src/test/java/org/apache/commons/numbers/complex/streams/ComplexUtilsTest.java b/commons-numbers-complex-streams/src/test/java/org/apache/commons/numbers/complex/streams/ComplexUtilsTest.java
index 7bac2b1..6b1e6a4 100644
--- a/commons-numbers-complex-streams/src/test/java/org/apache/commons/numbers/complex/streams/ComplexUtilsTest.java
+++ b/commons-numbers-complex-streams/src/test/java/org/apache/commons/numbers/complex/streams/ComplexUtilsTest.java
@@ -25,7 +25,7 @@ import org.junit.jupiter.api.Test;
/**
* Tests for {@link ComplexUtils}.
*/
-public class ComplexUtilsTest {
+class ComplexUtilsTest {
private static final double inf = Double.POSITIVE_INFINITY;
private static final double negInf = Double.NEGATIVE_INFINITY;
diff --git a/commons-numbers-complex/src/test/java/org/apache/commons/numbers/complex/CReferenceTest.java b/commons-numbers-complex/src/test/java/org/apache/commons/numbers/complex/CReferenceTest.java
index 322c946..cf72442 100644
--- a/commons-numbers-complex/src/test/java/org/apache/commons/numbers/complex/CReferenceTest.java
+++ b/commons-numbers-complex/src/test/java/org/apache/commons/numbers/complex/CReferenceTest.java
@@ -36,7 +36,7 @@ import java.util.function.UnaryOperator;
* @see <a href="http://www.open-std.org/JTC1/SC22/WG14/www/standards">
* ISO/IEC 9899 - Programming languages - C</a>
*/
-public class CReferenceTest {
+class CReferenceTest {
/** Positive zero bits. */
private static final long POSITIVE_ZERO_DOUBLE_BITS = Double.doubleToRawLongBits(+0.0);
/** Negative zero bits. */
diff --git a/commons-numbers-complex/src/test/java/org/apache/commons/numbers/complex/CStandardTest.java b/commons-numbers-complex/src/test/java/org/apache/commons/numbers/complex/CStandardTest.java
index 09f8489..c4cf9be 100644
--- a/commons-numbers-complex/src/test/java/org/apache/commons/numbers/complex/CStandardTest.java
+++ b/commons-numbers-complex/src/test/java/org/apache/commons/numbers/complex/CStandardTest.java
@@ -37,7 +37,7 @@ import java.util.function.UnaryOperator;
* @see <a href="http://www.open-std.org/JTC1/SC22/WG14/www/standards">
* ISO/IEC 9899 - Programming languages - C</a>
*/
-public class CStandardTest {
+class CStandardTest {
private static final double inf = Double.POSITIVE_INFINITY;
private static final double negInf = Double.NEGATIVE_INFINITY;
diff --git a/commons-numbers-complex/src/test/java/org/apache/commons/numbers/complex/ComplexEdgeCaseTest.java b/commons-numbers-complex/src/test/java/org/apache/commons/numbers/complex/ComplexEdgeCaseTest.java
index 351baa9..95a3952 100644
--- a/commons-numbers-complex/src/test/java/org/apache/commons/numbers/complex/ComplexEdgeCaseTest.java
+++ b/commons-numbers-complex/src/test/java/org/apache/commons/numbers/complex/ComplexEdgeCaseTest.java
@@ -36,7 +36,7 @@ import java.util.function.UnaryOperator;
* @see <a href="http://www.open-std.org/JTC1/SC22/WG14/www/standards">
* ISO/IEC 9899 - Programming languages - C</a>
*/
-public class ComplexEdgeCaseTest {
+class ComplexEdgeCaseTest {
private static final double inf = Double.POSITIVE_INFINITY;
private static final double nan = Double.NaN;
diff --git a/commons-numbers-complex/src/test/java/org/apache/commons/numbers/complex/ComplexTest.java b/commons-numbers-complex/src/test/java/org/apache/commons/numbers/complex/ComplexTest.java
index b0c006e..72e89ae 100644
--- a/commons-numbers-complex/src/test/java/org/apache/commons/numbers/complex/ComplexTest.java
+++ b/commons-numbers-complex/src/test/java/org/apache/commons/numbers/complex/ComplexTest.java
@@ -43,7 +43,7 @@ import org.junit.jupiter.api.Test;
* imaginary parts that can create intermediate overflow or underflow.
* </ul>
*/
-public class ComplexTest {
+class ComplexTest {
private static final double inf = Double.POSITIVE_INFINITY;
private static final double neginf = Double.NEGATIVE_INFINITY;
diff --git a/commons-numbers-core/src/test/java/org/apache/commons/numbers/core/ArithmeticUtilsTest.java b/commons-numbers-core/src/test/java/org/apache/commons/numbers/core/ArithmeticUtilsTest.java
index dc9ef9b..5a4bb73 100644
--- a/commons-numbers-core/src/test/java/org/apache/commons/numbers/core/ArithmeticUtilsTest.java
+++ b/commons-numbers-core/src/test/java/org/apache/commons/numbers/core/ArithmeticUtilsTest.java
@@ -27,7 +27,7 @@ import org.junit.jupiter.api.Test;
* Test cases for the {@link ArithmeticUtils} class.
*
*/
-public class ArithmeticUtilsTest {
+class ArithmeticUtilsTest {
@Test
void testGcd() {
diff --git a/commons-numbers-core/src/test/java/org/apache/commons/numbers/core/PrecisionTest.java b/commons-numbers-core/src/test/java/org/apache/commons/numbers/core/PrecisionTest.java
index 94e8ca4..ef63d75 100644
--- a/commons-numbers-core/src/test/java/org/apache/commons/numbers/core/PrecisionTest.java
+++ b/commons-numbers-core/src/test/java/org/apache/commons/numbers/core/PrecisionTest.java
@@ -25,7 +25,7 @@ import org.junit.jupiter.api.Test;
* Test cases for the {@link Precision} class.
*
*/
-public class PrecisionTest {
+class PrecisionTest {
// Interfaces to allow testing equals variants with the same conditions
diff --git a/commons-numbers-examples/examples-jmh/src/test/java/org/apache/commons/numbers/examples/jmh/arrays/DoublePrecisionTest.java b/commons-numbers-examples/examples-jmh/src/test/java/org/apache/commons/numbers/examples/jmh/arrays/DoublePrecisionTest.java
index d48c5a0..5a24296 100644
--- a/commons-numbers-examples/examples-jmh/src/test/java/org/apache/commons/numbers/examples/jmh/arrays/DoublePrecisionTest.java
+++ b/commons-numbers-examples/examples-jmh/src/test/java/org/apache/commons/numbers/examples/jmh/arrays/DoublePrecisionTest.java
@@ -22,7 +22,7 @@ import org.junit.jupiter.api.Test;
/**
* Tests for {@link DoublePrecision}.
*/
-public class DoublePrecisionTest {
+class DoublePrecisionTest {
@Test
void testSplitAssumptions() {
// The multiplier used to split the double value into high and low parts.
diff --git a/commons-numbers-examples/examples-jmh/src/test/java/org/apache/commons/numbers/examples/jmh/arrays/LinearCombinationAccuracyTest.java b/commons-numbers-examples/examples-jmh/src/test/java/org/apache/commons/numbers/examples/jmh/arrays/LinearCombinationAccuracyTest.java
index befef80..35f45b7 100644
--- a/commons-numbers-examples/examples-jmh/src/test/java/org/apache/commons/numbers/examples/jmh/arrays/LinearCombinationAccuracyTest.java
+++ b/commons-numbers-examples/examples-jmh/src/test/java/org/apache/commons/numbers/examples/jmh/arrays/LinearCombinationAccuracyTest.java
@@ -39,7 +39,7 @@ import java.util.stream.Stream;
/**
* Test the accuracy of each implementation of {@link LinearCombination}.
*/
-public class LinearCombinationAccuracyTest {
+class LinearCombinationAccuracyTest {
/**
* The dot product length.
* This must be the same for the accuracy report as the assertions.
@@ -84,7 +84,7 @@ public class LinearCombinationAccuracyTest {
*/
@ParameterizedTest
@MethodSource("provideLinearCombination")
- public void testDotProduct(ND fun, double passC, double failC) {
+ void testDotProduct(ND fun, double passC, double failC) {
final double[] x = new double[LENGTH];
final double[] y = new double[LENGTH];
// Fixed seed to consistency
@@ -125,7 +125,7 @@ public class LinearCombinationAccuracyTest {
*/
@Test
@Disabled("This method is used to output a report of the accuracy of implementations.")
- public void reportRelativeError() throws IOException {
+ void reportRelativeError() throws IOException {
// Ogita et al (2005) Figure 6.2 used length=100, samples=1000 with c in 1 to 1e120.
// Ogita et al (2005) Figure 6.4 used length=1000, samples=2000 with c in 1 to 1e120.
// Here the condition number is in 1e10 to 1e120 as low condition numbers are
diff --git a/commons-numbers-examples/examples-jmh/src/test/java/org/apache/commons/numbers/examples/jmh/arrays/LinearCombinationsTest.java b/commons-numbers-examples/examples-jmh/src/test/java/org/apache/commons/numbers/examples/jmh/arrays/LinearCombinationsTest.java
index d0bccb3..c77490d 100644
--- a/commons-numbers-examples/examples-jmh/src/test/java/org/apache/commons/numbers/examples/jmh/arrays/LinearCombinationsTest.java
+++ b/commons-numbers-examples/examples-jmh/src/test/java/org/apache/commons/numbers/examples/jmh/arrays/LinearCombinationsTest.java
@@ -38,7 +38,7 @@ import java.util.stream.Stream;
/**
* Test each implementation of the LinearCombination interface.
*/
-public class LinearCombinationsTest {
+class LinearCombinationsTest {
/** Double.MIN_VALUE as a BigDecimal. Use string constructor to truncate precision to 4.9e-324. */
private static final BigDecimal MIN = BigDecimal.valueOf(Double.MIN_VALUE);
@@ -66,7 +66,7 @@ public class LinearCombinationsTest {
@ParameterizedTest
@MethodSource("provideLinearCombination")
- public void testSingleElementArray(ND fun) {
+ void testSingleElementArray(ND fun) {
final double[] a = {1.23456789};
final double[] b = {98765432.1};
@@ -75,7 +75,7 @@ public class LinearCombinationsTest {
@ParameterizedTest
@MethodSource("provideLinearCombination")
- public void testTwoSums(ND fun) {
+ void testTwoSums(ND fun) {
final BigFraction[] aF = new BigFraction[] {
BigFraction.of(-1321008684645961L, 268435456L),
BigFraction.of(-5774608829631843L, 268435456L),
@@ -117,7 +117,7 @@ public class LinearCombinationsTest {
@ParameterizedTest
@MethodSource("provideLinearCombination")
- public void testHuge(ND fun) {
+ void testHuge(ND fun) {
final int scale = 971;
final double[] a = new double[] {
-1321008684645961.0 / 268435456.0,
@@ -152,7 +152,7 @@ public class LinearCombinationsTest {
@ParameterizedTest
@MethodSource("provideLinearCombination")
- public void testArrayVsInline(ND fun) {
+ void testArrayVsInline(ND fun) {
// Assume the instance implements the inline functions
final TwoD fun2 = (TwoD) fun;
final ThreeD fun3 = (ThreeD) fun;
@@ -195,7 +195,7 @@ public class LinearCombinationsTest {
@ParameterizedTest
@MethodSource("provideLinearCombination")
- public void testNonFinite(ND fun) {
+ void testNonFinite(ND fun) {
final double[][] a = new double[][] {
{1, 2, 3, 4},
{1, Double.POSITIVE_INFINITY, 3, 4},
diff --git a/commons-numbers-field/src/test/java/org/apache/commons/numbers/field/FP64Test.java b/commons-numbers-field/src/test/java/org/apache/commons/numbers/field/FP64Test.java
index 6291667..2007765 100644
--- a/commons-numbers-field/src/test/java/org/apache/commons/numbers/field/FP64Test.java
+++ b/commons-numbers-field/src/test/java/org/apache/commons/numbers/field/FP64Test.java
@@ -22,7 +22,7 @@ import org.junit.jupiter.api.Test;
/**
* Tests for {@link FP64}.
*/
-public class FP64Test {
+class FP64Test {
@Test
void testConsistencyWithDouble() {
final double v = -5.67e89;
diff --git a/commons-numbers-field/src/test/java/org/apache/commons/numbers/field/FieldParametricTest.java b/commons-numbers-field/src/test/java/org/apache/commons/numbers/field/FieldParametricTest.java
index fa46bbc..8b09a92 100644
--- a/commons-numbers-field/src/test/java/org/apache/commons/numbers/field/FieldParametricTest.java
+++ b/commons-numbers-field/src/test/java/org/apache/commons/numbers/field/FieldParametricTest.java
@@ -28,7 +28,7 @@ import org.apache.commons.numbers.core.Multiplication;
/**
* Tests for fields.
*/
-public class FieldParametricTest {
+class FieldParametricTest {
private static Stream<FieldTestData<?>> getList() {
return FieldsList.list().stream();
diff --git a/commons-numbers-fraction/src/test/java/org/apache/commons/numbers/fraction/BigFractionTest.java b/commons-numbers-fraction/src/test/java/org/apache/commons/numbers/fraction/BigFractionTest.java
index 81e8774..5ded68e 100644
--- a/commons-numbers-fraction/src/test/java/org/apache/commons/numbers/fraction/BigFractionTest.java
+++ b/commons-numbers-fraction/src/test/java/org/apache/commons/numbers/fraction/BigFractionTest.java
@@ -28,7 +28,7 @@ import org.junit.jupiter.api.Test;
/**
* Tests for {@link BigFraction}.
*/
-public class BigFractionTest {
+class BigFractionTest {
/** The zero representation with positive denominator. */
private static final BigFraction ZERO_P = BigFraction.of(0, 1);
diff --git a/commons-numbers-fraction/src/test/java/org/apache/commons/numbers/fraction/ContinuedFractionTest.java b/commons-numbers-fraction/src/test/java/org/apache/commons/numbers/fraction/ContinuedFractionTest.java
index af2f180..96ab37a 100644
--- a/commons-numbers-fraction/src/test/java/org/apache/commons/numbers/fraction/ContinuedFractionTest.java
+++ b/commons-numbers-fraction/src/test/java/org/apache/commons/numbers/fraction/ContinuedFractionTest.java
@@ -23,7 +23,7 @@ import org.junit.jupiter.api.Test;
/**
* Tests for {@link ContinuedFraction}.
*/
-public class ContinuedFractionTest {
+class ContinuedFractionTest {
@Test
void testGoldenRatio() throws Exception {
diff --git a/commons-numbers-fraction/src/test/java/org/apache/commons/numbers/fraction/FractionTest.java b/commons-numbers-fraction/src/test/java/org/apache/commons/numbers/fraction/FractionTest.java
index f50eee0..1a2a1b6 100644
--- a/commons-numbers-fraction/src/test/java/org/apache/commons/numbers/fraction/FractionTest.java
+++ b/commons-numbers-fraction/src/test/java/org/apache/commons/numbers/fraction/FractionTest.java
@@ -28,7 +28,7 @@ import org.junit.jupiter.api.Test;
/**
* Tests for {@link Fraction}.
*/
-public class FractionTest {
+class FractionTest {
/** The zero representation with positive denominator. */
private static final Fraction ZERO_P = Fraction.of(0, 1);
diff --git a/commons-numbers-gamma/src/test/java/org/apache/commons/numbers/gamma/DigammaTest.java b/commons-numbers-gamma/src/test/java/org/apache/commons/numbers/gamma/DigammaTest.java
index b8431a6..48ecd76 100644
--- a/commons-numbers-gamma/src/test/java/org/apache/commons/numbers/gamma/DigammaTest.java
+++ b/commons-numbers-gamma/src/test/java/org/apache/commons/numbers/gamma/DigammaTest.java
@@ -22,7 +22,7 @@ import org.junit.jupiter.api.Test;
/**
* Tests for {@link Digamma}.
*/
-public class DigammaTest {
+class DigammaTest {
@Test
void testDigammaLargeArgs() {
double eps = 1e-8;
diff --git a/commons-numbers-gamma/src/test/java/org/apache/commons/numbers/gamma/ErfDifferenceTest.java b/commons-numbers-gamma/src/test/java/org/apache/commons/numbers/gamma/ErfDifferenceTest.java
index 881563c..322d6cf 100644
--- a/commons-numbers-gamma/src/test/java/org/apache/commons/numbers/gamma/ErfDifferenceTest.java
+++ b/commons-numbers-gamma/src/test/java/org/apache/commons/numbers/gamma/ErfDifferenceTest.java
@@ -22,7 +22,7 @@ import org.junit.jupiter.api.Test;
/**
* Tests for {@link ErfDifference}.
*/
-public class ErfDifferenceTest {
+class ErfDifferenceTest {
/**
* Test the implementation of ErfDifference.value(double, double) for consistency
* with results obtained from Erf.value(double) and Erfc.value(double).
diff --git a/commons-numbers-gamma/src/test/java/org/apache/commons/numbers/gamma/ErfTest.java b/commons-numbers-gamma/src/test/java/org/apache/commons/numbers/gamma/ErfTest.java
index f9b3f62..2869955 100644
--- a/commons-numbers-gamma/src/test/java/org/apache/commons/numbers/gamma/ErfTest.java
+++ b/commons-numbers-gamma/src/test/java/org/apache/commons/numbers/gamma/ErfTest.java
@@ -22,7 +22,7 @@ import org.junit.jupiter.api.Test;
/**
* Tests for {@link Erf}.
*/
-public class ErfTest {
+class ErfTest {
@Test
void testErf0() {
double actual = Erf.value(0);
diff --git a/commons-numbers-gamma/src/test/java/org/apache/commons/numbers/gamma/ErfcTest.java b/commons-numbers-gamma/src/test/java/org/apache/commons/numbers/gamma/ErfcTest.java
index 99f2845..81be557 100644
--- a/commons-numbers-gamma/src/test/java/org/apache/commons/numbers/gamma/ErfcTest.java
+++ b/commons-numbers-gamma/src/test/java/org/apache/commons/numbers/gamma/ErfcTest.java
@@ -22,7 +22,7 @@ import org.junit.jupiter.api.Test;
/**
* Tests for {@link Erfc}.
*/
-public class ErfcTest {
+class ErfcTest {
/**
* Compare erfc against reference values computed using GCC 4.2.1
* (Apple OSX packaged version) erfcl (extended precision erfc).
diff --git a/commons-numbers-gamma/src/test/java/org/apache/commons/numbers/gamma/GammaTest.java b/commons-numbers-gamma/src/test/java/org/apache/commons/numbers/gamma/GammaTest.java
index 1c19785..3da8b6e 100644
--- a/commons-numbers-gamma/src/test/java/org/apache/commons/numbers/gamma/GammaTest.java
+++ b/commons-numbers-gamma/src/test/java/org/apache/commons/numbers/gamma/GammaTest.java
@@ -22,7 +22,7 @@ import org.junit.jupiter.api.Test;
/**
* Tests for {@link Gamma}.
*/
-public class GammaTest {
+class GammaTest {
/**
* Reference data for the {@link Gamma#value(double)} function. This
* data was generated with the following <a
diff --git a/commons-numbers-gamma/src/test/java/org/apache/commons/numbers/gamma/InvGamma1pm1Test.java b/commons-numbers-gamma/src/test/java/org/apache/commons/numbers/gamma/InvGamma1pm1Test.java
index 07f8087..868202c 100644
--- a/commons-numbers-gamma/src/test/java/org/apache/commons/numbers/gamma/InvGamma1pm1Test.java
+++ b/commons-numbers-gamma/src/test/java/org/apache/commons/numbers/gamma/InvGamma1pm1Test.java
@@ -22,7 +22,7 @@ import org.junit.jupiter.api.Test;
/**
* Tests for {@link InvGamma1pm1}.
*/
-public class InvGamma1pm1Test {
+class InvGamma1pm1Test {
/**
* <p>
* Reference values for the {@link InvGamma1pm1#value(double)} method.
diff --git a/commons-numbers-gamma/src/test/java/org/apache/commons/numbers/gamma/InverseErfTest.java b/commons-numbers-gamma/src/test/java/org/apache/commons/numbers/gamma/InverseErfTest.java
index f19837e..33830e1 100644
--- a/commons-numbers-gamma/src/test/java/org/apache/commons/numbers/gamma/InverseErfTest.java
+++ b/commons-numbers-gamma/src/test/java/org/apache/commons/numbers/gamma/InverseErfTest.java
@@ -22,7 +22,7 @@ import org.junit.jupiter.api.Test;
/**
* Tests for {@link InverseErf}.
*/
-public class InverseErfTest {
+class InverseErfTest {
@Test
void testErfInvNaN() {
Assertions.assertTrue(Double.isNaN(InverseErf.value(-1.001)));
diff --git a/commons-numbers-gamma/src/test/java/org/apache/commons/numbers/gamma/InverseErfcTest.java b/commons-numbers-gamma/src/test/java/org/apache/commons/numbers/gamma/InverseErfcTest.java
index dd9d015..a2927e8 100644
--- a/commons-numbers-gamma/src/test/java/org/apache/commons/numbers/gamma/InverseErfcTest.java
+++ b/commons-numbers-gamma/src/test/java/org/apache/commons/numbers/gamma/InverseErfcTest.java
@@ -22,7 +22,7 @@ import org.junit.jupiter.api.Test;
/**
* Tests for {@link InverseErfc}.
*/
-public class InverseErfcTest {
+class InverseErfcTest {
@Test
void testErfcInvNaN() {
Assertions.assertTrue(Double.isNaN(InverseErfc.value(-0.001)));
diff --git a/commons-numbers-gamma/src/test/java/org/apache/commons/numbers/gamma/LanczosApproximationTest.java b/commons-numbers-gamma/src/test/java/org/apache/commons/numbers/gamma/LanczosApproximationTest.java
index d562909..4782497 100644
--- a/commons-numbers-gamma/src/test/java/org/apache/commons/numbers/gamma/LanczosApproximationTest.java
+++ b/commons-numbers-gamma/src/test/java/org/apache/commons/numbers/gamma/LanczosApproximationTest.java
@@ -22,7 +22,7 @@ import org.junit.jupiter.api.Test;
/**
* Tests for {@link LanczosApproximation}.
*/
-public class LanczosApproximationTest {
+class LanczosApproximationTest {
@Test
void testG() {
Assertions.assertEquals(607d / 128d, LanczosApproximation.g(), 0d);
diff --git a/commons-numbers-gamma/src/test/java/org/apache/commons/numbers/gamma/LogBetaTest.java b/commons-numbers-gamma/src/test/java/org/apache/commons/numbers/gamma/LogBetaTest.java
index 9e6a68b..114d055 100644
--- a/commons-numbers-gamma/src/test/java/org/apache/commons/numbers/gamma/LogBetaTest.java
+++ b/commons-numbers-gamma/src/test/java/org/apache/commons/numbers/gamma/LogBetaTest.java
@@ -25,7 +25,7 @@ import org.junit.jupiter.api.Test;
/**
* Tests for {@link LogBeta}.
*/
-public class LogBetaTest {
+class LogBetaTest {
private static final double[][] LOG_BETA_REF = {
{0.125, 0.125, 2.750814190409515},
{0.125, 0.25, 2.444366899981226},
diff --git a/commons-numbers-gamma/src/test/java/org/apache/commons/numbers/gamma/LogGamma1pTest.java b/commons-numbers-gamma/src/test/java/org/apache/commons/numbers/gamma/LogGamma1pTest.java
index c1ea8f6..9cf1b29 100644
--- a/commons-numbers-gamma/src/test/java/org/apache/commons/numbers/gamma/LogGamma1pTest.java
+++ b/commons-numbers-gamma/src/test/java/org/apache/commons/numbers/gamma/LogGamma1pTest.java
@@ -22,7 +22,7 @@ import org.junit.jupiter.api.Test;
/**
* Tests for {@link LogGamma1p}.
*/
-public class LogGamma1pTest {
+class LogGamma1pTest {
private static final double[][] LOG_GAMMA1P_REF = {
{-0.5, .5723649429247001},
{-0.375, .3608294954889402},
diff --git a/commons-numbers-gamma/src/test/java/org/apache/commons/numbers/gamma/LogGammaSumTest.java b/commons-numbers-gamma/src/test/java/org/apache/commons/numbers/gamma/LogGammaSumTest.java
index a54b6cc..e21a70d 100644
--- a/commons-numbers-gamma/src/test/java/org/apache/commons/numbers/gamma/LogGammaSumTest.java
+++ b/commons-numbers-gamma/src/test/java/org/apache/commons/numbers/gamma/LogGammaSumTest.java
@@ -22,7 +22,7 @@ import org.junit.jupiter.api.Test;
/**
* Tests for {@link LogGammaSum}.
*/
-public class LogGammaSumTest {
+class LogGammaSumTest {
/**
* Reference data for the {@link LogGammaSum#value(double, double)}
* function. This data was generated with the following
diff --git a/commons-numbers-gamma/src/test/java/org/apache/commons/numbers/gamma/LogGammaTest.java b/commons-numbers-gamma/src/test/java/org/apache/commons/numbers/gamma/LogGammaTest.java
index 4cbc033..3f18410 100644
--- a/commons-numbers-gamma/src/test/java/org/apache/commons/numbers/gamma/LogGammaTest.java
+++ b/commons-numbers-gamma/src/test/java/org/apache/commons/numbers/gamma/LogGammaTest.java
@@ -22,7 +22,7 @@ import org.junit.jupiter.api.Test;
/**
* Tests for {@link LogGamma}.
*/
-public class LogGammaTest {
+class LogGammaTest {
/**
* Reference data for the {@link Gamma#logGamma(double)} function. This data
* was generated with the following <a
diff --git a/commons-numbers-gamma/src/test/java/org/apache/commons/numbers/gamma/RegularizedBetaTest.java b/commons-numbers-gamma/src/test/java/org/apache/commons/numbers/gamma/RegularizedBetaTest.java
index 32f0e03..1fc6304 100644
--- a/commons-numbers-gamma/src/test/java/org/apache/commons/numbers/gamma/RegularizedBetaTest.java
+++ b/commons-numbers-gamma/src/test/java/org/apache/commons/numbers/gamma/RegularizedBetaTest.java
@@ -22,7 +22,7 @@ import org.junit.jupiter.api.Test;
/**
* Tests for {@link RegularizedBeta}.
*/
-public class RegularizedBetaTest {
+class RegularizedBetaTest {
@Test
void testRegularizedBetaNanPositivePositive() {
testRegularizedBeta(Double.NaN, Double.NaN, 1.0, 1.0);
diff --git a/commons-numbers-gamma/src/test/java/org/apache/commons/numbers/gamma/RegularizedGammaTest.java b/commons-numbers-gamma/src/test/java/org/apache/commons/numbers/gamma/RegularizedGammaTest.java
index 5557e50..e461a1a 100644
--- a/commons-numbers-gamma/src/test/java/org/apache/commons/numbers/gamma/RegularizedGammaTest.java
+++ b/commons-numbers-gamma/src/test/java/org/apache/commons/numbers/gamma/RegularizedGammaTest.java
@@ -22,7 +22,7 @@ import org.junit.jupiter.api.Test;
/**
* Tests for {@link RegularizedGamma}.
*/
-public class RegularizedGammaTest {
+class RegularizedGammaTest {
@Test
void testRegularizedGammaNanPositive() {
testRegularizedGamma(Double.NaN, Double.NaN, 1.0);
diff --git a/commons-numbers-gamma/src/test/java/org/apache/commons/numbers/gamma/TrigammaTest.java b/commons-numbers-gamma/src/test/java/org/apache/commons/numbers/gamma/TrigammaTest.java
index a865c92..eb481a5 100644
--- a/commons-numbers-gamma/src/test/java/org/apache/commons/numbers/gamma/TrigammaTest.java
+++ b/commons-numbers-gamma/src/test/java/org/apache/commons/numbers/gamma/TrigammaTest.java
@@ -22,7 +22,7 @@ import org.junit.jupiter.api.Test;
/**
* Tests for {@link Trigamma}.
*/
-public class TrigammaTest {
+class TrigammaTest {
@Test
void testTrigamma() {
double eps = 1e-8;
diff --git a/commons-numbers-primes/src/test/java/org/apache/commons/numbers/primes/PrimesTest.java b/commons-numbers-primes/src/test/java/org/apache/commons/numbers/primes/PrimesTest.java
index e7242c8..9c2807f 100644
--- a/commons-numbers-primes/src/test/java/org/apache/commons/numbers/primes/PrimesTest.java
+++ b/commons-numbers-primes/src/test/java/org/apache/commons/numbers/primes/PrimesTest.java
@@ -24,7 +24,7 @@ import java.util.List;
import org.junit.jupiter.api.Assertions;
import org.junit.jupiter.api.Test;
-public class PrimesTest {
+class PrimesTest {
static final int[] PRIMES = {
//primes here have been verified one by one using Dario Alejandro Alpern's tool.
diff --git a/commons-numbers-primes/src/test/java/org/apache/commons/numbers/primes/SmallPrimesTest.java b/commons-numbers-primes/src/test/java/org/apache/commons/numbers/primes/SmallPrimesTest.java
index 4f3dd5f..8ba4e7a 100644
--- a/commons-numbers-primes/src/test/java/org/apache/commons/numbers/primes/SmallPrimesTest.java
+++ b/commons-numbers-primes/src/test/java/org/apache/commons/numbers/primes/SmallPrimesTest.java
@@ -24,7 +24,7 @@ import java.util.List;
import org.junit.jupiter.api.Assertions;
import org.junit.jupiter.api.Test;
-public class SmallPrimesTest {
+class SmallPrimesTest {
// Primes larger than the small PRIMES array in SmallPrimes
private static final int[] LARGE_PRIME = {3673, 3677};
diff --git a/commons-numbers-quaternion/src/test/java/org/apache/commons/numbers/quaternion/QuaternionTest.java b/commons-numbers-quaternion/src/test/java/org/apache/commons/numbers/quaternion/QuaternionTest.java
index e3022ce..eec4e22 100644
--- a/commons-numbers-quaternion/src/test/java/org/apache/commons/numbers/quaternion/QuaternionTest.java
+++ b/commons-numbers-quaternion/src/test/java/org/apache/commons/numbers/quaternion/QuaternionTest.java
@@ -21,7 +21,7 @@ import java.util.Random;
import org.junit.jupiter.api.Assertions;
import org.junit.jupiter.api.Test;
-public class QuaternionTest {
+class QuaternionTest {
/** Epsilon for double comparison. */
private static final double EPS = Math.ulp(1d);
/** Epsilon for double comparison. */
diff --git a/commons-numbers-quaternion/src/test/java/org/apache/commons/numbers/quaternion/SlerpTest.java b/commons-numbers-quaternion/src/test/java/org/apache/commons/numbers/quaternion/SlerpTest.java
index bcdbcbe..37f34c7 100644
--- a/commons-numbers-quaternion/src/test/java/org/apache/commons/numbers/quaternion/SlerpTest.java
+++ b/commons-numbers-quaternion/src/test/java/org/apache/commons/numbers/quaternion/SlerpTest.java
@@ -21,7 +21,7 @@ import org.apache.commons.numbers.core.Precision;
import org.junit.jupiter.api.Assertions;
import org.junit.jupiter.api.Test;
-public class SlerpTest {
+class SlerpTest {
private static final double EPS = 1e-7;
diff --git a/commons-numbers-rootfinder/src/test/java/org/apache/commons/numbers/rootfinder/BrentSolverTest.java b/commons-numbers-rootfinder/src/test/java/org/apache/commons/numbers/rootfinder/BrentSolverTest.java
index 40cf641..abe6bb2 100644
--- a/commons-numbers-rootfinder/src/test/java/org/apache/commons/numbers/rootfinder/BrentSolverTest.java
+++ b/commons-numbers-rootfinder/src/test/java/org/apache/commons/numbers/rootfinder/BrentSolverTest.java
@@ -24,7 +24,7 @@ import org.junit.jupiter.api.Test;
/**
* Test cases for the {@link BrentSolver} class.
*/
-public class BrentSolverTest {
+class BrentSolverTest {
private static final double DEFAULT_ABSOLUTE_ACCURACY = 1e-6;
private static final double DEFAULT_RELATIVE_ACCURACY = 1e-14;
private static final double DEFAULT_FUNCTION_ACCURACY = 1e-15;
[commons-numbers] 02/03: Remove commented out code.
Posted by ah...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
aherbert pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-numbers.git
commit 2080a7be7e3f7b9a9f648b3061efe0d36f2be792
Author: aherbert <ah...@apache.org>
AuthorDate: Tue Jun 30 14:14:05 2020 +0100
Remove commented out code.
The block:
if (isPrime(n)) return n;
is already executed with the same value n in lines above.
---
.../src/main/java/org/apache/commons/numbers/primes/Primes.java | 1 -
1 file changed, 1 deletion(-)
diff --git a/commons-numbers-primes/src/main/java/org/apache/commons/numbers/primes/Primes.java b/commons-numbers-primes/src/main/java/org/apache/commons/numbers/primes/Primes.java
index 5c3ad73..b135f4b 100644
--- a/commons-numbers-primes/src/main/java/org/apache/commons/numbers/primes/Primes.java
+++ b/commons-numbers-primes/src/main/java/org/apache/commons/numbers/primes/Primes.java
@@ -88,7 +88,6 @@ public final class Primes {
if (0 == rem) { // if n % 3 == 0
n += 2; // n % 3 == 2
} else if (1 == rem) { // if n % 3 == 1
- // if (isPrime(n)) return n;
n += 4; // n % 3 == 2
}
while (true) { // this loop skips all multiple of 3
[commons-numbers] 03/03: Remove extra if statement.
Posted by ah...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
aherbert pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-numbers.git
commit 6b0e82ae718dc17ab163b3949ba9f2d821a42d9d
Author: aherbert <ah...@apache.org>
AuthorDate: Tue Jun 30 14:15:39 2020 +0100
Remove extra if statement.
---
.../src/main/java/org/apache/commons/numbers/primes/Primes.java | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/commons-numbers-primes/src/main/java/org/apache/commons/numbers/primes/Primes.java b/commons-numbers-primes/src/main/java/org/apache/commons/numbers/primes/Primes.java
index b135f4b..860678d 100644
--- a/commons-numbers-primes/src/main/java/org/apache/commons/numbers/primes/Primes.java
+++ b/commons-numbers-primes/src/main/java/org/apache/commons/numbers/primes/Primes.java
@@ -70,13 +70,10 @@ public final class Primes {
if (n < 0) {
throw new IllegalArgumentException(MessageFormat.format(NUMBER_TOO_SMALL, n, 0));
}
- if (n == 2) {
+ if (n <= 2) {
return 2;
}
n |= 1; // make sure n is odd
- if (n == 1) {
- return 2;
- }
if (isPrime(n)) {
return n;