You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by "songxiaosheng (via GitHub)" <gi...@apache.org> on 2023/09/01 11:00:46 UTC

[GitHub] [shardingsphere-elasticjob] songxiaosheng opened a new pull request, #2251: remove offline server ip

songxiaosheng opened a new pull request, #2251:
URL: https://github.com/apache/shardingsphere-elasticjob/pull/2251

   Fixes #ISSUSE_ID.
   fix #2239
   fix #2229
   Changes proposed in this pull request:
   support remove offline serverIp logic
   -
   -
   -
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [shardingsphere-elasticjob] TeslaCN commented on pull request #2251: remove offline server ip

Posted by "TeslaCN (via GitHub)" <gi...@apache.org>.
TeslaCN commented on PR #2251:
URL: https://github.com/apache/shardingsphere-elasticjob/pull/2251#issuecomment-1702951988

   Could we add an option for this? Sometimes we may set server disable in non-container environment.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [shardingsphere-elasticjob] codecov-commenter commented on pull request #2251: remove offline server ip

Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #2251:
URL: https://github.com/apache/shardingsphere-elasticjob/pull/2251#issuecomment-1704026657

   ## [Codecov](https://app.codecov.io/gh/apache/shardingsphere-elasticjob/pull/2251?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   > Merging [#2251](https://app.codecov.io/gh/apache/shardingsphere-elasticjob/pull/2251?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (8f557e9) into [master](https://app.codecov.io/gh/apache/shardingsphere-elasticjob/commit/9afe466837e9e0751a8cd3898bca80d60548f0d1?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (9afe466) will **decrease** coverage by `0.17%`.
   > The diff coverage is `43.47%`.
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #2251      +/-   ##
   ============================================
   - Coverage     84.69%   84.52%   -0.17%     
   - Complexity     1927     1931       +4     
   ============================================
     Files           287      287              
     Lines          6317     6340      +23     
     Branches        700      704       +4     
   ============================================
   + Hits           5350     5359       +9     
   - Misses          646      658      +12     
   - Partials        321      323       +2     
   ```
   
   
   | [Files Changed](https://app.codecov.io/gh/apache/shardingsphere-elasticjob/pull/2251?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [...elasticjob/lite/internal/server/ServerService.java](https://app.codecov.io/gh/apache/shardingsphere-elasticjob/pull/2251?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-ZWxhc3RpY2pvYi1saXRlL2VsYXN0aWNqb2ItbGl0ZS1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9lbGFzdGljam9iL2xpdGUvaW50ZXJuYWwvc2VydmVyL1NlcnZlclNlcnZpY2UuamF2YQ==) | `72.34% <40.90%> (-27.66%)` | :arrow_down: |
   | [...re/elasticjob/lite/internal/setup/SetUpFacade.java](https://app.codecov.io/gh/apache/shardingsphere-elasticjob/pull/2251?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-ZWxhc3RpY2pvYi1saXRlL2VsYXN0aWNqb2ItbGl0ZS1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9lbGFzdGljam9iL2xpdGUvaW50ZXJuYWwvc2V0dXAvU2V0VXBGYWNhZGUuamF2YQ==) | `95.45% <100.00%> (+0.21%)` | :arrow_up: |
   
   ... and [3 files with indirect coverage changes](https://app.codecov.io/gh/apache/shardingsphere-elasticjob/pull/2251/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   
   :mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [shardingsphere-elasticjob] TeslaCN merged pull request #2251: remove offline server ip

Posted by "TeslaCN (via GitHub)" <gi...@apache.org>.
TeslaCN merged PR #2251:
URL: https://github.com/apache/shardingsphere-elasticjob/pull/2251


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [shardingsphere-elasticjob] songxiaosheng commented on pull request #2251: remove offline server ip

Posted by "songxiaosheng (via GitHub)" <gi...@apache.org>.
songxiaosheng commented on PR #2251:
URL: https://github.com/apache/shardingsphere-elasticjob/pull/2251#issuecomment-1703696596

   > Could we add an option for this? Sometimes we may set server disable in non-container environment.
   
   This is compatible, no stateful nodes are removed, and the existing state does not remove the recommended hosting state.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [shardingsphere-elasticjob] songxiaosheng commented on pull request #2251: remove offline server ip

Posted by "songxiaosheng (via GitHub)" <gi...@apache.org>.
songxiaosheng commented on PR #2251:
URL: https://github.com/apache/shardingsphere-elasticjob/pull/2251#issuecomment-1702917705

   @TeslaCN  PATL


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org