You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@sqoop.apache.org by Jarek Cecho <ja...@apache.org> on 2013/08/25 00:55:42 UTC

Review Request 13795: SQOOP-1184 Sqoop2: Improve error messages during metadata upgrade

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13795/
-----------------------------------------------------------

Review request for Sqoop.


Bugs: SQOOP-1184
    https://issues.apache.org/jira/browse/SQOOP-1184


Repository: sqoop-sqoop2


Description
-------

I've added code that will iterate over the Validation object and log all validation errors and warnings. I've also removed the Lists of invalid objects to improve the memory footprint of the upgrade procedure.


Diffs
-----

  core/src/main/java/org/apache/sqoop/repository/Repository.java a7ccf10d948ae75e3ed2f5c1c19d1fec2d205aae 

Diff: https://reviews.apache.org/r/13795/diff/


Testing
-------

Metadata upgrade is currently not covered by automatic tests, so this patch do not include them. Nevertheless I've verified the logging on a real cluster. We should add unit tests in separate JIRA.


Thanks,

Jarek Cecho