Re: [PR] Adds whitelist for custom serializer of classes in pekko package [incubator-pekko]

["Roiocam (via GitHub)" <gi...@apache.org>]

Roiocam commented on code in PR #94:
URL: https://github.com/apache/incubator-pekko/pull/94#discussion_r1365752172


##########
actor/src/main/scala/org/apache/pekko/serialization/Serialization.scala:
##########
@@ -466,8 +462,12 @@ class Serialization(val system: ExtendedActorSystem) extends Extension {
     }
   }
 
+  @nowarn("msg=deprecated")
   private def warnUnexpectedNonPekkoSerializer(clazz: Class[_], ser: Serializer): Boolean = {
-    if (clazz.getName.startsWith("org.apache.pekko.") && !ser.getClass.getName.startsWith("org.apache.pekko.")) {

Review Comment:
   I don't think it is good idea to turn off these warnning, if have to, better using same way like `shouldWarnAboutJavaSerializer` rather than using a list struct.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org