You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@seatunnel.apache.org by GitBox <gi...@apache.org> on 2022/07/10 13:32:48 UTC
[GitHub] [incubator-seatunnel] CalvinKirs opened a new pull request, #2155: Update new-license.md
CalvinKirs opened a new pull request, #2155:
URL: https://github.com/apache/incubator-seatunnel/pull/2155
<!--
Thank you for contributing to SeaTunnel! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
## Contribution Checklist
- Make sure that the pull request corresponds to a [GITHUB issue](https://github.com/apache/incubator-seatunnel/issues).
- Name the pull request in the form "[Feature] [component] Title of the pull request", where *Feature* can be replaced by `Hotfix`, `Bug`, etc.
- Minor fixes should be named following this pattern: `[hotfix] [docs] Fix typo in README.md doc`.
-->
## Purpose of this pull request
<!-- Describe the purpose of this pull request. For example: This pull request adds checkstyle plugin.-->
## Check list
* [ ] Code changed are covered with tests, or it does not need tests for reason:
* [ ] If any new Jar binary package adding in your PR, please add License Notice according
[New License Guide](https://github.com/apache/incubator-seatunnel/blob/dev/docs/en/contribution/new-license.md)
* [ ] If necessary, please update the documentation to describe the new feature. https://github.com/apache/incubator-seatunnel/tree/dev/docs
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] CalvinKirs merged pull request #2155: Update new-license.md
Posted by GitBox <gi...@apache.org>.
CalvinKirs merged PR #2155:
URL: https://github.com/apache/incubator-seatunnel/pull/2155
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] CalvinKirs closed pull request #2155: Update new-license.md
Posted by GitBox <gi...@apache.org>.
CalvinKirs closed pull request #2155: Update new-license.md
URL: https://github.com/apache/incubator-seatunnel/pull/2155
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] kezhenxu94 commented on a diff in pull request #2155: Update new-license.md
Posted by GitBox <gi...@apache.org>.
kezhenxu94 commented on code in PR #2155:
URL: https://github.com/apache/incubator-seatunnel/pull/2155#discussion_r917399128
##########
docs/en/contribution/new-license.md:
##########
@@ -1,25 +1,37 @@
# How To Add New License
-If you have any new Jar binary package adding in you PR, you need to follow the steps below to notice license
+### ASF 3RD PARTY LICENSE POLICY
-1. declared in `tools/dependencies/known-dependencies.txt`
+You have to pay attention to the following open-source software protocols which Apache projects support when you intend to add a new feature to the SeaTunnel (or other Apache projects), which functions refers to other open-source software references.
-2. Add the corresponding License file under `seatunnel-dist/release-docs/licenses`, if it is a standard Apache License, it does not need to be added
+[ASF 3RD PARTY LICENSE POLICY](https://apache.org/legal/resolved.html)
-3. Add the corresponding statement in `seatunnel-dist/release-docs/LICENSE`
+If the 3rd party software is not present at the above policy, we could't that accept your code.
- ```bash
- # At the same time, you can also use the script to assist the inspection.
- # Because it only uses the Python native APIs and does not depend on any third-party libraries, it can run using the original Python environment.
- # Please refer to the documentation if you do not have a Python env: https://www.python.org/downloads/
-
- # First, generate the seatunnel-dist/target/THIRD-PARTY.txt temporary file
- ./mvnw license:aggregate-add-third-party -DskipTests -Dcheckstyle.skip
- # Second, run the script to assist the inspection
- python3 tools/dependencies/license.py seatunnel-dist/target/THIRD-PARTY.txt seatunnel-dist/release-docs/LICENSE true
- ```
-4. Add the corresponding statement in `seatunnel-dist/release-docs/NOTICE`
+### How to Legally Use 3rd Party Open-source Software in the SeaTunnel
-If you want to learn more about strategy of License, you could read
-[License Notice](https://seatunnel.apache.org/community/submit_guide/license) in submit guide.
+Moreover, when we intend to refer a new software ( not limited to 3rd party jar, text, CSS, js, pics, icons, audios etc and modifications based on 3rd party files) to our project, we need to use them legally in addition to the permission of ASF. Refer to the following article:
+
+* [COMMUNITY-LED DEVELOPMENT "THE APACHE WAY"](https://apache.org/dev/licensing-howto.html)
+
+
+For example, we should contain the NOTICE file (every open-source project has NOTICE file, generally under root directory) of ZooKeeper in our project when we are using ZooKeeper. As the Apache explains, "Work" shall mean the work of authorship, whether in Source or Object form, made available under the License, as indicated by a copyright notice that is included in or attached to the work.
Review Comment:
😂 I think not every open source project has a notice file. Many non-Apache projects have no such file actually.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] CalvinKirs commented on a diff in pull request #2155: Update new-license.md
Posted by GitBox <gi...@apache.org>.
CalvinKirs commented on code in PR #2155:
URL: https://github.com/apache/incubator-seatunnel/pull/2155#discussion_r917400285
##########
docs/en/contribution/new-license.md:
##########
@@ -1,25 +1,37 @@
# How To Add New License
-If you have any new Jar binary package adding in you PR, you need to follow the steps below to notice license
+### ASF 3RD PARTY LICENSE POLICY
-1. declared in `tools/dependencies/known-dependencies.txt`
+You have to pay attention to the following open-source software protocols which Apache projects support when you intend to add a new feature to the SeaTunnel (or other Apache projects), which functions refers to other open-source software references.
-2. Add the corresponding License file under `seatunnel-dist/release-docs/licenses`, if it is a standard Apache License, it does not need to be added
+[ASF 3RD PARTY LICENSE POLICY](https://apache.org/legal/resolved.html)
-3. Add the corresponding statement in `seatunnel-dist/release-docs/LICENSE`
+If the 3rd party software is not present at the above policy, we could't that accept your code.
- ```bash
- # At the same time, you can also use the script to assist the inspection.
- # Because it only uses the Python native APIs and does not depend on any third-party libraries, it can run using the original Python environment.
- # Please refer to the documentation if you do not have a Python env: https://www.python.org/downloads/
-
- # First, generate the seatunnel-dist/target/THIRD-PARTY.txt temporary file
- ./mvnw license:aggregate-add-third-party -DskipTests -Dcheckstyle.skip
- # Second, run the script to assist the inspection
- python3 tools/dependencies/license.py seatunnel-dist/target/THIRD-PARTY.txt seatunnel-dist/release-docs/LICENSE true
- ```
-4. Add the corresponding statement in `seatunnel-dist/release-docs/NOTICE`
+### How to Legally Use 3rd Party Open-source Software in the SeaTunnel
-If you want to learn more about strategy of License, you could read
-[License Notice](https://seatunnel.apache.org/community/submit_guide/license) in submit guide.
+Moreover, when we intend to refer a new software ( not limited to 3rd party jar, text, CSS, js, pics, icons, audios etc and modifications based on 3rd party files) to our project, we need to use them legally in addition to the permission of ASF. Refer to the following article:
+
+* [COMMUNITY-LED DEVELOPMENT "THE APACHE WAY"](https://apache.org/dev/licensing-howto.html)
+
+
+For example, we should contain the NOTICE file (every open-source project has NOTICE file, generally under root directory) of ZooKeeper in our project when we are using ZooKeeper. As the Apache explains, "Work" shall mean the work of authorship, whether in Source or Object form, made available under the License, as indicated by a copyright notice that is included in or attached to the work.
Review Comment:
my mistake thanks for your reminder
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org