You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by chengxiang li <ch...@intel.com> on 2014/08/22 11:46:04 UTC
Review Request 24972: HIVE-7799 TRANSFORM failed in transform_ppr1.q
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24972/
-----------------------------------------------------------
Review request for hive, Brock Noland and Szehon Ho.
Bugs: HIVE-7799
https://issues.apache.org/jira/browse/HIVE-7799
Repository: hive-git
Description
-------
HiveBaseFunctionResultList use RowContainer to store collected map output row, all rows should be added into RowContainer then start read from it, RowContainer does not support write after read.
Diffs
-----
ql/src/java/org/apache/hadoop/hive/ql/exec/spark/HiveBaseFunctionResultList.java 6568a76
Diff: https://reviews.apache.org/r/24972/diff/
Testing
-------
Thanks,
chengxiang li
Re: Review Request 24972: HIVE-7799 TRANSFORM failed in
transform_ppr1.q
Posted by Brock Noland <br...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24972/#review51336
-----------------------------------------------------------
Perhaps we should use this? https://github.com/apache/flume/blob/trunk/flume-ng-channels/flume-file-channel/src/main/java/org/apache/flume/channel/file/FlumeEventQueue.java#L102
- Brock Noland
On Aug. 22, 2014, 9:47 a.m., chengxiang li wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24972/
> -----------------------------------------------------------
>
> (Updated Aug. 22, 2014, 9:47 a.m.)
>
>
> Review request for hive, Brock Noland and Szehon Ho.
>
>
> Bugs: HIVE-7799
> https://issues.apache.org/jira/browse/HIVE-7799
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> HiveBaseFunctionResultList use RowContainer to store collected map output row, all rows should be added into RowContainer then start read from it, RowContainer does not support write after read.
>
>
> Diffs
> -----
>
> ql/src/java/org/apache/hadoop/hive/ql/exec/spark/HiveBaseFunctionResultList.java 6568a76
>
> Diff: https://reviews.apache.org/r/24972/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> chengxiang li
>
>
Re: Review Request 24972: HIVE-7799 TRANSFORM failed in
transform_ppr1.q
Posted by chengxiang li <ch...@intel.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24972/
-----------------------------------------------------------
(Updated 八月 22, 2014, 9:47 a.m.)
Review request for hive, Brock Noland and Szehon Ho.
Changes
-------
we do not need RowContainer here for persistent storage support, as ResultIterator just process new record on demand, a queue should just work fine.
Bugs: HIVE-7799
https://issues.apache.org/jira/browse/HIVE-7799
Repository: hive-git
Description
-------
HiveBaseFunctionResultList use RowContainer to store collected map output row, all rows should be added into RowContainer then start read from it, RowContainer does not support write after read.
Diffs (updated)
-----
ql/src/java/org/apache/hadoop/hive/ql/exec/spark/HiveBaseFunctionResultList.java 6568a76
Diff: https://reviews.apache.org/r/24972/diff/
Testing
-------
Thanks,
chengxiang li