You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@rocketmq.apache.org by "fuyou001 (via GitHub)" <gi...@apache.org> on 2023/04/28 03:28:43 UTC

[GitHub] [rocketmq] fuyou001 commented on a diff in pull request #6663: [ISSUE #6662] Optimize the process of HA's confirmOffset calculation

fuyou001 commented on code in PR #6663:
URL: https://github.com/apache/rocketmq/pull/6663#discussion_r1179894252


##########
store/src/main/java/org/apache/rocketmq/store/ha/autoswitch/AutoSwitchHAService.java:
##########
@@ -432,7 +434,7 @@ private long computeConfirmOffset() {
         long confirmOffset = this.defaultMessageStore.getMaxPhyOffset();

Review Comment:
   refactor confirmOffset to newConfirmOffset



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org