You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2020/08/15 00:44:14 UTC
[GitHub] [incubator-mxnet] access2rohit opened a new pull request #18930: [WIP]Support for fp16 in SpM x DnsM
access2rohit opened a new pull request #18930:
URL: https://github.com/apache/incubator-mxnet/pull/18930
## Description ##
enables fp16 DType suport in following case
```
dot(csr, dense1) = dense2 and dot(csr.T, dense1) = dense2
```
## Checklist ##
### Essentials ###
Please feel free to remove inapplicable items for your PR.
- [x] Changes are complete (i.e. I finished coding on this PR)
- [ ] All changes have test coverage:
- Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
- Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
- Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
- [x] To the best of my knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change
### Changes ###
- [ ] Feature1, tests, (and when applicable, API doc)
- [ ] Feature2, tests, (and when applicable, API doc)
## Comments ##
- If this change is a backward incompatible change, why must this change be made.
- Interesting edge cases to note here
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] access2rohit commented on pull request #18930: Support for fp16 in SpM x DnsM on GPU
Posted by GitBox <gi...@apache.org>.
access2rohit commented on pull request #18930:
URL: https://github.com/apache/incubator-mxnet/pull/18930#issuecomment-681849819
@mxnet-label-bot update [pr-ready-to-review]
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] access2rohit edited a comment on pull request #18930: Support for fp16 in SpM x DnsM on GPU
Posted by GitBox <gi...@apache.org>.
access2rohit edited a comment on pull request #18930:
URL: https://github.com/apache/incubator-mxnet/pull/18930#issuecomment-681849819
@mxnet-label-bot update [pr-awaiting-review]
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] access2rohit commented on pull request #18930: Support for fp16 in SpM x DnsM on GPU
Posted by GitBox <gi...@apache.org>.
access2rohit commented on pull request #18930:
URL: https://github.com/apache/incubator-mxnet/pull/18930#issuecomment-682052445
@ptrendx I have added test case. Can you help with review and merge
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] access2rohit commented on pull request #18930: [WIP]Support for fp16 in SpM x DnsM
Posted by GitBox <gi...@apache.org>.
access2rohit commented on pull request #18930:
URL: https://github.com/apache/incubator-mxnet/pull/18930#issuecomment-674328449
@mxnet-label-bot add [pr-work-in-progress]
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] access2rohit commented on pull request #18930: [WIP]Support for fp16 in SpM x DnsM
Posted by GitBox <gi...@apache.org>.
access2rohit commented on pull request #18930:
URL: https://github.com/apache/incubator-mxnet/pull/18930#issuecomment-674328517
@ptrendx Can you take an initial look ? I am yet to add test case though
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] sandeep-krishnamurthy merged pull request #18930: Support for fp16 in SpM x DnsM on GPU
Posted by GitBox <gi...@apache.org>.
sandeep-krishnamurthy merged pull request #18930:
URL: https://github.com/apache/incubator-mxnet/pull/18930
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] sandeep-krishnamurthy commented on pull request #18930: Support for fp16 in SpM x DnsM on GPU
Posted by GitBox <gi...@apache.org>.
sandeep-krishnamurthy commented on pull request #18930:
URL: https://github.com/apache/incubator-mxnet/pull/18930#issuecomment-683162512
Merging per previous review by @ptrendx
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #18930: [WIP]Support for fp16 in SpM x DnsM
Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on pull request #18930:
URL: https://github.com/apache/incubator-mxnet/pull/18930#issuecomment-674323358
Hey @access2rohit , Thanks for submitting the PR
All tests are already queued to run once. If tests fail, you can trigger one or more tests again with the following commands:
- To trigger all jobs: @mxnet-bot run ci [all]
- To trigger specific jobs: @mxnet-bot run ci [job1, job2]
***
**CI supported jobs**: [windows-cpu, clang, centos-gpu, unix-cpu, website, miscellaneous, edge, windows-gpu, centos-cpu, unix-gpu, sanity]
***
_Note_:
Only following 3 categories can trigger CI :PR Author, MXNet Committer, Jenkins Admin.
All CI tests must pass before the PR can be merged.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] ptrendx commented on pull request #18930: [WIP]Support for fp16 in SpM x DnsM
Posted by GitBox <gi...@apache.org>.
ptrendx commented on pull request #18930:
URL: https://github.com/apache/incubator-mxnet/pull/18930#issuecomment-675149815
Looks good :-)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org