[GitHub] [dubbo-go-hessian2] fangyincheng commented on a change in pull request #201: Ignore fields

[GitBox <gi...@apache.org>]

fangyincheng commented on a change in pull request #201:
URL: https://github.com/apache/dubbo-go-hessian2/pull/201#discussion_r437863319



##########
File path: object.go
##########
@@ -375,11 +374,18 @@ func (d *Decoder) decInstance(typ reflect.Type, cls classInfo) (interface{}, err
 	for i := 0; i < len(cls.fieldNameList); i++ {
 		fieldName := cls.fieldNameList[i]
 
-		index, fieldStruct, err := findFieldWithCache(fieldName, typ)
+		decodedValue, err := d.DecodeValue()
 		if err != nil {
 			return nil, perrors.Errorf("can not find field %s", fieldName)
 		}
 
+		index, fieldStruct, err := findFieldWithCache(fieldName, typ)
+		if err != nil {
+			log.Printf("SKIP non-exist field:%s", fieldName)

Review comment:
       感觉你看的pr不是这个呀，这个是上个被close的
   




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org