You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tooling.apache.org by "Abhay-raj-srivastava (via GitHub)" <gi...@apache.org> on 2025/12/02 08:28:03 UTC
[PR] Fix: Correct placement of metadata timestamp update in update_metadata() (tooling-trusted-releases)
Abhay-raj-srivastava opened a new pull request, #381:
URL: https://github.com/apache/tooling-trusted-releases/pull/381
## Summary
This PR fixes a logic error in `update_metadata()` that caused the update task
to crash.
The previous PR accidentally duplicated update blocks and placed the metadata
timestamp outside the correct transaction block.
## What This Fix Does
- Restores the correct ordering of update steps.
- Ensures the metadata timestamp `last_auto_committee_update` is written **inside**
the same transaction where committees are updated.
- Removes the duplicated blocks that were causing invalid behavior.
- Matches the maintainers’ requested structure.
## Why This Is Needed
The tooling relies on accurate timestamps for committee auto-updates.
The earlier misplaced logic broke database consistency and caused the update
task to fail.
This fix resolves the crash and preserves data integrity.
## Validation
- Rebased on top of `apache/main`.
- Verified structure matches current upstream.
- No functional changes except correcting the faulty logic structure.
Ready for review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@tooling.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tooling.apache.org
For additional commands, e-mail: dev-help@tooling.apache.org
Re: [PR] Fix: Correct placement of metadata timestamp update in update_metadata() (tooling-trusted-releases)
Posted by "sbp (via GitHub)" <gi...@apache.org>.
sbp commented on PR #381:
URL: https://github.com/apache/tooling-trusted-releases/pull/381#issuecomment-3601452894
@andrewmusselman The prior PR is https://github.com/apache/tooling-trusted-releases/pull/374
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@tooling.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tooling.apache.org
For additional commands, e-mail: dev-help@tooling.apache.org
Re: [PR] Fix: Correct placement of metadata timestamp update in update_metadata() (tooling-trusted-releases)
Posted by "andrewmusselman (via GitHub)" <gi...@apache.org>.
andrewmusselman commented on PR #381:
URL: https://github.com/apache/tooling-trusted-releases/pull/381#issuecomment-3601068448
@Abhay-raj-srivastava this diff doesn't appear to do what you say it does, and just reformats one line and adds a new timestamp, while changing indentation where it shouldn't be. Is there an issue open this addresses, and did you run `make check` to see what issues there might be? It also references a prior PR but I don't see which one it's referring to.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@tooling.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tooling.apache.org
For additional commands, e-mail: dev-help@tooling.apache.org
Re: [PR] Fix: Correct placement of metadata timestamp update in update_metadata() (tooling-trusted-releases)
Posted by "sbp (via GitHub)" <gi...@apache.org>.
sbp closed pull request #381: Fix: Correct placement of metadata timestamp update in update_metadata()
URL: https://github.com/apache/tooling-trusted-releases/pull/381
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@tooling.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tooling.apache.org
For additional commands, e-mail: dev-help@tooling.apache.org
Re: [PR] Fix: Correct placement of metadata timestamp update in update_metadata() (tooling-trusted-releases)
Posted by "sbp (via GitHub)" <gi...@apache.org>.
sbp commented on PR #381:
URL: https://github.com/apache/tooling-trusted-releases/pull/381#issuecomment-3601463981
@Abhay-raj-srivastava Nothing has changed in this submission.
```
$ curl -s https://patch-diff.githubusercontent.com/raw/apache/tooling-trusted-releases/pull/374.patch | shasum -a 256
1bad6f309e658e80a1d27e18061daa94060d978aa9dbf64844a49a817c6b0104 -
$ curl -s https://patch-diff.githubusercontent.com/raw/apache/tooling-trusted-releases/pull/381.patch | shasum -a 256
1bad6f309e658e80a1d27e18061daa94060d978aa9dbf64844a49a817c6b0104 -
```
And the code, as mentioned in the prior PR, does not work. We appreciate the offer to help, but we cannot accept broken code. Please read [our developer guide](https://release-test.apache.org/docs/developer-guide) thoroughly to understand how to make submissions. Thanks again for your contribution.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@tooling.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tooling.apache.org
For additional commands, e-mail: dev-help@tooling.apache.org