Re: Review Request 20123: Fix for cloudstack-6328 to Prevent console proxy support scripts from spawning multiple java processes

[Saurav Lahiri <sa...@sungardas.com>]

Rajani,
I had missed this. My apologies. The status shows as submitted. I am
guessing that you have updated the status and nothing more needs to be done.

Saurav



On Mon, Jul 28, 2014 at 11:48 AM, Rajani Karuturi <ra...@gmail.com>
wrote:

>    This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20123/
>
> On April 29th, 2014, 12:29 p.m. UTC, *Santhosh Edukulla* wrote:
>
> Ship It!
>
>  On May 23rd, 2014, 6:54 p.m. UTC, *Santhosh Edukulla* wrote:
>
> If we don't have any review issues pending, can some body with commit rights push this patch?
>
>  On July 22nd, 2014, 6:29 a.m. UTC, *Santhosh Edukulla* wrote:
>
> Saurav,
>
> Please update BugId and Branch fields. This review submission is pending since long. Please check.
>
> Santhosh
>
>  santhosh, bug-id is mentioned in the subject CLOUDSTACK-6328
>
> I looked at the bug comments on the bug. changes are already committed by jayapal. But, commit id isnt updated here and the review isnt closed.
>
> here is the commit for master https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=96b1c6b
>
> saurav, can you mark this review submitted?
>
>
> - Rajani
>
> On April 23rd, 2014, 9:20 a.m. UTC, Saurav Lahiri wrote:
>   Review request for cloudstack, Jayapal Reddy, Rajani Karuturi, Rajesh
> Battala, and Santhosh Edukulla.
> By Saurav Lahiri.
>
> *Updated April 23, 2014, 9:20 a.m.*
>  *Repository: * cloudstack-git
> Description
>
> With multiple java processes writing to the same logfile, each is not aware of the log4j's internal counter state, this needs to be prevented. So before starting new java process via the _run.sh , a check is made to ensure that there are no existing java processes running. This will prevent multiple java process writing to the same log file namely cloud.out.
>
>   Testing
>
> Tested the changes with console proxy vm and secondary storage vm. They start and stop as expected.
>
>   Diffs
>
>    - systemvm/patches/debian/config/etc/init.d/cloud (83853bc)
>    - systemvm/scripts/run.sh (146d96f)
>    - systemvm/scripts/utils.sh (PRE-CREATION)
>
> View Diff <https://reviews.apache.org/r/20123/diff/>
>