[GitHub] [activemq-artemis] franz1981 edited a comment on pull request #3370: ARTEMIS-3021 OOM due to wrong CORE message memory estimation

[GitBox <gi...@apache.org>]

franz1981 edited a comment on pull request #3370:
URL: https://github.com/apache/activemq-artemis/pull/3370#issuecomment-971226293


   There's a real failure on test `org.apache.activemq.artemis.tests.compatibility.HornetQSoakTest.testSoakHornetQ on testSoakHornetQ(org.apache.activemq.artemis.tests.compatibility.HornetQSoakTest)`:
   
   ```
   [Thread-22 (ActiveMQ-server-org.apache.activemq.artemis.core.server.impl.ActiveMQServerImpl$6@48247149)] 11:30:12,040 WARN  [org.apache.activemq.artemis.core.server] AMQ222151: removing consumer which did not handle a message, consumer=ServerConsumerImpl [id=0, filter=null, binding=LocalQueueBinding [address=topic, queue=QueueImpl[name=ARTEMIS8.test, postOffice=PostOfficeImpl [server=ActiveMQServerImpl::name=localhost], temp=false]@cd27f06, filter=null, name=ARTEMIS8.test, clusterName=ARTEMIS8.test77120279-46fa-11ec-a1ac-ecf4bbced624]], message=Reference[397]:RELIABLE:CoreMessage[messageID=397,durable=true,userID=78923a2e-46fa-11ec-a1ac-ecf4bbced624,priority=4, timestamp=Tue Nov 16 11:30:12 EST 2021,expiration=0, durable=true, address=jms.topic.topic,size=282,properties=TypedProperties[__AMQ_CID=78764db3-46fa-11ec-a1ac-ecf4bbced624,_AMQ_ROUTING_TYPE=0]]@350453798: java.lang.AssertionError: Bad Headers encode size estimation
   	at org.apache.activemq.artemis.core.message.impl.CoreMessage.encodeHeadersAndProperties(CoreMessage.java:785)
   	at org.apache.activemq.artemis.core.message.impl.CoreMessage.encode(CoreMessage.java:748)
   	at org.apache.activemq.artemis.core.message.impl.CoreMessage.checkEncode(CoreMessage.java:354)
   	at org.apache.activemq.artemis.core.message.impl.CoreMessage.getEncodeSize(CoreMessage.java:828)
   	at org.apache.activemq.artemis.core.protocol.core.impl.wireformat.SessionReceiveMessage.expectedEncodeSize(SessionReceiveMessage.java:54)
   	at org.apache.activemq.artemis.core.protocol.core.impl.PacketImpl.createPacket(PacketImpl.java:356)
   	at org.apache.activemq.artemis.core.protocol.core.impl.PacketImpl.encode(PacketImpl.java:327)
   	at org.apache.activemq.artemis.core.protocol.core.impl.ChannelImpl.send(ChannelImpl.java:379)
   	at org.apache.activemq.artemis.core.protocol.core.impl.ChannelImpl.sendBatched(ChannelImpl.java:333)
   	at org.apache.activemq.artemis.core.protocol.core.impl.CoreSessionCallback.sendMessage(CoreSessionCallback.java:128)
   	at org.apache.activemq.artemis.core.server.impl.ServerConsumerImpl.deliverStandardMessage(ServerConsumerImpl.java:1165)
   	at org.apache.activemq.artemis.core.server.impl.ServerConsumerImpl.proceedDeliver(ServerConsumerImpl.java:510)
   	at org.apache.activemq.artemis.core.server.impl.QueueImpl.proceedDeliver(QueueImpl.java:3840)
   	at org.apache.activemq.artemis.core.server.impl.QueueImpl.deliver(QueueImpl.java:3782)
   	at org.apache.activemq.artemis.core.server.impl.QueueImpl.deliverDirect(QueueImpl.java:3741)
   	at org.apache.activemq.artemis.core.server.impl.QueueImpl.addTail(QueueImpl.java:1251)
   	at org.apache.activemq.artemis.core.server.impl.RoutingContextImpl.internalprocessReferences(RoutingContextImpl.java:197)
   	at org.apache.activemq.artemis.core.server.impl.RoutingContextImpl.processReferences(RoutingContextImpl.java:192)
   	at org.apache.activemq.artemis.core.postoffice.impl.PostOfficeImpl$1.done(PostOfficeImpl.java:1563)
   	at org.apache.activemq.artemis.core.persistence.impl.journal.OperationContextImpl$1.run(OperationContextImpl.java:284)
   	at org.apache.activemq.artemis.utils.actors.OrderedExecutor.doTask(OrderedExecutor.java:42)
   	at org.apache.activemq.artemis.utils.actors.OrderedExecutor.doTask(OrderedExecutor.java:31)
   	at org.apache.activemq.artemis.utils.actors.ProcessorBase.executePendingTasks(ProcessorBase.java:65)
   	at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1128)
   	at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:628)
   	at org.apache.activemq.artemis.utils.ActiveMQThreadFactory$1.run(ActiveMQThreadFactory.java:118)
   ```
   I see that using `assert` for invariant has some value :P @gtully 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org