You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by "jyotirmoy-gh (via GitHub)" <gi...@apache.org> on 2023/09/12 10:22:30 UTC
[GitHub] [ozone] jyotirmoy-gh opened a new pull request, #5278: HDDS-9268. [snapshot] Update list of snapshot apis to include lsDiff details
jyotirmoy-gh opened a new pull request, #5278:
URL: https://github.com/apache/ozone/pull/5278
## What changes were proposed in this pull request?
Update list of snapshot apis to include lsDiff details
```
# ozone sh snapshot lsDiff -h
Usage: ozone sh snapshot listDiff [-ahV] [-s=<jobStatus>] <value>
List snapshotDiff jobs for a bucket.
```
## What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-9268
## How was this patch tested?
NA
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] jyotirmoy-gh commented on a diff in pull request #5278: HDDS-9268. [snapshot] Update list of snapshot apis to include lsDiff details
Posted by "jyotirmoy-gh (via GitHub)" <gi...@apache.org>.
jyotirmoy-gh commented on code in PR #5278:
URL: https://github.com/apache/ozone/pull/5278#discussion_r1322922637
##########
hadoop-hdds/docs/content/feature/Snapshot.md:
##########
@@ -50,9 +50,13 @@ ozone sh snapshot delete [-hV] <bucket> <snapshotName>
```shell
ozone sh snapshot diff [-chV] [-p=<pageSize>] [-t=<continuation-token>] <bucket> <fromSnapshot> <toSnapshot>
```
-
SnapshotDiff CLI/API is asynchronous. The first time the API is invoked, OM starts a background thread to calculate the SnapshotDiff, and returns "Retry" with suggested duration for the retry operation. Once the SnapshotDiff is computed, this API returns the diffs in multiple Pages. Within each Diff response, OM also returns a continuation token for the client to continue from the last batch of Diff results. This API is safe to be called multiple times for a given snapshot source and destination pair. Internally each Ozone Manager computes Snapdiff only once and stores it for future invocations of the same Snapshot Diff API.
+* List SnapshotDiff Jobs: List all snapshotDiff jobs of a given bucket
+```shell
+ozone sh snapshot listDiff [-ahV] [-s=<jobStatus>] <value>
Review Comment:
I had named it as per the actual command line. Changed it to value in accordance with the other commands details
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] sadanand48 merged pull request #5278: HDDS-9268. [snapshot] Update list of snapshot apis to include lsDiff details
Posted by "sadanand48 (via GitHub)" <gi...@apache.org>.
sadanand48 merged PR #5278:
URL: https://github.com/apache/ozone/pull/5278
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] sadanand48 commented on a diff in pull request #5278: HDDS-9268. [snapshot] Update list of snapshot apis to include lsDiff details
Posted by "sadanand48 (via GitHub)" <gi...@apache.org>.
sadanand48 commented on code in PR #5278:
URL: https://github.com/apache/ozone/pull/5278#discussion_r1322858514
##########
hadoop-hdds/docs/content/feature/Snapshot.md:
##########
@@ -50,9 +50,13 @@ ozone sh snapshot delete [-hV] <bucket> <snapshotName>
```shell
ozone sh snapshot diff [-chV] [-p=<pageSize>] [-t=<continuation-token>] <bucket> <fromSnapshot> <toSnapshot>
```
-
SnapshotDiff CLI/API is asynchronous. The first time the API is invoked, OM starts a background thread to calculate the SnapshotDiff, and returns "Retry" with suggested duration for the retry operation. Once the SnapshotDiff is computed, this API returns the diffs in multiple Pages. Within each Diff response, OM also returns a continuation token for the client to continue from the last batch of Diff results. This API is safe to be called multiple times for a given snapshot source and destination pair. Internally each Ozone Manager computes Snapdiff only once and stores it for future invocations of the same Snapshot Diff API.
+* List SnapshotDiff Jobs: List all snapshotDiff jobs of a given bucket
+```shell
+ozone sh snapshot listDiff [-ahV] [-s=<jobStatus>] <value>
Review Comment:
How about `ozone sh snapshot listDiff [-ahV] [-s=<jobStatus>] <bucket> ` ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] jyotirmoy-gh commented on pull request #5278: HDDS-9268. [snapshot] Update list of snapshot apis to include lsDiff details
Posted by "jyotirmoy-gh (via GitHub)" <gi...@apache.org>.
jyotirmoy-gh commented on PR #5278:
URL: https://github.com/apache/ozone/pull/5278#issuecomment-1715468823
@sadanand48 @smengcl @hemantk-12 - Please review
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] sadanand48 commented on pull request #5278: HDDS-9268. [snapshot] Update list of snapshot apis to include lsDiff details
Posted by "sadanand48 (via GitHub)" <gi...@apache.org>.
sadanand48 commented on PR #5278:
URL: https://github.com/apache/ozone/pull/5278#issuecomment-1717013264
Thanks @jyotirmoy-gh for the doc update.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org