You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by "Per Steffensen (JIRA)" <ji...@apache.org> on 2014/09/16 10:23:33 UTC

[jira] [Created] (SOLR-6522) DirectUpdateHandler2 - log start/end on debug-level

Per Steffensen created SOLR-6522:
------------------------------------

             Summary: DirectUpdateHandler2 - log start/end on debug-level
                 Key: SOLR-6522
                 URL: https://issues.apache.org/jira/browse/SOLR-6522
             Project: Solr
          Issue Type: Improvement
          Components: update
            Reporter: Per Steffensen
            Priority: Trivial


There are some loggings in {{DirectUpdateHandler2}} on info-level that I believe ought to be on debug-level. That is
* All the {{log.info("start ...);}} and {{log.info("end ...);}} loggings
* {{log.info("No uncommitted changes. Skipping IW.commit.");}}
* {{log.info("Committing on IndexWriter close.");}}

Reason I want it changed is that we log something on info-level (that really belongs on info-level) in our extended version of {{DirectUpdateHandler2}}, and we want that logged without filling up our log-files with the stuff mentioned above. Now that is not especially relevant for Apache Solr, but besides that I believe that this change is "the right thing to do", and that it should therefore be done.

In general I believe it would be a good idea to scan the entire code-base to see if we log on the "right" level - I believe there are lots of places around the code where the log-level is chosen "by random". But I will leave that to other issues.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org