You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by MikeThomsen <gi...@git.apache.org> on 2018/06/29 13:52:29 UTC
[GitHub] nifi-registry pull request #128: NIFIREG-180 Added db configuration properti...
GitHub user MikeThomsen opened a pull request:
https://github.com/apache/nifi-registry/pull/128
NIFIREG-180 Added db configuration properties to the docker image.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/MikeThomsen/nifi-registry NIFIREG-180
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi-registry/pull/128.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #128
----
commit 2e8c20809614b4e80fb4222471e0853a149e9140
Author: Mike <mi...@...>
Date: 2018-06-29T13:51:10Z
NIFIREG-180 Added db configuration properties to the docker image.
----
---
[GitHub] nifi-registry issue #128: NIFIREG-180 Added db configuration properties to t...
Posted by apiri <gi...@git.apache.org>.
Github user apiri commented on the issue:
https://github.com/apache/nifi-registry/pull/128
hey @MikeThomsen,
This looks fine. I see now that the README.md is deficient in enumerating such configuration but would you mind surfacing these added properties similar to https://github.com/apache/nifi/blob/master/nifi-docker/dockerhub/README.md#configuration-information? I typically use https://www.tablesgenerator.com/markdown_tables to help gen up the formatting.
---
[GitHub] nifi-registry issue #128: NIFIREG-180 Added db configuration properties to t...
Posted by MikeThomsen <gi...@git.apache.org>.
Github user MikeThomsen commented on the issue:
https://github.com/apache/nifi-registry/pull/128
@apiri updated. Let me know what you think.
---
[GitHub] nifi-registry pull request #128: NIFIREG-180 Added db configuration properti...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/nifi-registry/pull/128
---
[GitHub] nifi-registry issue #128: NIFIREG-180 Added db configuration properties to t...
Posted by MikeThomsen <gi...@git.apache.org>.
Github user MikeThomsen commented on the issue:
https://github.com/apache/nifi-registry/pull/128
@apiri Can you review? Once this is done, I'd like to move onto adding support for the GitFlow adapter.
---
[GitHub] nifi-registry issue #128: NIFIREG-180 Added db configuration properties to t...
Posted by apiri <gi...@git.apache.org>.
Github user apiri commented on the issue:
https://github.com/apache/nifi-registry/pull/128
@MikeThomsen looks good. thank you for the updates. definitely helpful to not have to dig through source to see what is possible.
---