You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@streampark.apache.org by GitBox <gi...@apache.org> on 2022/10/01 03:12:14 UTC

[GitHub] [incubator-streampark] 1996fanrui opened a new pull request, #1728: [Improve] Make sure this role is not bound by the user before removing the role

1996fanrui opened a new pull request, #1728:
URL: https://github.com/apache/incubator-streampark/pull/1728

   ## What problem does this PR solve?
   
   Issue Number: close #1727 
   
   Problem Summary:
   
   1. Make sure this role is not bound by the user before removing the role
   2. when delete a role, delete menu mapping of this role
   
   
   ## What is changed and how it works?
   
   Proposal: [xxx](url) <!-- REMOVE this line if not applicable -->
   
   Feel free to ping committers for the review!
   
   ## Contribution Checklist
   
     - Make sure that the pull request corresponds to a [GITHUB issue](https://github.com/apache/streampark/issues).
   
     - Name the pull request in the form "[Feature] [component] Title of the pull request", where *Feature* can be replaced by `Hotfix`, `Bug`, etc.
   
     - Minor fixes should be named following this pattern: `[hotfix] [docs] Fix typo in README.md doc`.
   
   ## Purpose of this pull request
   
   1. Make sure this role is not bound by the user before removing the role
   2. when delete a role, delete menu mapping of this role


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@streampark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-streampark] wolfboys commented on pull request #1728: [Improve] Make sure this role is not bound by the user before removing the role

Posted by GitBox <gi...@apache.org>.
wolfboys commented on PR #1728:
URL: https://github.com/apache/incubator-streampark/pull/1728#issuecomment-1264381838

   Thanks for your contribution, I will review it later.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@streampark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-streampark] wolfboys merged pull request #1728: [Improve] Make sure this role is not bound by the user before removing the role

Posted by GitBox <gi...@apache.org>.
wolfboys merged PR #1728:
URL: https://github.com/apache/incubator-streampark/pull/1728


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@streampark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-streampark] 1996fanrui commented on pull request #1728: [Improve] Make sure this role is not bound by the user before removing the role

Posted by GitBox <gi...@apache.org>.
1996fanrui commented on PR #1728:
URL: https://github.com/apache/incubator-streampark/pull/1728#issuecomment-1264555082

   @wolfboys Thanks for your review.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@streampark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org