[jira] [Commented] (MINIFI-388) MiNiFi core on startup if TLS is used with ListenHTTP (civet)

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/MINIFI-388?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16150534#comment-16150534 ] 

ASF GitHub Bot commented on MINIFI-388:
---------------------------------------

Github user phrocker commented on a diff in the pull request:

    https://github.com/apache/nifi-minifi-cpp/pull/131#discussion_r136576120
  
    --- Diff: thirdparty/civetweb-1.9.1/src/civetweb.c ---
    @@ -11856,7 +11859,24 @@ ssl_get_client_cert_info(struct mg_connection *conn)
     
     		/* Calculate SHA1 fingerprint and store as a hex string */
     		ulen = 0;
    -		ASN1_digest((int (*)())i2d_X509, digest, (char *)cert, buf, &ulen);
    +
    +		/* ASN1_digest is deprecated. Do the calculation manually,
    --- End diff --
    
    Sorry I missed this response. I was concerned about using custom code in the third party dir, but with that knowledge, with that knowledge it's a non issue. I'll +1 and merge, thanks!


> MiNiFi core on startup if TLS is used with ListenHTTP (civet)
> -------------------------------------------------------------
>
>                 Key: MINIFI-388
>                 URL: https://issues.apache.org/jira/browse/MINIFI-388
>             Project: Apache NiFi MiNiFi
>          Issue Type: Bug
>          Components: C++, Docker
>            Reporter: Andrew Christianson
>            Assignee: Andrew Christianson
>
> MiNiFi cpp core dumps on startup because civet attempts to load libssl/libcrypto from non-versioned paths (/usr/lib/libssl.so, /usr/lib/libcrypto.so). This is simple to fix with symlinks from 1.0.0 lib paths to the non-versioned paths.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)