You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@couchdb.apache.org by tonysun83 <gi...@git.apache.org> on 2017/02/01 05:00:05 UTC

[GitHub] couchdb-fabric pull request #87: Add Else Clause For Embed Doc

GitHub user tonysun83 opened a pull request:

    https://github.com/apache/couchdb-fabric/pull/87

    Add Else Clause For Embed Doc

    When open_doc or open_revs return an error, we set the doc value
    to be an error message. This way we account for errors rather than
    transform_row throwing a function_clause.
    
    This PR will not be merged until https://github.com/apache/couchdb-fabric/pull/86 is merged.
    Another PR for chttpd will contain end-to-end tests that will cover the testing for this PR.
    
    COUCHDB-3109

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/cloudant/couchdb-fabric 68661-embed-doc-error

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/couchdb-fabric/pull/87.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #87
    
----
commit 3a8c71485893706e539ba51891a7785ffa0a82e7
Author: Tony Sun <to...@cloudant.com>
Date:   2017-02-01T04:47:13Z

    Add Else Clause For Embed Doc
    
    When open_doc or open_revs return an error, we set the doc value
    to be an error message. This way we account for errors rather than
    transform_row throwing a function_clause.
    
    COUCHDB-3109

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] couchdb-fabric pull request #87: Add Else Clause For Embed Doc

Posted by tonysun83 <gi...@git.apache.org>.

Github user tonysun83 closed the pull request at:

    https://github.com/apache/couchdb-fabric/pull/87


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] couchdb-fabric issue #87: Add Else Clause For Embed Doc

Posted by iilyak <gi...@git.apache.org>.

Github user iilyak commented on the issue:

    https://github.com/apache/couchdb-fabric/pull/87
  
    +1


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] couchdb-fabric issue #87: Add Else Clause For Embed Doc

Posted by tonysun83 <gi...@git.apache.org>.

Github user tonysun83 commented on the issue:

    https://github.com/apache/couchdb-fabric/pull/87
  
    I screwed up and did a rebase but forgot to push it to remote before merging to master. So the commit is actually cf220b2e927093e3bd6f409b4ca9f7b1be0a04a3


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---