[GitHub] [incubator-druid] clintropolis commented on a change in pull request #8238: [statsd-emitter] Add config to send Druid process/service as tag

[GitBox <gi...@apache.org>]

clintropolis commented on a change in pull request #8238: [statsd-emitter] Add config to send Druid process/service as tag
URL: https://github.com/apache/incubator-druid/pull/8238#discussion_r312753471
 
 

 ##########
 File path: docs/content/development/extensions-contrib/statsd.md
 ##########
 @@ -47,6 +47,7 @@ All the configuration parameters for the StatsD emitter are under `druid.emitter
 |`druid.emitter.statsd.blankHolder`|The blank character replacement as statsD does not support path with blank character|no|"-"|  
 |`druid.emitter.statsd.dogstatsd`|Flag to enable [DogStatsD](https://docs.datadoghq.com/developers/dogstatsd/) support. Causes dimensions to be included as tags, not as a part of the metric name. `convertRange` fields will be ignored.|no|false|
 |`druid.emitter.statsd.dogstatsdConstantTags`|If `druid.emitter.statsd.dogstatsd` is true, the tags in the JSON list of strings will be sent with every event.|no|[]|
+|`druid.emitter.statsd.dogstatsdServiceAsTag`|If `druid.emitter.statsd.dogstatsdServiceAsTag` is true, druid service (e.g. `druid/broker`, `druid/coordinator`, etc) is reported as a tag (e.g. `service:druid/broker`) instead of being included in metric name (e.g. `druid.broker.my_metric`) and `druid` is used as metric prefix (e.g. `druid.query.time`).|no|false|
 
 Review comment:
   It looks to me like `druid.emitter.statsd.dogstatsd` must also be set to `true` get this behavior, if this is accurate could you also mention that in the docs for `druid.emitter.statsd.dogstatsdServiceAsTag`?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org