You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by dianfu <gi...@git.apache.org> on 2017/08/10 12:35:13 UTC
[GitHub] flink pull request #4513: [FLINK-6938][FLINK-6939] [cep] Not store Iterative...
GitHub user dianfu opened a pull request:
https://github.com/apache/flink/pull/4513
[FLINK-6938][FLINK-6939] [cep] Not store IterativeCondition with NFA state and support RichFunction interface
## What is the purpose of the change
*The core idea is that the StateTransition is unique in a NFA graph. So we store the conditions with a map which mapping from StateTransition to IterativeCondition, so the conditions can not serialized with NFA state. If I missed something, please point out.
This PR also includes FLINK-6938: IterativeCondition supports RichFunction interface.*
## Verifying this change
This change is already covered by existing tests*.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (no)
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no)
- The serializers: (no)
- The runtime per-record code paths (performance sensitive): ( no)
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (no)
## Documentation
- Does this pull request introduce a new feature? (no)
- If yes, how is the feature documented? (JavaDocs)
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/dianfu/flink IterativeCondition
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/4513.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #4513
----
commit e8f4bfd55eb50b151b8160c7c8f8901114aa7606
Author: Jark Wu <wu...@alibaba-inc.com>
Date: 2017-06-20T06:02:21Z
[FLINK-6938][FLINK-6939] [cep] Not store IterativeCondition with NFA state and support RichFunction interface
commit 994bc06c11bffbf129d7160a4db2a16db01199d8
Author: Jark Wu <wu...@alibaba-inc.com>
Date: 2017-06-20T13:25:59Z
minor change
commit ae26dab180943f9b6609341d7447718f772b8b19
Author: Jark Wu <wu...@alibaba-inc.com>
Date: 2017-06-22T03:17:47Z
address dawid's comments
commit e8c28049d2eb96500f53d6e7f284ae074280b5a1
Author: Dian Fu <fu...@alibaba-inc.com>
Date: 2017-08-10T12:25:50Z
Rebase the code
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #4513: [FLINK-6938][FLINK-6939] [cep] Not store IterativeConditi...
Posted by dianfu <gi...@git.apache.org>.
Github user dianfu commented on the issue:
https://github.com/apache/flink/pull/4513
@dawidwys @kl0u In case you missed this PR, could you help to take a look at? Very appreciated.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #4513: [FLINK-6938][FLINK-6939] [cep] Not store IterativeConditi...
Posted by dawidwys <gi...@git.apache.org>.
Github user dawidwys commented on the issue:
https://github.com/apache/flink/pull/4513
Hmm, I read back all the comments to previous PRs and I think the consesus was that we do not want to introduce the ConditionRegistry at that time, but start with just FLINK-6938 to enable SQL integration.
See comments on that PR: #4172
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #4513: [FLINK-6938] [cep] IterativeCondition should support Rich...
Posted by dianfu <gi...@git.apache.org>.
Github user dianfu commented on the issue:
https://github.com/apache/flink/pull/4513
@dawidwys It would be great if you could take a look. Very appreciated!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #4513: [FLINK-6938][FLINK-6939] [cep] Not store IterativeConditi...
Posted by dianfu <gi...@git.apache.org>.
Github user dianfu commented on the issue:
https://github.com/apache/flink/pull/4513
As discussed with @wuchong offline, I will continue the work of #4145 as this is required by the feature of cep on sql, see the PR of FLINK-7062 for details.
@dawidwys @kl0u Could you help to review? Actually, I just rebased the code of #4145 and addressed the comments there. Most of the fixes refer the test branch https://github.com/kl0u/flink/tree/cep-iter-pr by @kl0u. I have not removed IterativeCondition as I think it breaks the backward compatibility.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #4513: [FLINK-6938] [cep] IterativeCondition should support Rich...
Posted by dianfu <gi...@git.apache.org>.
Github user dianfu commented on the issue:
https://github.com/apache/flink/pull/4513
@dawidwys Any comments?
---
[GitHub] flink issue #4513: [FLINK-6938][FLINK-6939] [cep] Not store IterativeConditi...
Posted by dianfu <gi...@git.apache.org>.
Github user dianfu commented on the issue:
https://github.com/apache/flink/pull/4513
Thanks @dawidwys for the remind. Yes, you're right and that make sense to me. I will update the the PR and remove ConditionRegistry related changes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #4513: [FLINK-6938] [cep] IterativeCondition should support Rich...
Posted by dianfu <gi...@git.apache.org>.
Github user dianfu commented on the issue:
https://github.com/apache/flink/pull/4513
@dawidwys I have updated the PR and it currently only contains changes of the RichFunction.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---