You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by Peter Samuelson <pe...@p12n.org> on 2008/08/15 19:46:16 UTC

Re: svn commit: r32497 - trunk/subversion/libsvn_ra_neon

[kfogel@tigris.org]
> +/* Initialize neon when not initialized before. */
> +static svn_error_t *
> +ensure_neon_initialized(void)
> +{
> +  SVN_ERR(svn_atomic__init_once(&neon_initialized, initialize_neon, NULL));
> +  return SVN_NO_ERROR;
> +}

Am I missing something or should that be simplified to

     return svn_atomic__init_once(&neon_initialized, initialize_neon, NULL);

-- 
Peter Samuelson | org-tld!p12n!peter | http://p12n.org/

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org

Re: svn commit: r32497 - trunk/subversion/libsvn_ra_neon

Posted by Karl Fogel <kf...@red-bean.com>.
Peter Samuelson <pe...@p12n.org> writes:
> [kfogel@tigris.org]
>> +/* Initialize neon when not initialized before. */
>> +static svn_error_t *
>> +ensure_neon_initialized(void)
>> +{
>> +  SVN_ERR(svn_atomic__init_once(&neon_initialized, initialize_neon, NULL));
>> +  return SVN_NO_ERROR;
>> +}
>
> Am I missing something or should that be simplified to
>
>      return svn_atomic__init_once(&neon_initialized, initialize_neon, NULL);

It should be, nice catch.  Done in r32510.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org