You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@doris.apache.org by 陈明雨 <mo...@163.com> on 2020/08/17 12:58:03 UTC

[DISCUSS] Remove the DISCLAIMER-WIP

Our previous version still carries DISCLAIMER-WIP. Because there are still some problems in our current code




The main problem comes from two aspects:



1. MySQL library and LZO library



The license of these two third-party dependent libraries is GPL and is incompatible with the Apache License.
Therefore we take the following measures:


For the MySQL library, we will replace it with UnixOBDC later. Currently we use compilation options to control.
And the default compilation option is OFF, that is, the MySQL dependent library is not used.




For LZO, it is currently only used to read some old version data. The new version of data reading and writing
are not using the LZO compression algorithm anymore. The data of the old version will be gradually converted
to the new version format  
Similarly, currently we use compilation options to control. And the default compilation option is OFF.




These two libraries are expected to be completely eliminated in version 0.14.




2. There are some compiled JS or CSS files in code repo.




The frontend code depends Bootstrap and jQuery. These dependencies have been changed to download from official channels,
and the source code of these dependencies has been removed from the Doris code base.




3. The code without the license header and the third-party code without the license declaration




At present, all codes belonging to Doris have added a license header, including source code files, configuration files, document files, etc.
All codes from third parties are marked in the LICENSE file, and the license of these codes is guaranteed to be compatible with the apache license.


I have created an ISSUE[1] to tracker this. And also made a pull request[2] including all modification I mentioned above.


------------------------------------------------
[1] https://github.com/apache/incubator-doris/issues/4372
[2] https://github.com/apache/incubator-doris/pull/4371



--

此致!Best Regards
陈明雨 Mingyu Chen

Email:
morningman@163.com;
morningman.cmy@gmail.com

Re:Re: [DISCUSS] Remove the DISCLAIMER-WIP

Posted by 陈明雨 <mo...@163.com>.
Hi Willem:


Thank you for you reply.
Allow me to clarify the current situation of Doris. Please help us to confirm whether our understanding is correct.


We rely on 3 third-party libraries. Their licenses are
[1](GPL), [2](GPL), and [3](LGPL) respectively.
We only link these third-party libraries, and the source code of these libraries is not included, nor used or modified in the Doris source kit.
Among them, [1] and [2] are under GPL. The GPL itself is completely incompatible with the Apache License.
But according to the description in [4], we can use these two libraries as optional components of Doris, and they are disabled by default.
And even when these two libraries are disabled, users can still use Doris normally.

Library [3] is under the LGPL. According to the rules of the LGPL agreement, as long as the [3]'s source code is not included in Doris, we can link and use this library.


[1] MySQL Client Library
[2] LZO
[3] UnixODBC
[4] http://www.apache.org/legal/resolved.html#optional 



--

此致!Best Regards
陈明雨 Mingyu Chen

Email:
chenmingyu@apache.org





在 2020-08-19 10:37:18,"ling miao" <li...@apache.org> 写道:
>Hi Willem,
>Does this mean that mysql driver cannot exist in our docker image or binary
>package?
>
>Ling Miao
>
>Willem Jiang <wi...@gmail.com> 于2020年8月19日周三 上午8:09写道:
>
>> We need to check if the source kit has the third party dependency of
>> GPL and LGPL code.
>> We cannot ship the GPL and LGPL code with our source kit for the
>> License compliance requirement.
>>
>>
>> Willem Jiang
>>
>> Twitter: willemjiang
>> Weibo: 姜宁willem
>>
>> On Mon, Aug 17, 2020 at 8:58 PM 陈明雨 <mo...@163.com> wrote:
>> >
>> > Our previous version still carries DISCLAIMER-WIP. Because there are
>> still some problems in our current code
>> >
>> >
>> >
>> >
>> > The main problem comes from two aspects:
>> >
>> >
>> >
>> > 1. MySQL library and LZO library
>> >
>> >
>> >
>> > The license of these two third-party dependent libraries is GPL and is
>> incompatible with the Apache License.
>> > Therefore we take the following measures:
>> >
>> >
>> > For the MySQL library, we will replace it with UnixOBDC later. Currently
>> we use compilation options to control.
>> > And the default compilation option is OFF, that is, the MySQL dependent
>> library is not used.
>> >
>> >
>> >
>> >
>> > For LZO, it is currently only used to read some old version data. The
>> new version of data reading and writing
>> > are not using the LZO compression algorithm anymore. The data of the old
>> version will be gradually converted
>> > to the new version format
>> > Similarly, currently we use compilation options to control. And the
>> default compilation option is OFF.
>> >
>> >
>> >
>> >
>> > These two libraries are expected to be completely eliminated in version
>> 0.14.
>> >
>> >
>> >
>> >
>> > 2. There are some compiled JS or CSS files in code repo.
>> >
>> >
>> >
>> >
>> > The frontend code depends Bootstrap and jQuery. These dependencies have
>> been changed to download from official channels,
>> > and the source code of these dependencies has been removed from the
>> Doris code base.
>> >
>> >
>> >
>> >
>> > 3. The code without the license header and the third-party code without
>> the license declaration
>> >
>> >
>> >
>> >
>> > At present, all codes belonging to Doris have added a license header,
>> including source code files, configuration files, document files, etc.
>> > All codes from third parties are marked in the LICENSE file, and the
>> license of these codes is guaranteed to be compatible with the apache
>> license.
>> >
>> >
>> > I have created an ISSUE[1] to tracker this. And also made a pull
>> request[2] including all modification I mentioned above.
>> >
>> >
>> > ------------------------------------------------
>> > [1] https://github.com/apache/incubator-doris/issues/4372
>> > [2] https://github.com/apache/incubator-doris/pull/4371
>> >
>> >
>> >
>> > --
>> >
>> > 此致!Best Regards
>> > 陈明雨 Mingyu Chen
>> >
>> > Email:
>> > morningman@163.com;
>> > morningman.cmy@gmail.com
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@doris.apache.org
>> For additional commands, e-mail: dev-help@doris.apache.org
>>
>>

Re:Re: [DISCUSS] Remove the DISCLAIMER-WIP

Posted by 陈明雨 <mo...@163.com>.
Okay, it seems that our current use of the third party library follows the Apache principles.
We will inform users in detail how to deal with these optional components in the document.


Thanks again!



--

此致!Best Regards
陈明雨 Mingyu Chen

Email:
chenmingyu@apache.org





在 2020-08-19 19:51:57,"Willem Jiang" <wi...@gmail.com> 写道:
>The docker image and binary package are binary convinced releases.
>We need to provide instructions for the user to install  or build with
>the MySQL client themself.
>
>Willem Jiang
>
>Twitter: willemjiang
>Weibo: 姜宁willem
>
>On Wed, Aug 19, 2020 at 10:37 AM ling miao <li...@apache.org> wrote:
>>
>> Hi Willem,
>> Does this mean that mysql driver cannot exist in our docker image or binary
>> package?
>>
>> Ling Miao
>>
>> Willem Jiang <wi...@gmail.com> 于2020年8月19日周三 上午8:09写道:
>>
>> > We need to check if the source kit has the third party dependency of
>> > GPL and LGPL code.
>> > We cannot ship the GPL and LGPL code with our source kit for the
>> > License compliance requirement.
>> >
>> >
>> > Willem Jiang
>> >
>> > Twitter: willemjiang
>> > Weibo: 姜宁willem
>> >
>> > On Mon, Aug 17, 2020 at 8:58 PM 陈明雨 <mo...@163.com> wrote:
>> > >
>> > > Our previous version still carries DISCLAIMER-WIP. Because there are
>> > still some problems in our current code
>> > >
>> > >
>> > >
>> > >
>> > > The main problem comes from two aspects:
>> > >
>> > >
>> > >
>> > > 1. MySQL library and LZO library
>> > >
>> > >
>> > >
>> > > The license of these two third-party dependent libraries is GPL and is
>> > incompatible with the Apache License.
>> > > Therefore we take the following measures:
>> > >
>> > >
>> > > For the MySQL library, we will replace it with UnixOBDC later. Currently
>> > we use compilation options to control.
>> > > And the default compilation option is OFF, that is, the MySQL dependent
>> > library is not used.
>> > >
>> > >
>> > >
>> > >
>> > > For LZO, it is currently only used to read some old version data. The
>> > new version of data reading and writing
>> > > are not using the LZO compression algorithm anymore. The data of the old
>> > version will be gradually converted
>> > > to the new version format
>> > > Similarly, currently we use compilation options to control. And the
>> > default compilation option is OFF.
>> > >
>> > >
>> > >
>> > >
>> > > These two libraries are expected to be completely eliminated in version
>> > 0.14.
>> > >
>> > >
>> > >
>> > >
>> > > 2. There are some compiled JS or CSS files in code repo.
>> > >
>> > >
>> > >
>> > >
>> > > The frontend code depends Bootstrap and jQuery. These dependencies have
>> > been changed to download from official channels,
>> > > and the source code of these dependencies has been removed from the
>> > Doris code base.
>> > >
>> > >
>> > >
>> > >
>> > > 3. The code without the license header and the third-party code without
>> > the license declaration
>> > >
>> > >
>> > >
>> > >
>> > > At present, all codes belonging to Doris have added a license header,
>> > including source code files, configuration files, document files, etc.
>> > > All codes from third parties are marked in the LICENSE file, and the
>> > license of these codes is guaranteed to be compatible with the apache
>> > license.
>> > >
>> > >
>> > > I have created an ISSUE[1] to tracker this. And also made a pull
>> > request[2] including all modification I mentioned above.
>> > >
>> > >
>> > > ------------------------------------------------
>> > > [1] https://github.com/apache/incubator-doris/issues/4372
>> > > [2] https://github.com/apache/incubator-doris/pull/4371
>> > >
>> > >
>> > >
>> > > --
>> > >
>> > > 此致!Best Regards
>> > > 陈明雨 Mingyu Chen
>> > >
>> > > Email:
>> > > morningman@163.com;
>> > > morningman.cmy@gmail.com
>> >
>> > ---------------------------------------------------------------------
>> > To unsubscribe, e-mail: dev-unsubscribe@doris.apache.org
>> > For additional commands, e-mail: dev-help@doris.apache.org
>> >
>> >
>
>---------------------------------------------------------------------
>To unsubscribe, e-mail: dev-unsubscribe@doris.apache.org
>For additional commands, e-mail: dev-help@doris.apache.org

Re: [DISCUSS] Remove the DISCLAIMER-WIP

Posted by Willem Jiang <wi...@gmail.com>.
The docker image and binary package are binary convinced releases.
We need to provide instructions for the user to install  or build with
the MySQL client themself.

Willem Jiang

Twitter: willemjiang
Weibo: 姜宁willem

On Wed, Aug 19, 2020 at 10:37 AM ling miao <li...@apache.org> wrote:
>
> Hi Willem,
> Does this mean that mysql driver cannot exist in our docker image or binary
> package?
>
> Ling Miao
>
> Willem Jiang <wi...@gmail.com> 于2020年8月19日周三 上午8:09写道:
>
> > We need to check if the source kit has the third party dependency of
> > GPL and LGPL code.
> > We cannot ship the GPL and LGPL code with our source kit for the
> > License compliance requirement.
> >
> >
> > Willem Jiang
> >
> > Twitter: willemjiang
> > Weibo: 姜宁willem
> >
> > On Mon, Aug 17, 2020 at 8:58 PM 陈明雨 <mo...@163.com> wrote:
> > >
> > > Our previous version still carries DISCLAIMER-WIP. Because there are
> > still some problems in our current code
> > >
> > >
> > >
> > >
> > > The main problem comes from two aspects:
> > >
> > >
> > >
> > > 1. MySQL library and LZO library
> > >
> > >
> > >
> > > The license of these two third-party dependent libraries is GPL and is
> > incompatible with the Apache License.
> > > Therefore we take the following measures:
> > >
> > >
> > > For the MySQL library, we will replace it with UnixOBDC later. Currently
> > we use compilation options to control.
> > > And the default compilation option is OFF, that is, the MySQL dependent
> > library is not used.
> > >
> > >
> > >
> > >
> > > For LZO, it is currently only used to read some old version data. The
> > new version of data reading and writing
> > > are not using the LZO compression algorithm anymore. The data of the old
> > version will be gradually converted
> > > to the new version format
> > > Similarly, currently we use compilation options to control. And the
> > default compilation option is OFF.
> > >
> > >
> > >
> > >
> > > These two libraries are expected to be completely eliminated in version
> > 0.14.
> > >
> > >
> > >
> > >
> > > 2. There are some compiled JS or CSS files in code repo.
> > >
> > >
> > >
> > >
> > > The frontend code depends Bootstrap and jQuery. These dependencies have
> > been changed to download from official channels,
> > > and the source code of these dependencies has been removed from the
> > Doris code base.
> > >
> > >
> > >
> > >
> > > 3. The code without the license header and the third-party code without
> > the license declaration
> > >
> > >
> > >
> > >
> > > At present, all codes belonging to Doris have added a license header,
> > including source code files, configuration files, document files, etc.
> > > All codes from third parties are marked in the LICENSE file, and the
> > license of these codes is guaranteed to be compatible with the apache
> > license.
> > >
> > >
> > > I have created an ISSUE[1] to tracker this. And also made a pull
> > request[2] including all modification I mentioned above.
> > >
> > >
> > > ------------------------------------------------
> > > [1] https://github.com/apache/incubator-doris/issues/4372
> > > [2] https://github.com/apache/incubator-doris/pull/4371
> > >
> > >
> > >
> > > --
> > >
> > > 此致!Best Regards
> > > 陈明雨 Mingyu Chen
> > >
> > > Email:
> > > morningman@163.com;
> > > morningman.cmy@gmail.com
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: dev-unsubscribe@doris.apache.org
> > For additional commands, e-mail: dev-help@doris.apache.org
> >
> >

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@doris.apache.org
For additional commands, e-mail: dev-help@doris.apache.org


Re: [DISCUSS] Remove the DISCLAIMER-WIP

Posted by ling miao <li...@apache.org>.
Hi Willem,
Does this mean that mysql driver cannot exist in our docker image or binary
package?

Ling Miao

Willem Jiang <wi...@gmail.com> 于2020年8月19日周三 上午8:09写道:

> We need to check if the source kit has the third party dependency of
> GPL and LGPL code.
> We cannot ship the GPL and LGPL code with our source kit for the
> License compliance requirement.
>
>
> Willem Jiang
>
> Twitter: willemjiang
> Weibo: 姜宁willem
>
> On Mon, Aug 17, 2020 at 8:58 PM 陈明雨 <mo...@163.com> wrote:
> >
> > Our previous version still carries DISCLAIMER-WIP. Because there are
> still some problems in our current code
> >
> >
> >
> >
> > The main problem comes from two aspects:
> >
> >
> >
> > 1. MySQL library and LZO library
> >
> >
> >
> > The license of these two third-party dependent libraries is GPL and is
> incompatible with the Apache License.
> > Therefore we take the following measures:
> >
> >
> > For the MySQL library, we will replace it with UnixOBDC later. Currently
> we use compilation options to control.
> > And the default compilation option is OFF, that is, the MySQL dependent
> library is not used.
> >
> >
> >
> >
> > For LZO, it is currently only used to read some old version data. The
> new version of data reading and writing
> > are not using the LZO compression algorithm anymore. The data of the old
> version will be gradually converted
> > to the new version format
> > Similarly, currently we use compilation options to control. And the
> default compilation option is OFF.
> >
> >
> >
> >
> > These two libraries are expected to be completely eliminated in version
> 0.14.
> >
> >
> >
> >
> > 2. There are some compiled JS or CSS files in code repo.
> >
> >
> >
> >
> > The frontend code depends Bootstrap and jQuery. These dependencies have
> been changed to download from official channels,
> > and the source code of these dependencies has been removed from the
> Doris code base.
> >
> >
> >
> >
> > 3. The code without the license header and the third-party code without
> the license declaration
> >
> >
> >
> >
> > At present, all codes belonging to Doris have added a license header,
> including source code files, configuration files, document files, etc.
> > All codes from third parties are marked in the LICENSE file, and the
> license of these codes is guaranteed to be compatible with the apache
> license.
> >
> >
> > I have created an ISSUE[1] to tracker this. And also made a pull
> request[2] including all modification I mentioned above.
> >
> >
> > ------------------------------------------------
> > [1] https://github.com/apache/incubator-doris/issues/4372
> > [2] https://github.com/apache/incubator-doris/pull/4371
> >
> >
> >
> > --
> >
> > 此致!Best Regards
> > 陈明雨 Mingyu Chen
> >
> > Email:
> > morningman@163.com;
> > morningman.cmy@gmail.com
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@doris.apache.org
> For additional commands, e-mail: dev-help@doris.apache.org
>
>

Re: [DISCUSS] Remove the DISCLAIMER-WIP

Posted by Willem Jiang <wi...@gmail.com>.
We need to check if the source kit has the third party dependency of
GPL and LGPL code.
We cannot ship the GPL and LGPL code with our source kit for the
License compliance requirement.


Willem Jiang

Twitter: willemjiang
Weibo: 姜宁willem

On Mon, Aug 17, 2020 at 8:58 PM 陈明雨 <mo...@163.com> wrote:
>
> Our previous version still carries DISCLAIMER-WIP. Because there are still some problems in our current code
>
>
>
>
> The main problem comes from two aspects:
>
>
>
> 1. MySQL library and LZO library
>
>
>
> The license of these two third-party dependent libraries is GPL and is incompatible with the Apache License.
> Therefore we take the following measures:
>
>
> For the MySQL library, we will replace it with UnixOBDC later. Currently we use compilation options to control.
> And the default compilation option is OFF, that is, the MySQL dependent library is not used.
>
>
>
>
> For LZO, it is currently only used to read some old version data. The new version of data reading and writing
> are not using the LZO compression algorithm anymore. The data of the old version will be gradually converted
> to the new version format
> Similarly, currently we use compilation options to control. And the default compilation option is OFF.
>
>
>
>
> These two libraries are expected to be completely eliminated in version 0.14.
>
>
>
>
> 2. There are some compiled JS or CSS files in code repo.
>
>
>
>
> The frontend code depends Bootstrap and jQuery. These dependencies have been changed to download from official channels,
> and the source code of these dependencies has been removed from the Doris code base.
>
>
>
>
> 3. The code without the license header and the third-party code without the license declaration
>
>
>
>
> At present, all codes belonging to Doris have added a license header, including source code files, configuration files, document files, etc.
> All codes from third parties are marked in the LICENSE file, and the license of these codes is guaranteed to be compatible with the apache license.
>
>
> I have created an ISSUE[1] to tracker this. And also made a pull request[2] including all modification I mentioned above.
>
>
> ------------------------------------------------
> [1] https://github.com/apache/incubator-doris/issues/4372
> [2] https://github.com/apache/incubator-doris/pull/4371
>
>
>
> --
>
> 此致!Best Regards
> 陈明雨 Mingyu Chen
>
> Email:
> morningman@163.com;
> morningman.cmy@gmail.com

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@doris.apache.org
For additional commands, e-mail: dev-help@doris.apache.org


Re: [DISCUSS] Remove the DISCLAIMER-WIP

Posted by ling miao <li...@apache.org>.
Does this way of configuring the mysql driver to off when compiling meets
the license of apache?

Ling Miao

陈明雨 <mo...@163.com> 于2020年8月17日周一 下午8:58写道:

> Our previous version still carries DISCLAIMER-WIP. Because there are still
> some problems in our current code
>
>
>
>
> The main problem comes from two aspects:
>
>
>
> 1. MySQL library and LZO library
>
>
>
> The license of these two third-party dependent libraries is GPL and is
> incompatible with the Apache License.
> Therefore we take the following measures:
>
>
> For the MySQL library, we will replace it with UnixOBDC later. Currently
> we use compilation options to control.
> And the default compilation option is OFF, that is, the MySQL dependent
> library is not used.
>
>
>
>
> For LZO, it is currently only used to read some old version data. The new
> version of data reading and writing
> are not using the LZO compression algorithm anymore. The data of the old
> version will be gradually converted
> to the new version format
> Similarly, currently we use compilation options to control. And the
> default compilation option is OFF.
>
>
>
>
> These two libraries are expected to be completely eliminated in version
> 0.14.
>
>
>
>
> 2. There are some compiled JS or CSS files in code repo.
>
>
>
>
> The frontend code depends Bootstrap and jQuery. These dependencies have
> been changed to download from official channels,
> and the source code of these dependencies has been removed from the Doris
> code base.
>
>
>
>
> 3. The code without the license header and the third-party code without
> the license declaration
>
>
>
>
> At present, all codes belonging to Doris have added a license header,
> including source code files, configuration files, document files, etc.
> All codes from third parties are marked in the LICENSE file, and the
> license of these codes is guaranteed to be compatible with the apache
> license.
>
>
> I have created an ISSUE[1] to tracker this. And also made a pull
> request[2] including all modification I mentioned above.
>
>
> ------------------------------------------------
> [1] https://github.com/apache/incubator-doris/issues/4372
> [2] https://github.com/apache/incubator-doris/pull/4371
>
>
>
> --
>
> 此致!Best Regards
> 陈明雨 Mingyu Chen
>
> Email:
> morningman@163.com;
> morningman.cmy@gmail.com