You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@thrift.apache.org by "Simon Rupf (JIRA)" <ji...@apache.org> on 2014/11/14 17:05:33 UTC

[jira] [Commented] (THRIFT-1548) PHP TCompactProtocol always reads bools as false

    [ https://issues.apache.org/jira/browse/THRIFT-1548?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14212415#comment-14212415 ] 

Simon Rupf commented on THRIFT-1548:
------------------------------------

We have just encountered this issue in our company with one of our thrift APIs. The patch worked with the php libs from 0.9.2. Thank you very much!

Is there any way I could help to bring this patch into a future release?

> PHP TCompactProtocol always reads bools as false
> ------------------------------------------------
>
>                 Key: THRIFT-1548
>                 URL: https://issues.apache.org/jira/browse/THRIFT-1548
>             Project: Thrift
>          Issue Type: Bug
>          Components: PHP - Library
>    Affects Versions: 0.8
>            Reporter: Gregory Hart
>         Attachments: TCompactProtocol.php.patch
>
>
> In TCompactProtocol::readFieldBegin, $field_type should be compared to COMPACT_TRUE or COMPACT_FALSE before being converted to a TType. Otherwise, $field_type will be converted to TType::BOOL (0x02) and will always match COMPACT_FALSE (0x02).



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)