You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@nifi.apache.org by GitBox <gi...@apache.org> on 2021/07/07 17:39:15 UTC

[GitHub] [nifi] exceptionfactory commented on a change in pull request #5173: NIFI-8530: Improved DELETE handling in PutDatabaseRecord for non-nullable columns

exceptionfactory commented on a change in pull request #5173:
URL: https://github.com/apache/nifi/pull/5173#discussion_r665579697



##########
File path: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/PutDatabaseRecord.java
##########
@@ -697,6 +697,7 @@ private void executeDML(final ProcessContext context, final ProcessSession sessi
                     final RecordSchema recordSchema = currentRecord.getSchema();
                     final Map<String, ColumnDescription> columns = tableSchema.getColumns();
 
+                    int deleteIndex = 0;

Review comment:
       Is there a reason for introducing a special delete index as opposed to basing the parameter index off the current value of `i` in the loop?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org