You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by remibergsma <gi...@git.apache.org> on 2016/04/07 21:50:20 UTC
[GitHub] cloudstack pull request: Remove unused images
GitHub user remibergsma opened a pull request:
https://github.com/apache/cloudstack/pull/1475
Remove unused images
We really don't need this, do we?
Check your own cloud, it's there...
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/remibergsma/cloudstack 47_unused_image
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cloudstack/pull/1475.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1475
----
commit 3961ac24188a676482f75a71e1ba31e3f462481f
Author: Remi Bergsma <gi...@remi.nl>
Date: 2016-04-07T19:49:06Z
Remove unused images
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: Remove unused images
Posted by swill <gi...@git.apache.org>.
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1475#issuecomment-214505566
@remibergsma bump. :) just a friendly reminder. what should we do with this PR?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: Remove unused images
Posted by remibergsma <gi...@git.apache.org>.
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1475#issuecomment-207251541
Travis error is unrelated obviously:
```
No output has been received in the last 10m0s, this potentially indicates a stalled build or something wrong with the build itself.
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: Remove unused images
Posted by remibergsma <gi...@git.apache.org>.
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1475#issuecomment-209020597
@rafaelweingartner +1 to remove all that stuff
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: Remove unused images
Posted by DaanHoogland <gi...@git.apache.org>.
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1475#issuecomment-207355341
:) still cleaning, good job.
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: Remove unused images
Posted by remibergsma <gi...@git.apache.org>.
Github user remibergsma closed the pull request at:
https://github.com/apache/cloudstack/pull/1475
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: Remove unused images
Posted by rafaelweingartner <gi...@git.apache.org>.
Github user rafaelweingartner commented on the pull request:
https://github.com/apache/cloudstack/pull/1475#issuecomment-209077230
I have created a jira ticket for this.
https://issues.apache.org/jira/browse/CLOUDSTACK-9345
Maybe we could close this PR, and then next release we could work on this cleanup.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: Remove unused images
Posted by rafaelweingartner <gi...@git.apache.org>.
Github user rafaelweingartner commented on the pull request:
https://github.com/apache/cloudstack/pull/1475#issuecomment-208896922
Is that "wix-acs" maven task executed?
What does it build?
I noticed it has as an output a file called "acs.msi", what is it?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: Remove unused images
Posted by wido <gi...@git.apache.org>.
Github user wido commented on the pull request:
https://github.com/apache/cloudstack/pull/1475#issuecomment-208812036
Yes, seems rather stupid to keep those :)
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: Remove unused images
Posted by rafaelweingartner <gi...@git.apache.org>.
Github user rafaelweingartner commented on the pull request:
https://github.com/apache/cloudstack/pull/1475#issuecomment-208898455
you mean the ACS itself?
The whole ACS? For what I have seen of the code base, it does not seem to work in Windows environments.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: Remove unused images
Posted by DaanHoogland <gi...@git.apache.org>.
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1475#issuecomment-208897161
the windows install of acs
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: Remove unused images
Posted by swill <gi...@git.apache.org>.
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1475#issuecomment-208891268
Isn't there references to these files? Forget the ones in `target`, but the references in `cloudstack/scripts/installer/windows/client.wxs` should probably be addressed...
Thoughts?
```
Searching 15246 files for "sample-project-view.png"
cloudstack/client/target/cloud-client-ui-4.9.0-SNAPSHOT.war:
File too large, skipping
cloudstack/client/target/cloud-client-ui-4.9.0-SNAPSHOT/WEB-INF/classes/scripts/installer/windows/client.wxs:
170 </Component>
171 <Component Id="cmp6E186870ED4CF468177D7449592B651D" Guid="{1735AF1A-2962-4A6C-9103-A1B891920977}">
172: <File Id="filFC755B88B988B6799CCF3B813EFE8E8F" KeyPath="yes" Source="!(wix.SourceClient)\images\sample-project-view.png" />
173 </Component>
174 <Component Id="cmp1C89ADB77497A7903954C1555FE7D35D" Guid="{9795E109-A613-4891-A396-F6FCDA1121FA}">
cloudstack/client/target/generated-webapp/WEB-INF/classes/scripts/installer/windows/client.wxs:
170 </Component>
171 <Component Id="cmp6E186870ED4CF468177D7449592B651D" Guid="{1735AF1A-2962-4A6C-9103-A1B891920977}">
172: <File Id="filFC755B88B988B6799CCF3B813EFE8E8F" KeyPath="yes" Source="!(wix.SourceClient)\images\sample-project-view.png" />
173 </Component>
174 <Component Id="cmp1C89ADB77497A7903954C1555FE7D35D" Guid="{9795E109-A613-4891-A396-F6FCDA1121FA}">
cloudstack/scripts/installer/windows/client.wxs:
170 </Component>
171 <Component Id="cmp6E186870ED4CF468177D7449592B651D" Guid="{1735AF1A-2962-4A6C-9103-A1B891920977}">
172: <File Id="filFC755B88B988B6799CCF3B813EFE8E8F" KeyPath="yes" Source="!(wix.SourceClient)\images\sample-project-view.png" />
173 </Component>
174 <Component Id="cmp1C89ADB77497A7903954C1555FE7D35D" Guid="{9795E109-A613-4891-A396-F6FCDA1121FA}">
3 matches across 3 files
Searching 15246 files for "vm-instance-screen-sample.png"
cloudstack/client/target/cloud-client-ui-4.9.0-SNAPSHOT.war:
File too large, skipping
cloudstack/client/target/cloud-client-ui-4.9.0-SNAPSHOT/WEB-INF/classes/scripts/installer/windows/client.wxs:
176 </Component>
177 <Component Id="cmp033EEE431FC34259BCA1CE1B246E50F4" Guid="{FEF35205-58DB-42E6-9C9A-2C9CE2C46527}">
178: <File Id="filABF125D326B2B2880F897A3B8356A17C" KeyPath="yes" Source="!(wix.SourceClient)\images\vm-instance-screen-sample.png" />
179 </Component>
180 </Directory>
cloudstack/client/target/generated-webapp/WEB-INF/classes/scripts/installer/windows/client.wxs:
176 </Component>
177 <Component Id="cmp033EEE431FC34259BCA1CE1B246E50F4" Guid="{FEF35205-58DB-42E6-9C9A-2C9CE2C46527}">
178: <File Id="filABF125D326B2B2880F897A3B8356A17C" KeyPath="yes" Source="!(wix.SourceClient)\images\vm-instance-screen-sample.png" />
179 </Component>
180 </Directory>
cloudstack/scripts/installer/windows/client.wxs:
176 </Component>
177 <Component Id="cmp033EEE431FC34259BCA1CE1B246E50F4" Guid="{FEF35205-58DB-42E6-9C9A-2C9CE2C46527}">
178: <File Id="filABF125D326B2B2880F897A3B8356A17C" KeyPath="yes" Source="!(wix.SourceClient)\images\vm-instance-screen-sample.png" />
179 </Component>
180 </Directory>
3 matches across 3 files
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: Remove unused images
Posted by remibergsma <gi...@git.apache.org>.
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1475#issuecomment-208794882
@swill force pushed
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: Remove unused images
Posted by GabrielBrascher <gi...@git.apache.org>.
Github user GabrielBrascher commented on the pull request:
https://github.com/apache/cloudstack/pull/1475#issuecomment-207570464
Remove unused files is always good. LGTM.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: Remove unused images
Posted by rafaelweingartner <gi...@git.apache.org>.
Github user rafaelweingartner commented on the pull request:
https://github.com/apache/cloudstack/pull/1475#issuecomment-208903886
I also thought it was the HyperV agent; but, that agent is built in a different way. I was going over the files, and it seems that is used to build an installer to install ACS on Windows.
Has anyone ever used that? I doubt that it works today.
The image is being referenced there, but it does not seem to be used anywhere else. I would instead create a Jira ticket and then with time prepare a PR to remove everything that has to do with that whole “MSI” build.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: Remove unused images
Posted by swill <gi...@git.apache.org>.
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1475#issuecomment-211417769
@remibergsma how should we handle this PR now that we have found references to these files?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: Remove unused images
Posted by DaanHoogland <gi...@git.apache.org>.
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1475#issuecomment-208900500
might be just for the agent, I have never run it. I read about people running it on windows but back in the days when i did it is was on cygwin.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: Remove unused images
Posted by swill <gi...@git.apache.org>.
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1475#issuecomment-208591476
Can you either close and reopen or do a `push -f` to try to kick off travis. I am confident in this PR, but I want everything green before we merge... Thank you for the code reviews...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---