[jira] [Commented] (LUCENE-3202) Add DataInput/DataOutput subclasses that delegate to an InputStream/OutputStream.

["Shai Erera (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/LUCENE-3202?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13049138#comment-13049138 ] 

Shai Erera commented on LUCENE-3202:
------------------------------------

Patch looks good. Two comments:
# The files are missing the Apache License header.
# In some places you use this.is / this.out and others just is/out. Can you consolidate on one (I prefer w/o this.)?

> Add DataInput/DataOutput subclasses that delegate to an InputStream/OutputStream.
> ---------------------------------------------------------------------------------
>
>                 Key: LUCENE-3202
>                 URL: https://issues.apache.org/jira/browse/LUCENE-3202
>             Project: Lucene - Java
>          Issue Type: Task
>          Components: core/other
>            Reporter: Dawid Weiss
>            Assignee: Dawid Weiss
>            Priority: Trivial
>             Fix For: 3.3, 4.0
>
>         Attachments: LUCENE-3202.patch
>
>
> Such classes would be handy for FST serialization/deserialization.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org