You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@datafusion.apache.org by "findepi (via GitHub)" <gi...@apache.org> on 2024/07/25 18:42:07 UTC
[PR] Fix formatting errors reported by clippy [datafusion]
findepi opened a new pull request, #11654:
URL: https://github.com/apache/datafusion/pull/11654
Newest version of clippy complains when list item continuation is not indented.
For https://github.com/apache/datafusion/issues/11651
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] Fix formatting errors reported by clippy [datafusion]
Posted by "findepi (via GitHub)" <gi...@apache.org>.
findepi commented on PR #11654:
URL: https://github.com/apache/datafusion/pull/11654#issuecomment-2251238973
Cherry picked https://github.com/apache/datafusion/pull/11467 and rebased it on current main.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] Fix clippy errors for Rust 1.80 [datafusion]
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on code in PR #11654:
URL: https://github.com/apache/datafusion/pull/11654#discussion_r1692037984
##########
datafusion/sqllogictest/test_files/parquet.slt:
##########
@@ -251,25 +251,26 @@ SELECT COUNT(*) FROM timestamp_with_tz;
----
131072
+# FIXME(#TODO) fails with feature `force_hash_collisions`
Review Comment:
I think the concern on https://github.com/apache/datafusion/pull/11467 was that this masks a real bug.
However, what I think we should do is file a PR to investigate / restore the tests which I will do so shortly
##########
datafusion/physical-plan/src/joins/hash_join.rs:
##########
@@ -1985,6 +1988,8 @@ mod tests {
}
/// Test where the left has 2 parts, the right with 1 part => 1 part
+ // FIXME(#TODO) test fails with feature `force_hash_collisions`
+ #[cfg(not(feature = "force_hash_collisions"))]
Review Comment:
```suggestion
// https://github.com/apache/datafusion/issues/11658
#[cfg(not(feature = "force_hash_collisions"))]
```
##########
datafusion/sqllogictest/test_files/parquet.slt:
##########
@@ -251,25 +251,26 @@ SELECT COUNT(*) FROM timestamp_with_tz;
----
131072
+# FIXME(#TODO) fails with feature `force_hash_collisions`
Review Comment:
```suggestion
# FIXME(#TODO) fails with feature `force_hash_collisions`
# https://github.com/apache/datafusion/issues/11660
```
##########
datafusion/sqllogictest/test_files/sort_merge_join.slt:
##########
@@ -238,16 +238,17 @@ SELECT * FROM t1 FULL JOIN t2 ON t1_id = t2_id
44 d 4 44 x 3
NULL NULL NULL 55 w 3
+# FIXME(#TODO) fails with feature `force_hash_collisions`
Review Comment:
```suggestion
# FIXME(#TODO) fails with feature `force_hash_collisions`
# https://github.com/apache/datafusion/issues/11659
```
##########
datafusion/physical-plan/src/joins/hash_join.rs:
##########
@@ -2097,6 +2102,8 @@ mod tests {
}
/// Test where the left has 1 part, the right has 2 parts => 2 parts
+ // FIXME(#TODO) test fails with feature `force_hash_collisions`
Review Comment:
```suggestion
// FIXME(#TODO) test fails with feature `force_hash_collisions`
// https://github.com/apache/datafusion/issues/11658
```
##########
datafusion/physical-plan/src/joins/hash_join.rs:
##########
@@ -1930,6 +1931,8 @@ mod tests {
Ok(())
}
+ // FIXME(#TODO) test fails with feature `force_hash_collisions`
+ #[cfg(not(feature = "force_hash_collisions"))]
Review Comment:
```suggestion
// https://github.com/apache/datafusion/issues/11658
#[cfg(not(feature = "force_hash_collisions"))]
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] Fix clippy errors for Rust 1.80 [datafusion]
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb merged PR #11654:
URL: https://github.com/apache/datafusion/pull/11654
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] Fix clippy errors for Rust 1.80 [datafusion]
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on code in PR #11654:
URL: https://github.com/apache/datafusion/pull/11654#discussion_r1692061230
##########
datafusion/sqllogictest/test_files/parquet.slt:
##########
@@ -251,25 +251,26 @@ SELECT COUNT(*) FROM timestamp_with_tz;
----
131072
+# FIXME(#TODO) fails with feature `force_hash_collisions`
Review Comment:
in https://github.com/apache/datafusion/pull/11661
##########
datafusion/sqllogictest/test_files/sort_merge_join.slt:
##########
@@ -238,16 +238,17 @@ SELECT * FROM t1 FULL JOIN t2 ON t1_id = t2_id
44 d 4 44 x 3
NULL NULL NULL 55 w 3
+# FIXME(#TODO) fails with feature `force_hash_collisions`
Review Comment:
in https://github.com/apache/datafusion/pull/11661
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] Fix clippy errors for Rust 1.80 [datafusion]
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on code in PR #11654:
URL: https://github.com/apache/datafusion/pull/11654#discussion_r1692061450
##########
datafusion/physical-plan/src/joins/hash_join.rs:
##########
@@ -2097,6 +2102,8 @@ mod tests {
}
/// Test where the left has 1 part, the right has 2 parts => 2 parts
+ // FIXME(#TODO) test fails with feature `force_hash_collisions`
Review Comment:
in in https://github.com/apache/datafusion/pull/11661
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org