You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@santuario.apache.org by Eric Johnson <er...@tibco.com> on 2012/02/13 15:42:43 UTC
Source download - duplicated files
To whom it may concern,
I just downloaded the source zip for the latest Java Santuario release
(1.5.0), and noticed duplicated files in the source zip release, as well
as in the Subversion tags for the project.
Specifically:
This download:
https://archive.apache.org/dist/santuario/java-library/1_5_0/xml-security-src-1_5_0.zip
contains duplicates on the paths samples/data/org/w3c/www and
src/test/resources/org/w3c/www.
Looking via the web viewer of Subversion, I see similar duplication?
[Apache-SVN]
/santuario/xml-security-java/tags/1.5.0/samples/data/org/w3c/www
appears to be identical to:
[Apache-SVN]
/santuario/xml-security-java/tags/1.5.0/src/test/resources/org/w3c/www
Is this a mistake, or is this data intentionally duplicated?
-Eric Johnson
Re: Source download - duplicated files
Posted by Chad La Joie <la...@itumi.biz>.
My understanding was that one set of files was for the example code to
use, the other set of files was for testing. It's certainly not
unreasonable to believe that those two things would need to vary
independently. If one controlled the mechanics of the data storage
mechanism one might implement this with a copy-on-write mechanism but
I don't know that any source control system exposes something like
that as a high-level operation.
On Tue, Feb 14, 2012 at 09:02, Eric Johnson <er...@tibco.com> wrote:
>> I don't really see how it's risky? They're just resources for running
>> tests/samples.
>
> Duplicated files always make me nervous.
--
Chad La Joie
www.itumi.biz
trusted identities, delivered
Re: Source download - duplicated files
Posted by Eric Johnson <er...@tibco.com>.
Hi Colm,
On 2/14/12 3:02 PM, Colm O hEigeartaigh wrote:
> I don't really see how it's risky? They're just resources for running
> tests/samples.
Duplicated files always make me nervous. Just like copy & paste coding.
>
> In any case, I've removed a whole load of the duplicates in the
> samples directory, which are no longer used by the samples in 1.5.
Thanks!
-Eric.
>
> Colm.
>
> On Mon, Feb 13, 2012 at 7:39 PM, Eric Johnson<er...@tibco.com> wrote:
>> Hi Colm,
>>
>> OK, but at least one large set (the one I pointed to) is just a straight
>> duplicate. That seems risky.
>>
>> -Eric.
>>
>>
>> On 2/13/12 4:34 PM, Colm O hEigeartaigh wrote:
>>> In the 1.4.x series of releases, the "data" folder held both test and
>>> sample resources. As part of 1.5, I refactored "data" into
>>> "src/test/resources" for running tests, and put any resources used by
>>> the samples into "samples". That way the samples and tests are
>>> properly separated.
>>>
>>> Colm.
>>>
>>> On Mon, Feb 13, 2012 at 3:27 PM, Sean Mullan<se...@oracle.com>
>>> wrote:
>>>> On 02/13/2012 09:42 AM, Eric Johnson wrote:
>>>>> To whom it may concern,
>>>>>
>>>>> I just downloaded the source zip for the latest Java Santuario release
>>>>> (1.5.0), and noticed duplicated files in the source zip release, as well
>>>>> as in the Subversion tags for the project.
>>>>>
>>>>> Specifically:
>>>>>
>>>>> This download:
>>>>>
>>>>>
>>>>> https://archive.apache.org/dist/santuario/java-library/1_5_0/xml-security-src-1_5_0.zip
>>>>>
>>>>>
>>>>> contains duplicates on the paths samples/data/org/w3c/www and
>>>>> src/test/resources/org/w3c/www.
>>>>>
>>>>> Looking via the web viewer of Subversion, I see similar duplication?
>>>>>
>>>>> [Apache-SVN]
>>>>> /santuario/xml-security-java/tags/1.5.0/samples/data/org/w3c/www
>>>>>
>>>>> appears to be identical to:
>>>>>
>>>>> [Apache-SVN]
>>>>> /santuario/xml-security-java/tags/1.5.0/src/test/resources/org/w3c/www
>>>>>
>>>>> Is this a mistake, or is this data intentionally duplicated?
>>>>
>>>> I think it was intentional (looks like it was done as part of
>>>> Santuario-257), but should probably be fixed.
>>>>
>>>> Colm, any thoughts?
>>>>
>>>> --Sean
>>>
>>>
>
>
Re: Source download - duplicated files
Posted by Colm O hEigeartaigh <co...@apache.org>.
I don't really see how it's risky? They're just resources for running
tests/samples.
In any case, I've removed a whole load of the duplicates in the
samples directory, which are no longer used by the samples in 1.5.
Colm.
On Mon, Feb 13, 2012 at 7:39 PM, Eric Johnson <er...@tibco.com> wrote:
> Hi Colm,
>
> OK, but at least one large set (the one I pointed to) is just a straight
> duplicate. That seems risky.
>
> -Eric.
>
>
> On 2/13/12 4:34 PM, Colm O hEigeartaigh wrote:
>>
>> In the 1.4.x series of releases, the "data" folder held both test and
>> sample resources. As part of 1.5, I refactored "data" into
>> "src/test/resources" for running tests, and put any resources used by
>> the samples into "samples". That way the samples and tests are
>> properly separated.
>>
>> Colm.
>>
>> On Mon, Feb 13, 2012 at 3:27 PM, Sean Mullan<se...@oracle.com>
>> wrote:
>>>
>>> On 02/13/2012 09:42 AM, Eric Johnson wrote:
>>>>
>>>> To whom it may concern,
>>>>
>>>> I just downloaded the source zip for the latest Java Santuario release
>>>> (1.5.0), and noticed duplicated files in the source zip release, as well
>>>> as in the Subversion tags for the project.
>>>>
>>>> Specifically:
>>>>
>>>> This download:
>>>>
>>>>
>>>> https://archive.apache.org/dist/santuario/java-library/1_5_0/xml-security-src-1_5_0.zip
>>>>
>>>>
>>>> contains duplicates on the paths samples/data/org/w3c/www and
>>>> src/test/resources/org/w3c/www.
>>>>
>>>> Looking via the web viewer of Subversion, I see similar duplication?
>>>>
>>>> [Apache-SVN]
>>>> /santuario/xml-security-java/tags/1.5.0/samples/data/org/w3c/www
>>>>
>>>> appears to be identical to:
>>>>
>>>> [Apache-SVN]
>>>> /santuario/xml-security-java/tags/1.5.0/src/test/resources/org/w3c/www
>>>>
>>>> Is this a mistake, or is this data intentionally duplicated?
>>>
>>>
>>> I think it was intentional (looks like it was done as part of
>>> Santuario-257), but should probably be fixed.
>>>
>>> Colm, any thoughts?
>>>
>>> --Sean
>>
>>
>>
>
--
Colm O hEigeartaigh
Talend Community Coder
http://coders.talend.com
Re: Source download - duplicated files
Posted by Eric Johnson <er...@tibco.com>.
Hi Colm,
OK, but at least one large set (the one I pointed to) is just a straight
duplicate. That seems risky.
-Eric.
On 2/13/12 4:34 PM, Colm O hEigeartaigh wrote:
> In the 1.4.x series of releases, the "data" folder held both test and
> sample resources. As part of 1.5, I refactored "data" into
> "src/test/resources" for running tests, and put any resources used by
> the samples into "samples". That way the samples and tests are
> properly separated.
>
> Colm.
>
> On Mon, Feb 13, 2012 at 3:27 PM, Sean Mullan<se...@oracle.com> wrote:
>> On 02/13/2012 09:42 AM, Eric Johnson wrote:
>>> To whom it may concern,
>>>
>>> I just downloaded the source zip for the latest Java Santuario release
>>> (1.5.0), and noticed duplicated files in the source zip release, as well
>>> as in the Subversion tags for the project.
>>>
>>> Specifically:
>>>
>>> This download:
>>>
>>> https://archive.apache.org/dist/santuario/java-library/1_5_0/xml-security-src-1_5_0.zip
>>>
>>>
>>> contains duplicates on the paths samples/data/org/w3c/www and
>>> src/test/resources/org/w3c/www.
>>>
>>> Looking via the web viewer of Subversion, I see similar duplication?
>>>
>>> [Apache-SVN]
>>> /santuario/xml-security-java/tags/1.5.0/samples/data/org/w3c/www
>>>
>>> appears to be identical to:
>>>
>>> [Apache-SVN]
>>> /santuario/xml-security-java/tags/1.5.0/src/test/resources/org/w3c/www
>>>
>>> Is this a mistake, or is this data intentionally duplicated?
>>
>> I think it was intentional (looks like it was done as part of
>> Santuario-257), but should probably be fixed.
>>
>> Colm, any thoughts?
>>
>> --Sean
>
>
Re: Source download - duplicated files
Posted by Colm O hEigeartaigh <co...@apache.org>.
In the 1.4.x series of releases, the "data" folder held both test and
sample resources. As part of 1.5, I refactored "data" into
"src/test/resources" for running tests, and put any resources used by
the samples into "samples". That way the samples and tests are
properly separated.
Colm.
On Mon, Feb 13, 2012 at 3:27 PM, Sean Mullan <se...@oracle.com> wrote:
> On 02/13/2012 09:42 AM, Eric Johnson wrote:
>>
>> To whom it may concern,
>>
>> I just downloaded the source zip for the latest Java Santuario release
>> (1.5.0), and noticed duplicated files in the source zip release, as well
>> as in the Subversion tags for the project.
>>
>> Specifically:
>>
>> This download:
>>
>> https://archive.apache.org/dist/santuario/java-library/1_5_0/xml-security-src-1_5_0.zip
>>
>>
>> contains duplicates on the paths samples/data/org/w3c/www and
>> src/test/resources/org/w3c/www.
>>
>> Looking via the web viewer of Subversion, I see similar duplication?
>>
>> [Apache-SVN]
>> /santuario/xml-security-java/tags/1.5.0/samples/data/org/w3c/www
>>
>> appears to be identical to:
>>
>> [Apache-SVN]
>> /santuario/xml-security-java/tags/1.5.0/src/test/resources/org/w3c/www
>>
>> Is this a mistake, or is this data intentionally duplicated?
>
>
> I think it was intentional (looks like it was done as part of
> Santuario-257), but should probably be fixed.
>
> Colm, any thoughts?
>
> --Sean
--
Colm O hEigeartaigh
Talend Community Coder
http://coders.talend.com
Re: Source download - duplicated files
Posted by Sean Mullan <se...@oracle.com>.
On 02/13/2012 09:42 AM, Eric Johnson wrote:
> To whom it may concern,
>
> I just downloaded the source zip for the latest Java Santuario release
> (1.5.0), and noticed duplicated files in the source zip release, as well
> as in the Subversion tags for the project.
>
> Specifically:
>
> This download:
> https://archive.apache.org/dist/santuario/java-library/1_5_0/xml-security-src-1_5_0.zip
>
>
> contains duplicates on the paths samples/data/org/w3c/www and
> src/test/resources/org/w3c/www.
>
> Looking via the web viewer of Subversion, I see similar duplication?
>
> [Apache-SVN]
> /santuario/xml-security-java/tags/1.5.0/samples/data/org/w3c/www
>
> appears to be identical to:
>
> [Apache-SVN]
> /santuario/xml-security-java/tags/1.5.0/src/test/resources/org/w3c/www
>
> Is this a mistake, or is this data intentionally duplicated?
I think it was intentional (looks like it was done as part of
Santuario-257), but should probably be fixed.
Colm, any thoughts?
--Sean