You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@iceberg.apache.org by GitBox <gi...@apache.org> on 2019/08/07 07:17:57 UTC

[GitHub] [incubator-iceberg] jun-he commented on issue #357: Jun/in and not in predicates

jun-he commented on issue #357: Jun/in and not in predicates
URL: https://github.com/apache/incubator-iceberg/pull/357#issuecomment-518973038
 
 
   I took a different approach than the previous incomplete PR (Netflix/iceberg#81).
   Instead of adding `CollectionLiteral` and `CollectionPredicate` etc, I added a new `Set` field to `predicate` to support `in` and `notIn`.
   I think this approach is better than the previous one and the cost of adding an additional set field is quite low.
   
   @rdblue  Could you please have a look? Thank you.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org