You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by jd...@apache.org on 2011/04/23 09:55:56 UTC
svn commit: r1096119 [1/3] - in /wicket/trunk/wicket-core/src:
main/java/org/apache/wicket/ main/java/org/apache/wicket/ajax/
main/java/org/apache/wicket/ajax/calldecorator/
main/java/org/apache/wicket/markup/html/form/
main/java/org/apache/wicket/mark...
Author: jdonnerstag
Date: Sat Apr 23 07:55:49 2011
New Revision: 1096119
URL: http://svn.apache.org/viewvc?rev=1096119&view=rev
Log:
fixed: Remove many Eclipse warnings in wicket-core, wicket-util and wicket-request
Issue: WICKET-3624
Modified:
wicket/trunk/wicket-core/src/main/java/org/apache/wicket/ComponentEventSender.java
wicket/trunk/wicket-core/src/main/java/org/apache/wicket/ConverterLocator.java
wicket/trunk/wicket-core/src/main/java/org/apache/wicket/IConverterLocator.java
wicket/trunk/wicket-core/src/main/java/org/apache/wicket/IPageRendererProvider.java
wicket/trunk/wicket-core/src/main/java/org/apache/wicket/MetaDataKey.java
wicket/trunk/wicket-core/src/main/java/org/apache/wicket/Page.java
wicket/trunk/wicket-core/src/main/java/org/apache/wicket/RequestListenerInterface.java
wicket/trunk/wicket-core/src/main/java/org/apache/wicket/SharedResources.java
wicket/trunk/wicket-core/src/main/java/org/apache/wicket/SystemMapper.java
wicket/trunk/wicket-core/src/main/java/org/apache/wicket/ajax/IAjaxRegionMarkupIdProvider.java
wicket/trunk/wicket-core/src/main/java/org/apache/wicket/ajax/calldecorator/AjaxPostprocessingCallDecorator.java
wicket/trunk/wicket-core/src/main/java/org/apache/wicket/markup/html/form/CheckBox.java
wicket/trunk/wicket-core/src/main/java/org/apache/wicket/markup/html/form/CheckBoxMultipleChoice.java
wicket/trunk/wicket-core/src/main/java/org/apache/wicket/markup/html/form/ListMultipleChoice.java
wicket/trunk/wicket-core/src/main/java/org/apache/wicket/markup/html/form/RadioChoice.java
wicket/trunk/wicket-core/src/main/java/org/apache/wicket/markup/html/form/SubmitLink.java
wicket/trunk/wicket-core/src/main/java/org/apache/wicket/markup/html/form/validation/FormValidatorAdapter.java
wicket/trunk/wicket-core/src/main/java/org/apache/wicket/markup/html/image/resource/LocalizedImageResource.java
wicket/trunk/wicket-core/src/main/java/org/apache/wicket/markup/html/link/StatelessLink.java
wicket/trunk/wicket-core/src/main/java/org/apache/wicket/markup/html/list/PageableListView.java
wicket/trunk/wicket-core/src/main/java/org/apache/wicket/markup/repeater/data/EmptyDataProvider.java
wicket/trunk/wicket-core/src/main/java/org/apache/wicket/mock/MockApplication.java
wicket/trunk/wicket-core/src/main/java/org/apache/wicket/mock/MockPageManager.java
wicket/trunk/wicket-core/src/main/java/org/apache/wicket/mock/MockWebRequest.java
wicket/trunk/wicket-core/src/main/java/org/apache/wicket/mock/MockWebResponse.java
wicket/trunk/wicket-core/src/main/java/org/apache/wicket/page/CouldNotLockPageException.java
wicket/trunk/wicket-core/src/main/java/org/apache/wicket/page/IManageablePage.java
wicket/trunk/wicket-core/src/main/java/org/apache/wicket/pageStore/IDataStore.java
wicket/trunk/wicket-core/src/main/java/org/apache/wicket/protocol/http/BufferedHttpServletResponse.java
wicket/trunk/wicket-core/src/main/java/org/apache/wicket/protocol/http/RequestUtils.java
wicket/trunk/wicket-core/src/main/java/org/apache/wicket/protocol/http/mock/MockHttpServletRequest.java
wicket/trunk/wicket-core/src/main/java/org/apache/wicket/protocol/http/mock/MockHttpServletResponse.java
wicket/trunk/wicket-core/src/main/java/org/apache/wicket/protocol/http/servlet/ServletWebRequest.java
wicket/trunk/wicket-core/src/main/java/org/apache/wicket/request/component/IRequestableComponent.java
wicket/trunk/wicket-core/src/main/java/org/apache/wicket/request/handler/resource/ResourceStreamRequestHandler.java
wicket/trunk/wicket-core/src/main/java/org/apache/wicket/request/resource/DynamicImageResource.java
wicket/trunk/wicket-core/src/main/java/org/apache/wicket/request/resource/JavaScriptResourceReference.java
wicket/trunk/wicket-core/src/main/java/org/apache/wicket/request/resource/PackageResourceReference.java
wicket/trunk/wicket-core/src/main/java/org/apache/wicket/request/resource/ResourceStreamResource.java
wicket/trunk/wicket-core/src/main/java/org/apache/wicket/request/resource/SharedResourceReference.java
wicket/trunk/wicket-core/src/main/java/org/apache/wicket/resource/ResourceUtil.java
wicket/trunk/wicket-core/src/main/java/org/apache/wicket/resource/dependencies/ResourceDependentResourceReference.java
wicket/trunk/wicket-core/src/main/java/org/apache/wicket/util/lang/PropertyResolver.java
wicket/trunk/wicket-core/src/main/java/org/apache/wicket/util/tester/WicketTesterHelper.java
wicket/trunk/wicket-core/src/test/java/org/apache/wicket/BehaviorRequestTest.java
wicket/trunk/wicket-core/src/test/java/org/apache/wicket/BehaviorUrlTest.java
wicket/trunk/wicket-core/src/test/java/org/apache/wicket/ComponentWithLazyModelCreationTest.java
wicket/trunk/wicket-core/src/test/java/org/apache/wicket/ajax/AjaxBehaviorAndMetaDataPage.java
wicket/trunk/wicket-core/src/test/java/org/apache/wicket/ajax/AjaxBehaviorAndMetaDataTest.java
wicket/trunk/wicket-core/src/test/java/org/apache/wicket/ajax/AjaxHeaderContributionTest.java
wicket/trunk/wicket-core/src/test/java/org/apache/wicket/ajax/DomReadyOrderPage.java
wicket/trunk/wicket-core/src/test/java/org/apache/wicket/ajax/form/AjaxFormSubmitBehaviorTest.java
wicket/trunk/wicket-core/src/test/java/org/apache/wicket/ajax/form/AjaxFormSubmitBehaviorTestPage.java
wicket/trunk/wicket-core/src/test/java/org/apache/wicket/ajax/form/AjaxFormSubmitTestPage.java
wicket/trunk/wicket-core/src/test/java/org/apache/wicket/ajax/form/OnChangeAjaxBehaviorTestPage.java
wicket/trunk/wicket-core/src/test/java/org/apache/wicket/markup/html/basic/SimpleResponsePageClass.java
wicket/trunk/wicket-core/src/test/java/org/apache/wicket/markup/html/basic/SimpleResponsePageClassTest.java
wicket/trunk/wicket-core/src/test/java/org/apache/wicket/markup/html/border/ComponentBorderTest.java
wicket/trunk/wicket-core/src/test/java/org/apache/wicket/markup/html/border/FormBorder.java
wicket/trunk/wicket-core/src/test/java/org/apache/wicket/markup/html/form/AbstractTextComponentConvertEmptyStringsToNullTest.java
wicket/trunk/wicket-core/src/test/java/org/apache/wicket/markup/html/form/CheckGroupTestPage1.java
wicket/trunk/wicket-core/src/test/java/org/apache/wicket/markup/html/form/FormHasErrorPage.java
wicket/trunk/wicket-core/src/test/java/org/apache/wicket/markup/html/form/FormMethodTestPage.java
wicket/trunk/wicket-core/src/test/java/org/apache/wicket/markup/html/form/FormTest.java
wicket/trunk/wicket-core/src/test/java/org/apache/wicket/markup/html/form/FormWithMultipleButtonsTest.java
wicket/trunk/wicket-core/src/test/java/org/apache/wicket/markup/html/form/LocalizedMessagePage.java
wicket/trunk/wicket-core/src/test/java/org/apache/wicket/markup/html/form/RadioGroupTestPage3.java
wicket/trunk/wicket-core/src/test/java/org/apache/wicket/markup/html/form/ValidatorPropertiesTest.java
wicket/trunk/wicket-core/src/test/java/org/apache/wicket/markup/html/form/border/CommonModelPage.java
wicket/trunk/wicket-core/src/test/java/org/apache/wicket/markup/html/form/submitlink/HomePage.java
wicket/trunk/wicket-core/src/test/java/org/apache/wicket/markup/html/form/upload/MockPageWithFormAndUploadField.java
wicket/trunk/wicket-core/src/test/java/org/apache/wicket/markup/html/form/validation/FormValidatorBehaviorTest.java
wicket/trunk/wicket-core/src/test/java/org/apache/wicket/markup/html/form/validation/HomePage.java
wicket/trunk/wicket-core/src/test/java/org/apache/wicket/markup/html/form/validation/innerfeedback/BasePage.java
wicket/trunk/wicket-core/src/test/java/org/apache/wicket/markup/html/image/AjaxyImagesPage.java
wicket/trunk/wicket-core/src/test/java/org/apache/wicket/markup/html/internal/AjaxEnclosurePage_1.java
wicket/trunk/wicket-core/src/test/java/org/apache/wicket/markup/html/internal/AjaxEnclosurePage_2.java
wicket/trunk/wicket-core/src/test/java/org/apache/wicket/markup/html/internal/AjaxEnclosurePage_3.java
wicket/trunk/wicket-core/src/test/java/org/apache/wicket/markup/html/internal/EnclosurePage_3.java
wicket/trunk/wicket-core/src/test/java/org/apache/wicket/markup/html/internal/EnclosurePage_6.java
wicket/trunk/wicket-core/src/test/java/org/apache/wicket/markup/html/internal/EnclosurePage_7.java
wicket/trunk/wicket-core/src/test/java/org/apache/wicket/markup/html/internal/EnclosurePage_8.java
wicket/trunk/wicket-core/src/test/java/org/apache/wicket/markup/html/internal/InlineEnclosureAjaxPage.java
wicket/trunk/wicket-core/src/test/java/org/apache/wicket/markup/html/internal/InlineEnclosurePage_1.java
wicket/trunk/wicket-core/src/test/java/org/apache/wicket/markup/html/internal/InlineEnclosurePage_2.java
wicket/trunk/wicket-core/src/test/java/org/apache/wicket/markup/html/internal/InlineEnclosureWithAdditionalAjaxTargetPage.java
wicket/trunk/wicket-core/src/test/java/org/apache/wicket/markup/html/internal/TraditionalEnclosureAjaxPage.java
wicket/trunk/wicket-core/src/test/java/org/apache/wicket/markup/html/link/AbstractLinkTest.java
wicket/trunk/wicket-core/src/test/java/org/apache/wicket/markup/html/link/submitLink/FormPage.java
wicket/trunk/wicket-core/src/test/java/org/apache/wicket/markup/html/link/submitLink/FormPage2.java
wicket/trunk/wicket-core/src/test/java/org/apache/wicket/markup/html/list/IncrementalTableNavigationPage.java
wicket/trunk/wicket-core/src/test/java/org/apache/wicket/markup/html/list/IncrementalTableNavigationTest.java
wicket/trunk/wicket-core/src/test/java/org/apache/wicket/markup/html/list/PagedTableNavigatorPage.java
wicket/trunk/wicket-core/src/test/java/org/apache/wicket/markup/html/list/PagedTableNavigatorTest.java
wicket/trunk/wicket-core/src/test/java/org/apache/wicket/markup/html/list/PagedTableNavigatorWithLabelProviderPage.java
wicket/trunk/wicket-core/src/test/java/org/apache/wicket/markup/html/list/PagedTableNavigatorWithLabelProviderTest.java
wicket/trunk/wicket-core/src/test/java/org/apache/wicket/markup/html/list/PagedTableNavigatorWithMarginPage.java
wicket/trunk/wicket-core/src/test/java/org/apache/wicket/markup/html/list/PagedTableNavigatorWithMarginTest.java
wicket/trunk/wicket-core/src/test/java/org/apache/wicket/markup/html/list/PagedTablePage.java
wicket/trunk/wicket-core/src/test/java/org/apache/wicket/markup/html/list/SimpleTablePage_1.java
wicket/trunk/wicket-core/src/test/java/org/apache/wicket/markup/html/list/SimpleTablePage_2.java
wicket/trunk/wicket-core/src/test/java/org/apache/wicket/markup/html/list/SimpleTableTest.java
wicket/trunk/wicket-core/src/test/java/org/apache/wicket/markup/html/tags/InputTagNotVisibleWebPage.java
wicket/trunk/wicket-core/src/test/java/org/apache/wicket/markup/html/tags/InputTagVisibleWebPage.java
wicket/trunk/wicket-core/src/test/java/org/apache/wicket/markup/parser/SignInPanel.java
wicket/trunk/wicket-core/src/test/java/org/apache/wicket/model/AbstractPropertyModelObjectClassTest.java
wicket/trunk/wicket-core/src/test/java/org/apache/wicket/properties/MyApplication.java
wicket/trunk/wicket-core/src/test/java/org/apache/wicket/properties/MyTesterApplication.java
wicket/trunk/wicket-core/src/test/java/org/apache/wicket/properties/TestForm.java
wicket/trunk/wicket-core/src/test/java/org/apache/wicket/properties/TestPage.java
wicket/trunk/wicket-core/src/test/java/org/apache/wicket/protocol/http/WebResponseExceptionsTest.java
wicket/trunk/wicket-core/src/test/java/org/apache/wicket/protocol/http/request/HomePage.java
wicket/trunk/wicket-core/src/test/java/org/apache/wicket/redirect/abort/AbortExceptionPage.java
wicket/trunk/wicket-core/src/test/java/org/apache/wicket/request/mapper/BasicResourceReferenceMapperTest.java
wicket/trunk/wicket-core/src/test/java/org/apache/wicket/resource/DummyApplication.java
wicket/trunk/wicket-core/src/test/java/org/apache/wicket/resource/PageWithXmlProperties.java
wicket/trunk/wicket-core/src/test/java/org/apache/wicket/resource/loader/ClassStringResourceLoaderTest.java
wicket/trunk/wicket-core/src/test/java/org/apache/wicket/response/filter/ResponseFilterTest.java
wicket/trunk/wicket-core/src/test/java/org/apache/wicket/session/DefaultPageFactoryTest.java
wicket/trunk/wicket-core/src/test/java/org/apache/wicket/stateless/pages/HomePage.java
wicket/trunk/wicket-core/src/test/java/org/apache/wicket/stateless/pages/LoginPage.java
wicket/trunk/wicket-core/src/test/java/org/apache/wicket/stateless/pages/Page1.java
wicket/trunk/wicket-core/src/test/java/org/apache/wicket/stateless/pages/Page2.java
wicket/trunk/wicket-core/src/test/java/org/apache/wicket/stateless/pages/StatelessFormTest.java
wicket/trunk/wicket-core/src/test/java/org/apache/wicket/stateless/pages/UsernamePasswordSignInPanel.java
wicket/trunk/wicket-core/src/test/java/org/apache/wicket/util/ExceptionTestBase.java
wicket/trunk/wicket-core/src/test/java/org/apache/wicket/util/collections/MicroMapTest.java
wicket/trunk/wicket-core/src/test/java/org/apache/wicket/util/collections/MiniMapTest.java
wicket/trunk/wicket-core/src/test/java/org/apache/wicket/util/io/PageA.java
wicket/trunk/wicket-core/src/test/java/org/apache/wicket/util/io/PageB.java
wicket/trunk/wicket-core/src/test/java/org/apache/wicket/util/io/WicketOutputStreamTest.java
wicket/trunk/wicket-core/src/test/java/org/apache/wicket/util/lang/Country2.java
wicket/trunk/wicket-core/src/test/java/org/apache/wicket/util/lang/Person.java
wicket/trunk/wicket-core/src/test/java/org/apache/wicket/util/lang/PropertyResolverTest.java
wicket/trunk/wicket-core/src/test/java/org/apache/wicket/util/string/JavaScriptStripperTest.java
wicket/trunk/wicket-core/src/test/java/org/apache/wicket/util/string/StringListTest.java
wicket/trunk/wicket-core/src/test/java/org/apache/wicket/util/string/UrlUtilsTest.java
wicket/trunk/wicket-core/src/test/java/org/apache/wicket/util/string/interpolator/VariableInterpolatorTest.java
wicket/trunk/wicket-core/src/test/java/org/apache/wicket/util/tester/FormTesterTest.java
wicket/trunk/wicket-core/src/test/java/org/apache/wicket/util/tester/MockAjaxFormPage.java
wicket/trunk/wicket-core/src/test/java/org/apache/wicket/util/tester/MockFormFileUploadPage.java
wicket/trunk/wicket-core/src/test/java/org/apache/wicket/util/tester/MockPageWithLinkAndLabel.java
wicket/trunk/wicket-core/src/test/java/org/apache/wicket/util/tester/MockResourceLinkPage.java
wicket/trunk/wicket-core/src/test/java/org/apache/wicket/util/tester/WicketTesterSessionCreationTest.java
wicket/trunk/wicket-core/src/test/java/org/apache/wicket/util/tester/WicketTesterSessionInvalidateTest.java
wicket/trunk/wicket-core/src/test/java/org/apache/wicket/util/tester/apps_1/ViewBook.java
wicket/trunk/wicket-core/src/test/java/org/apache/wicket/util/tester/apps_3/FormTesterTest.java
wicket/trunk/wicket-core/src/test/java/org/apache/wicket/util/tester/apps_4/EmailPage.java
wicket/trunk/wicket-core/src/test/java/org/apache/wicket/util/tester/apps_6/LinkPage.java
wicket/trunk/wicket-core/src/test/java/org/apache/wicket/util/tester/apps_6/ResultPage.java
wicket/trunk/wicket-core/src/test/java/org/apache/wicket/util/tester/apps_7/TestHomePage.java
wicket/trunk/wicket-core/src/test/java/org/apache/wicket/util/value/ValueMapTest.java
wicket/trunk/wicket-core/src/test/java/org/apache/wicket/validation/ValidatorBehaviorTest.java
wicket/trunk/wicket-core/src/test/java/org/apache/wicket/validation/validator/CreditCardValidatorTest.java
wicket/trunk/wicket-core/src/test/java/org/apache/wicket/validation/validator/UrlValidatorTest.java
wicket/trunk/wicket-core/src/test/java/org/apache/wicket/versioning/InMemoryPageStore.java
wicket/trunk/wicket-core/src/test/java/org/apache/wicket/versioning/PageVersioningTest.java
Modified: wicket/trunk/wicket-core/src/main/java/org/apache/wicket/ComponentEventSender.java
URL: http://svn.apache.org/viewvc/wicket/trunk/wicket-core/src/main/java/org/apache/wicket/ComponentEventSender.java?rev=1096119&r1=1096118&r2=1096119&view=diff
==============================================================================
--- wicket/trunk/wicket-core/src/main/java/org/apache/wicket/ComponentEventSender.java (original)
+++ wicket/trunk/wicket-core/src/main/java/org/apache/wicket/ComponentEventSender.java Sat Apr 23 07:55:49 2011
@@ -267,6 +267,8 @@ final class ComponentEventSender impleme
*
* @param event
* event to send
+ * @param dispatcher
+ * event dispatcher
*/
private ComponentEventVisitor(ComponentEvent<?> event, IEventDispatcher dispatcher)
{
Modified: wicket/trunk/wicket-core/src/main/java/org/apache/wicket/ConverterLocator.java
URL: http://svn.apache.org/viewvc/wicket/trunk/wicket-core/src/main/java/org/apache/wicket/ConverterLocator.java?rev=1096119&r1=1096118&r2=1096119&view=diff
==============================================================================
--- wicket/trunk/wicket-core/src/main/java/org/apache/wicket/ConverterLocator.java (original)
+++ wicket/trunk/wicket-core/src/main/java/org/apache/wicket/ConverterLocator.java Sat Apr 23 07:55:49 2011
@@ -55,6 +55,9 @@ public class ConverterLocator implements
{
/**
* CoverterLocator that is to be used when no registered converter is found.
+ *
+ * @param <C>
+ * The object to convert from and to String
*/
private static class DefaultConverter<C> implements IConverter<C>
{
@@ -173,6 +176,8 @@ public class ConverterLocator implements
/**
* Gets the type converter that is registered for class c.
*
+ * @param <C>
+ * The object to convert from and to String
* @param c
* The class to get the type converter for
* @return The type converter that is registered for class c or null if no type converter was
@@ -180,7 +185,9 @@ public class ConverterLocator implements
*/
public final <C> IConverter<C> get(Class<C> c)
{
- return (IConverter<C>)classToConverter.get(c.getName());
+ @SuppressWarnings("unchecked")
+ IConverter<C> converter = (IConverter<C>)classToConverter.get(c.getName());
+ return converter;
}
/**
@@ -198,7 +205,9 @@ public class ConverterLocator implements
// Null is always converted to null
if (type == null)
{
- return (IConverter<C>)new DefaultConverter<String>(String.class);
+ @SuppressWarnings("unchecked")
+ IConverter<C> converter = (IConverter<C>)new DefaultConverter<String>(String.class);
+ return converter;
}
// Get type converter for class
Modified: wicket/trunk/wicket-core/src/main/java/org/apache/wicket/IConverterLocator.java
URL: http://svn.apache.org/viewvc/wicket/trunk/wicket-core/src/main/java/org/apache/wicket/IConverterLocator.java?rev=1096119&r1=1096118&r2=1096119&view=diff
==============================================================================
--- wicket/trunk/wicket-core/src/main/java/org/apache/wicket/IConverterLocator.java (original)
+++ wicket/trunk/wicket-core/src/main/java/org/apache/wicket/IConverterLocator.java Sat Apr 23 07:55:49 2011
@@ -25,17 +25,18 @@ import org.apache.wicket.util.convert.IC
* {@link Application#newConverterLocator()}.
*
* @see ConverterLocator
- *
+ *
* @author jcompagner
*
* The converter object type
*/
public interface IConverterLocator extends IClusterable
{
-
/**
* Returns the Converter for the class that is given.
*
+ * @param <C>
+ * The object to convert from and to String
* @param type
* @return The converter for the given type.
*/
Modified: wicket/trunk/wicket-core/src/main/java/org/apache/wicket/IPageRendererProvider.java
URL: http://svn.apache.org/viewvc/wicket/trunk/wicket-core/src/main/java/org/apache/wicket/IPageRendererProvider.java?rev=1096119&r1=1096118&r2=1096119&view=diff
==============================================================================
--- wicket/trunk/wicket-core/src/main/java/org/apache/wicket/IPageRendererProvider.java (original)
+++ wicket/trunk/wicket-core/src/main/java/org/apache/wicket/IPageRendererProvider.java Sat Apr 23 07:55:49 2011
@@ -20,6 +20,9 @@ import org.apache.wicket.request.handler
import org.apache.wicket.request.handler.render.PageRenderer;
import org.apache.wicket.util.IContextProvider;
+/**
+ * Interface for {@link IContextProvider}<PageRenderer, RenderPageRequestHandler>
+ */
public interface IPageRendererProvider
extends
IContextProvider<PageRenderer, RenderPageRequestHandler>
Modified: wicket/trunk/wicket-core/src/main/java/org/apache/wicket/MetaDataKey.java
URL: http://svn.apache.org/viewvc/wicket/trunk/wicket-core/src/main/java/org/apache/wicket/MetaDataKey.java?rev=1096119&r1=1096118&r2=1096119&view=diff
==============================================================================
--- wicket/trunk/wicket-core/src/main/java/org/apache/wicket/MetaDataKey.java (original)
+++ wicket/trunk/wicket-core/src/main/java/org/apache/wicket/MetaDataKey.java Sat Apr 23 07:55:49 2011
@@ -62,11 +62,11 @@ public abstract class MetaDataKey<T> imp
* @return The entry value
*/
@SuppressWarnings("unchecked")
- public T get(MetaDataEntry[] metaData)
+ public T get(MetaDataEntry<?>[] metaData)
{
if (metaData != null)
{
- for (MetaDataEntry entry : metaData)
+ for (MetaDataEntry<?> entry : metaData)
{
if (equals(entry.key))
{
Modified: wicket/trunk/wicket-core/src/main/java/org/apache/wicket/Page.java
URL: http://svn.apache.org/viewvc/wicket/trunk/wicket-core/src/main/java/org/apache/wicket/Page.java?rev=1096119&r1=1096118&r2=1096119&view=diff
==============================================================================
--- wicket/trunk/wicket-core/src/main/java/org/apache/wicket/Page.java (original)
+++ wicket/trunk/wicket-core/src/main/java/org/apache/wicket/Page.java Sat Apr 23 07:55:49 2011
@@ -1088,7 +1088,11 @@ public abstract class Page extends Marku
return renderCount;
}
- /** TODO WICKET-NG javadoc */
+ /**
+ * TODO WICKET-NG javadoc
+ *
+ * @param wasCreatedBookmarkable
+ */
public final void setWasCreatedBookmarkable(boolean wasCreatedBookmarkable)
{
setFlag(FLAG_WAS_CREATED_BOOKMARKABLE, wasCreatedBookmarkable);
Modified: wicket/trunk/wicket-core/src/main/java/org/apache/wicket/RequestListenerInterface.java
URL: http://svn.apache.org/viewvc/wicket/trunk/wicket-core/src/main/java/org/apache/wicket/RequestListenerInterface.java?rev=1096119&r1=1096118&r2=1096119&view=diff
==============================================================================
--- wicket/trunk/wicket-core/src/main/java/org/apache/wicket/RequestListenerInterface.java (original)
+++ wicket/trunk/wicket-core/src/main/java/org/apache/wicket/RequestListenerInterface.java Sat Apr 23 07:55:49 2011
@@ -130,6 +130,9 @@ public class RequestListenerInterface
}
+ /**
+ * @return The interface class, which must extend IRequestListener.
+ */
public Class<? extends IRequestListener> getListenerInterfaceClass()
{
return listenerInterfaceClass;
Modified: wicket/trunk/wicket-core/src/main/java/org/apache/wicket/SharedResources.java
URL: http://svn.apache.org/viewvc/wicket/trunk/wicket-core/src/main/java/org/apache/wicket/SharedResources.java?rev=1096119&r1=1096118&r2=1096119&view=diff
==============================================================================
--- wicket/trunk/wicket-core/src/main/java/org/apache/wicket/SharedResources.java (original)
+++ wicket/trunk/wicket-core/src/main/java/org/apache/wicket/SharedResources.java Sat Apr 23 07:55:49 2011
@@ -22,10 +22,18 @@ import org.apache.wicket.request.resourc
import org.apache.wicket.request.resource.ResourceReference;
import org.apache.wicket.request.resource.ResourceReferenceRegistry;
+/**
+ * TODO javadoc
+ */
public class SharedResources
{
private final ResourceReferenceRegistry registry;
+ /**
+ * Construct.
+ *
+ * @param registry
+ */
public SharedResources(ResourceReferenceRegistry registry)
{
this.registry = registry;
Modified: wicket/trunk/wicket-core/src/main/java/org/apache/wicket/SystemMapper.java
URL: http://svn.apache.org/viewvc/wicket/trunk/wicket-core/src/main/java/org/apache/wicket/SystemMapper.java?rev=1096119&r1=1096118&r2=1096119&view=diff
==============================================================================
--- wicket/trunk/wicket-core/src/main/java/org/apache/wicket/SystemMapper.java (original)
+++ wicket/trunk/wicket-core/src/main/java/org/apache/wicket/SystemMapper.java Sat Apr 23 07:55:49 2011
@@ -95,8 +95,9 @@ public class SystemMapper extends Compou
@Override
public Class<C> get()
{
- return (Class<C>)application.getHomePage();
+ @SuppressWarnings("unchecked")
+ Class<C> homePage = (Class<C>)application.getHomePage();
+ return homePage;
}
-
}
}
Modified: wicket/trunk/wicket-core/src/main/java/org/apache/wicket/ajax/IAjaxRegionMarkupIdProvider.java
URL: http://svn.apache.org/viewvc/wicket/trunk/wicket-core/src/main/java/org/apache/wicket/ajax/IAjaxRegionMarkupIdProvider.java?rev=1096119&r1=1096118&r2=1096119&view=diff
==============================================================================
--- wicket/trunk/wicket-core/src/main/java/org/apache/wicket/ajax/IAjaxRegionMarkupIdProvider.java (original)
+++ wicket/trunk/wicket-core/src/main/java/org/apache/wicket/ajax/IAjaxRegionMarkupIdProvider.java Sat Apr 23 07:55:49 2011
@@ -93,5 +93,9 @@ import org.apache.wicket.markup.html.for
*/
public interface IAjaxRegionMarkupIdProvider
{
+ /**
+ * @param component
+ * @return the id of the markup region that will be updated via ajax.
+ */
String getAjaxRegionMarkupId(Component component);
}
Modified: wicket/trunk/wicket-core/src/main/java/org/apache/wicket/ajax/calldecorator/AjaxPostprocessingCallDecorator.java
URL: http://svn.apache.org/viewvc/wicket/trunk/wicket-core/src/main/java/org/apache/wicket/ajax/calldecorator/AjaxPostprocessingCallDecorator.java?rev=1096119&r1=1096118&r2=1096119&view=diff
==============================================================================
--- wicket/trunk/wicket-core/src/main/java/org/apache/wicket/ajax/calldecorator/AjaxPostprocessingCallDecorator.java (original)
+++ wicket/trunk/wicket-core/src/main/java/org/apache/wicket/ajax/calldecorator/AjaxPostprocessingCallDecorator.java Sat Apr 23 07:55:49 2011
@@ -76,6 +76,7 @@ public abstract class AjaxPostprocessing
/**
* Decorates ajax call script
*
+ * @param component
* @param script
* @return decorated script
*/
@@ -87,6 +88,7 @@ public abstract class AjaxPostprocessing
/**
* Decorates the success handling script
*
+ * @param component
* @param script
* @return decorated script
*/
@@ -98,6 +100,7 @@ public abstract class AjaxPostprocessing
/**
* Decorates the failure handling script
*
+ * @param component
* @param script
* @return decorated script
*/
@@ -105,6 +108,4 @@ public abstract class AjaxPostprocessing
{
return script;
}
-
-
}
Modified: wicket/trunk/wicket-core/src/main/java/org/apache/wicket/markup/html/form/CheckBox.java
URL: http://svn.apache.org/viewvc/wicket/trunk/wicket-core/src/main/java/org/apache/wicket/markup/html/form/CheckBox.java?rev=1096119&r1=1096118&r2=1096119&view=diff
==============================================================================
--- wicket/trunk/wicket-core/src/main/java/org/apache/wicket/markup/html/form/CheckBox.java (original)
+++ wicket/trunk/wicket-core/src/main/java/org/apache/wicket/markup/html/form/CheckBox.java Sat Apr 23 07:55:49 2011
@@ -187,7 +187,9 @@ public class CheckBox extends FormCompon
{
if (Boolean.class.equals(type))
{
- return (IConverter<C>)CheckBoxConverter.INSTANCE;
+ @SuppressWarnings("unchecked")
+ IConverter<C> converter = (IConverter<C>)CheckBoxConverter.INSTANCE;
+ return converter;
}
else
{
Modified: wicket/trunk/wicket-core/src/main/java/org/apache/wicket/markup/html/form/CheckBoxMultipleChoice.java
URL: http://svn.apache.org/viewvc/wicket/trunk/wicket-core/src/main/java/org/apache/wicket/markup/html/form/CheckBoxMultipleChoice.java?rev=1096119&r1=1096118&r2=1096119&view=diff
==============================================================================
--- wicket/trunk/wicket-core/src/main/java/org/apache/wicket/markup/html/form/CheckBoxMultipleChoice.java (original)
+++ wicket/trunk/wicket-core/src/main/java/org/apache/wicket/markup/html/form/CheckBoxMultipleChoice.java Sat Apr 23 07:55:49 2011
@@ -333,6 +333,7 @@ public class CheckBoxMultipleChoice<T> e
* @param selected
* The currently selected string value
*/
+ @SuppressWarnings("unchecked")
@Override
protected void appendOptionHtml(final AppendingStringBuffer buffer, final T choice, int index,
final String selected)
@@ -343,6 +344,7 @@ public class CheckBoxMultipleChoice<T> e
String label = "";
if (objectClass != null && objectClass != String.class)
{
+ @SuppressWarnings("rawtypes")
IConverter converter = getConverter(objectClass);
label = converter.convertToString(displayValue, getLocale());
}
Modified: wicket/trunk/wicket-core/src/main/java/org/apache/wicket/markup/html/form/ListMultipleChoice.java
URL: http://svn.apache.org/viewvc/wicket/trunk/wicket-core/src/main/java/org/apache/wicket/markup/html/form/ListMultipleChoice.java?rev=1096119&r1=1096118&r2=1096119&view=diff
==============================================================================
--- wicket/trunk/wicket-core/src/main/java/org/apache/wicket/markup/html/form/ListMultipleChoice.java (original)
+++ wicket/trunk/wicket-core/src/main/java/org/apache/wicket/markup/html/form/ListMultipleChoice.java Sat Apr 23 07:55:49 2011
@@ -128,7 +128,12 @@ public class ListMultipleChoice<T> exten
/**
* @see org.apache.wicket.markup.html.form.AbstractChoice#AbstractChoice(String, IModel, List)
+ *
+ * @param id
+ * @param object
+ * @param choices
*/
+ @SuppressWarnings("unchecked")
public ListMultipleChoice(final String id, IModel<? extends Collection<T>> object,
final List<? extends T> choices)
{
@@ -138,7 +143,13 @@ public class ListMultipleChoice<T> exten
/**
* @see org.apache.wicket.markup.html.form.AbstractChoice#AbstractChoice(String, IModel,
* List,IChoiceRenderer)
+ *
+ * @param id
+ * @param object
+ * @param choices
+ * @param renderer
*/
+ @SuppressWarnings("unchecked")
public ListMultipleChoice(final String id, IModel<? extends Collection<T>> object,
final List<? extends T> choices, final IChoiceRenderer<? super T> renderer)
{
@@ -155,7 +166,12 @@ public class ListMultipleChoice<T> exten
/**
* @see org.apache.wicket.markup.html.form.AbstractChoice#AbstractChoice(String, IModel,IModel)
+ *
+ * @param id
+ * @param model
+ * @param choices
*/
+ @SuppressWarnings("unchecked")
public ListMultipleChoice(String id, IModel<? extends Collection<T>> model,
IModel<? extends List<? extends T>> choices)
{
@@ -176,14 +192,19 @@ public class ListMultipleChoice<T> exten
/**
* @see org.apache.wicket.markup.html.form.AbstractChoice#AbstractChoice(String, IModel,
* IModel,IChoiceRenderer)
+ *
+ * @param id
+ * @param model
+ * @param choices
+ * @param renderer
*/
+ @SuppressWarnings("unchecked")
public ListMultipleChoice(String id, IModel<? extends Collection<T>> model,
IModel<? extends List<? extends T>> choices, IChoiceRenderer<? super T> renderer)
{
super(id, (IModel<Collection<T>>)model, choices, renderer);
}
-
/**
* Sets the number of visible rows in the listbox.
*
Modified: wicket/trunk/wicket-core/src/main/java/org/apache/wicket/markup/html/form/RadioChoice.java
URL: http://svn.apache.org/viewvc/wicket/trunk/wicket-core/src/main/java/org/apache/wicket/markup/html/form/RadioChoice.java?rev=1096119&r1=1096118&r2=1096119&view=diff
==============================================================================
--- wicket/trunk/wicket-core/src/main/java/org/apache/wicket/markup/html/form/RadioChoice.java (original)
+++ wicket/trunk/wicket-core/src/main/java/org/apache/wicket/markup/html/form/RadioChoice.java Sat Apr 23 07:55:49 2011
@@ -336,6 +336,7 @@ public class RadioChoice<T> extends Abst
/**
* @see org.apache.wicket.Component#onComponentTagBody(MarkupStream, ComponentTag)
*/
+ @SuppressWarnings("unchecked")
@Override
public final void onComponentTagBody(final MarkupStream markupStream, final ComponentTag openTag)
{
@@ -362,6 +363,7 @@ public class RadioChoice<T> extends Abst
if (objectClass != null && objectClass != String.class)
{
+ @SuppressWarnings("rawtypes")
final IConverter converter = getConverter(objectClass);
label = converter.convertToString(displayValue, getLocale());
}
Modified: wicket/trunk/wicket-core/src/main/java/org/apache/wicket/markup/html/form/SubmitLink.java
URL: http://svn.apache.org/viewvc/wicket/trunk/wicket-core/src/main/java/org/apache/wicket/markup/html/form/SubmitLink.java?rev=1096119&r1=1096118&r2=1096119&view=diff
==============================================================================
--- wicket/trunk/wicket-core/src/main/java/org/apache/wicket/markup/html/form/SubmitLink.java (original)
+++ wicket/trunk/wicket-core/src/main/java/org/apache/wicket/markup/html/form/SubmitLink.java Sat Apr 23 07:55:49 2011
@@ -148,7 +148,6 @@ public class SubmitLink extends Abstract
}
/**
- * @inheritDoc
* @see org.apache.wicket.Component#onComponentTag(org.apache.wicket.markup.ComponentTag)
*/
@Override
Modified: wicket/trunk/wicket-core/src/main/java/org/apache/wicket/markup/html/form/validation/FormValidatorAdapter.java
URL: http://svn.apache.org/viewvc/wicket/trunk/wicket-core/src/main/java/org/apache/wicket/markup/html/form/validation/FormValidatorAdapter.java?rev=1096119&r1=1096118&r2=1096119&view=diff
==============================================================================
--- wicket/trunk/wicket-core/src/main/java/org/apache/wicket/markup/html/form/validation/FormValidatorAdapter.java (original)
+++ wicket/trunk/wicket-core/src/main/java/org/apache/wicket/markup/html/form/validation/FormValidatorAdapter.java Sat Apr 23 07:55:49 2011
@@ -53,10 +53,11 @@ public class FormValidatorAdapter extend
validator.validate(form);
}
+ /**
+ * @return form validator
+ */
public IFormValidator getValidator()
{
return validator;
}
-
-
}
\ No newline at end of file
Modified: wicket/trunk/wicket-core/src/main/java/org/apache/wicket/markup/html/image/resource/LocalizedImageResource.java
URL: http://svn.apache.org/viewvc/wicket/trunk/wicket-core/src/main/java/org/apache/wicket/markup/html/image/resource/LocalizedImageResource.java?rev=1096119&r1=1096118&r2=1096119&view=diff
==============================================================================
--- wicket/trunk/wicket-core/src/main/java/org/apache/wicket/markup/html/image/resource/LocalizedImageResource.java (original)
+++ wicket/trunk/wicket-core/src/main/java/org/apache/wicket/markup/html/image/resource/LocalizedImageResource.java Sat Apr 23 07:55:49 2011
@@ -190,6 +190,10 @@ public final class LocalizedImageResourc
}
}
+ /**
+ * @param parameters
+ * page parameters
+ */
public final void onResourceRequested(PageParameters parameters)
{
bind();
Modified: wicket/trunk/wicket-core/src/main/java/org/apache/wicket/markup/html/link/StatelessLink.java
URL: http://svn.apache.org/viewvc/wicket/trunk/wicket-core/src/main/java/org/apache/wicket/markup/html/link/StatelessLink.java?rev=1096119&r1=1096118&r2=1096119&view=diff
==============================================================================
--- wicket/trunk/wicket-core/src/main/java/org/apache/wicket/markup/html/link/StatelessLink.java (original)
+++ wicket/trunk/wicket-core/src/main/java/org/apache/wicket/markup/html/link/StatelessLink.java Sat Apr 23 07:55:49 2011
@@ -25,7 +25,8 @@ package org.apache.wicket.markup.html.li
*
* @author jcompagner
*
- *
+ * @param <T>
+ * type of model object
*/
public abstract class StatelessLink<T> extends Link<T>
{
Modified: wicket/trunk/wicket-core/src/main/java/org/apache/wicket/markup/html/list/PageableListView.java
URL: http://svn.apache.org/viewvc/wicket/trunk/wicket-core/src/main/java/org/apache/wicket/markup/html/list/PageableListView.java?rev=1096119&r1=1096118&r2=1096119&view=diff
==============================================================================
--- wicket/trunk/wicket-core/src/main/java/org/apache/wicket/markup/html/list/PageableListView.java (original)
+++ wicket/trunk/wicket-core/src/main/java/org/apache/wicket/markup/html/list/PageableListView.java Sat Apr 23 07:55:49 2011
@@ -129,6 +129,9 @@ public abstract class PageableListView<T
this.itemsPerPage = itemsPerPage;
}
+ /**
+ * @return offset of first item
+ */
public int getFirstItemOffset()
{
return getCurrentPage() * getItemsPerPage();
Modified: wicket/trunk/wicket-core/src/main/java/org/apache/wicket/markup/repeater/data/EmptyDataProvider.java
URL: http://svn.apache.org/viewvc/wicket/trunk/wicket-core/src/main/java/org/apache/wicket/markup/repeater/data/EmptyDataProvider.java?rev=1096119&r1=1096118&r2=1096119&view=diff
==============================================================================
--- wicket/trunk/wicket-core/src/main/java/org/apache/wicket/markup/repeater/data/EmptyDataProvider.java (original)
+++ wicket/trunk/wicket-core/src/main/java/org/apache/wicket/markup/repeater/data/EmptyDataProvider.java Sat Apr 23 07:55:49 2011
@@ -33,7 +33,7 @@ public class EmptyDataProvider<T> implem
{
private static final long serialVersionUID = 1L;
- private static EmptyDataProvider<?> INSTANCE = new EmptyDataProvider();
+ private static EmptyDataProvider<?> INSTANCE = new EmptyDataProvider<Void>();
/**
* @param <T>
Modified: wicket/trunk/wicket-core/src/main/java/org/apache/wicket/mock/MockApplication.java
URL: http://svn.apache.org/viewvc/wicket/trunk/wicket-core/src/main/java/org/apache/wicket/mock/MockApplication.java?rev=1096119&r1=1096118&r2=1096119&view=diff
==============================================================================
--- wicket/trunk/wicket-core/src/main/java/org/apache/wicket/mock/MockApplication.java (original)
+++ wicket/trunk/wicket-core/src/main/java/org/apache/wicket/mock/MockApplication.java Sat Apr 23 07:55:49 2011
@@ -27,8 +27,14 @@ import org.apache.wicket.request.resourc
import org.apache.wicket.session.ISessionStore;
import org.apache.wicket.util.IProvider;
+/**
+ * {@link WebApplication} used for testing.
+ */
public class MockApplication extends WebApplication
{
+ /**
+ * Construct.
+ */
public MockApplication()
{
}
@@ -45,6 +51,9 @@ public class MockApplication extends Web
return RuntimeConfigurationType.DEVELOPMENT;
}
+ /**
+ * @return the session
+ */
public Session getSession()
{
return getSessionStore().lookup(null);
Modified: wicket/trunk/wicket-core/src/main/java/org/apache/wicket/mock/MockPageManager.java
URL: http://svn.apache.org/viewvc/wicket/trunk/wicket-core/src/main/java/org/apache/wicket/mock/MockPageManager.java?rev=1096119&r1=1096118&r2=1096119&view=diff
==============================================================================
--- wicket/trunk/wicket-core/src/main/java/org/apache/wicket/mock/MockPageManager.java (original)
+++ wicket/trunk/wicket-core/src/main/java/org/apache/wicket/mock/MockPageManager.java Sat Apr 23 07:55:49 2011
@@ -64,6 +64,9 @@ public class MockPageManager implements
pages.clear();
}
+ /**
+ * @param context
+ */
public void setContext(IPageManagerContext context)
{
}
Modified: wicket/trunk/wicket-core/src/main/java/org/apache/wicket/mock/MockWebRequest.java
URL: http://svn.apache.org/viewvc/wicket/trunk/wicket-core/src/main/java/org/apache/wicket/mock/MockWebRequest.java?rev=1096119&r1=1096118&r2=1096119&view=diff
==============================================================================
--- wicket/trunk/wicket-core/src/main/java/org/apache/wicket/mock/MockWebRequest.java (original)
+++ wicket/trunk/wicket-core/src/main/java/org/apache/wicket/mock/MockWebRequest.java Sat Apr 23 07:55:49 2011
@@ -64,6 +64,7 @@ public class MockWebRequest extends WebR
* @param url
* @param contextPath
* @param filterPath
+ * @param prefixToContextPath
*/
public MockWebRequest(Url url, String contextPath, String filterPath, String prefixToContextPath)
{
@@ -89,6 +90,9 @@ public class MockWebRequest extends WebR
return new MockWebRequest(url, cookies, headers, postRequestParameters, locale);
}
+ /**
+ * @param url
+ */
public void setUrl(Url url)
{
this.url = url;
@@ -117,6 +121,9 @@ public class MockWebRequest extends WebR
this.cookies.addAll(cookies);
}
+ /**
+ * @param cookie
+ */
public void addCookie(Cookie cookie)
{
cookies.add(cookie);
@@ -288,6 +295,10 @@ public class MockWebRequest extends WebR
return UrlUtils.normalizePath(contextPath);
}
+ /**
+ * @param contextPath
+ * @return this
+ */
public MockWebRequest setContextPath(String contextPath)
{
this.contextPath = contextPath;
@@ -300,6 +311,10 @@ public class MockWebRequest extends WebR
return UrlUtils.normalizePath(filterPath);
}
+ /**
+ * @param filterPath
+ * @return this
+ */
public MockWebRequest setFilterPath(String filterPath)
{
this.filterPath = filterPath;
@@ -312,11 +327,13 @@ public class MockWebRequest extends WebR
return prefixToContextPath;
}
+ /**
+ * @param prefixToContextPath
+ * @return this
+ */
public MockWebRequest setPrefixToContextPath(String prefixToContextPath)
{
this.prefixToContextPath = prefixToContextPath;
return this;
}
-
-
}
Modified: wicket/trunk/wicket-core/src/main/java/org/apache/wicket/mock/MockWebResponse.java
URL: http://svn.apache.org/viewvc/wicket/trunk/wicket-core/src/main/java/org/apache/wicket/mock/MockWebResponse.java?rev=1096119&r1=1096118&r2=1096119&view=diff
==============================================================================
--- wicket/trunk/wicket-core/src/main/java/org/apache/wicket/mock/MockWebResponse.java (original)
+++ wicket/trunk/wicket-core/src/main/java/org/apache/wicket/mock/MockWebResponse.java Sat Apr 23 07:55:49 2011
@@ -292,6 +292,9 @@ public class MockWebResponse extends Web
errorMessage = msg;
}
+ /**
+ * @return error message
+ */
public String getErrorMessage()
{
return errorMessage;
Modified: wicket/trunk/wicket-core/src/main/java/org/apache/wicket/page/CouldNotLockPageException.java
URL: http://svn.apache.org/viewvc/wicket/trunk/wicket-core/src/main/java/org/apache/wicket/page/CouldNotLockPageException.java?rev=1096119&r1=1096118&r2=1096119&view=diff
==============================================================================
--- wicket/trunk/wicket-core/src/main/java/org/apache/wicket/page/CouldNotLockPageException.java (original)
+++ wicket/trunk/wicket-core/src/main/java/org/apache/wicket/page/CouldNotLockPageException.java Sat Apr 23 07:55:49 2011
@@ -18,6 +18,9 @@ package org.apache.wicket.page;
import org.apache.wicket.util.time.Duration;
+/**
+ * TODO javadoc
+ */
public class CouldNotLockPageException extends RuntimeException
{
private static final long serialVersionUID = 1L;
@@ -26,6 +29,13 @@ public class CouldNotLockPageException e
private final Duration timeout;
private final String threadName;
+ /**
+ * Construct.
+ *
+ * @param page
+ * @param threadName
+ * @param timeout
+ */
public CouldNotLockPageException(int page, String threadName, Duration timeout)
{
super("Could not lock page " + page + ". Attempt lasted " + timeout);
@@ -34,20 +44,27 @@ public class CouldNotLockPageException e
this.threadName = threadName;
}
+ /**
+ * @return page
+ */
public int getPage()
{
return page;
}
+ /**
+ * @return timeout
+ */
public Duration getTimeout()
{
return timeout;
}
+ /**
+ * @return threadName
+ */
public String getThreadName()
{
return threadName;
}
-
-
}
Modified: wicket/trunk/wicket-core/src/main/java/org/apache/wicket/page/IManageablePage.java
URL: http://svn.apache.org/viewvc/wicket/trunk/wicket-core/src/main/java/org/apache/wicket/page/IManageablePage.java?rev=1096119&r1=1096118&r2=1096119&view=diff
==============================================================================
--- wicket/trunk/wicket-core/src/main/java/org/apache/wicket/page/IManageablePage.java (original)
+++ wicket/trunk/wicket-core/src/main/java/org/apache/wicket/page/IManageablePage.java Sat Apr 23 07:55:49 2011
@@ -19,6 +19,9 @@ package org.apache.wicket.page;
import org.apache.wicket.IClusterable;
// TODO WICKET-NG: this iface used to extend IDetachable, however this causes problems because Page becomes IDetachable and some property models will cause an infinite loop triggering detach on the component again because it is their target object. In the future Component should indeed implement IDetachable, for now copied #detach into this iface directly.
+/**
+ * TODO javadoc
+ */
public interface IManageablePage extends IClusterable
{
/**
Modified: wicket/trunk/wicket-core/src/main/java/org/apache/wicket/pageStore/IDataStore.java
URL: http://svn.apache.org/viewvc/wicket/trunk/wicket-core/src/main/java/org/apache/wicket/pageStore/IDataStore.java?rev=1096119&r1=1096118&r2=1096119&view=diff
==============================================================================
--- wicket/trunk/wicket-core/src/main/java/org/apache/wicket/pageStore/IDataStore.java (original)
+++ wicket/trunk/wicket-core/src/main/java/org/apache/wicket/pageStore/IDataStore.java Sat Apr 23 07:55:49 2011
@@ -72,7 +72,7 @@ public interface IDataStore
/**
*
- * @return
+ * @return whether the data store is replicated
*/
boolean isReplicated();
}
Modified: wicket/trunk/wicket-core/src/main/java/org/apache/wicket/protocol/http/BufferedHttpServletResponse.java
URL: http://svn.apache.org/viewvc/wicket/trunk/wicket-core/src/main/java/org/apache/wicket/protocol/http/BufferedHttpServletResponse.java?rev=1096119&r1=1096118&r2=1096119&view=diff
==============================================================================
--- wicket/trunk/wicket-core/src/main/java/org/apache/wicket/protocol/http/BufferedHttpServletResponse.java (original)
+++ wicket/trunk/wicket-core/src/main/java/org/apache/wicket/protocol/http/BufferedHttpServletResponse.java Sat Apr 23 07:55:49 2011
@@ -563,6 +563,7 @@ class BufferedHttpServletResponse implem
/**
* @see javax.servlet.http.HttpServletResponse#setStatus(int)
+ * @return status
*/
public int getStatus()
{
@@ -571,6 +572,8 @@ class BufferedHttpServletResponse implem
/**
* @see javax.servlet.http.HttpServletRequest#getHeader(java.lang.String)
+ * @param name
+ * @return the first header with name
*/
public String getHeader(String name)
{
@@ -584,6 +587,8 @@ class BufferedHttpServletResponse implem
/**
* @see javax.servlet.http.HttpServletRequest#getHeaders(java.lang.String)
+ * @param name
+ * @return all headers with name
*/
public Collection<String> getHeaders(String name)
{
@@ -602,6 +607,7 @@ class BufferedHttpServletResponse implem
/**
* @see javax.servlet.http.HttpServletRequest#getHeaderNames()
+ * @return all header names
*/
public Collection<String> getHeaderNames()
{
Modified: wicket/trunk/wicket-core/src/main/java/org/apache/wicket/protocol/http/RequestUtils.java
URL: http://svn.apache.org/viewvc/wicket/trunk/wicket-core/src/main/java/org/apache/wicket/protocol/http/RequestUtils.java?rev=1096119&r1=1096118&r2=1096119&view=diff
==============================================================================
--- wicket/trunk/wicket-core/src/main/java/org/apache/wicket/protocol/http/RequestUtils.java (original)
+++ wicket/trunk/wicket-core/src/main/java/org/apache/wicket/protocol/http/RequestUtils.java Sat Apr 23 07:55:49 2011
@@ -53,7 +53,7 @@ public final class RequestUtils
if (bits.length == 2)
{
params.add(UrlDecoder.QUERY_INSTANCE.decode(bits[0], getCurrentCharset()),
- UrlDecoder.QUERY_INSTANCE.decode(bits[1], getCurrentCharset()));
+ UrlDecoder.QUERY_INSTANCE.decode(bits[1], getCurrentCharset()));
}
else
{
@@ -62,49 +62,6 @@ public final class RequestUtils
}
}
-// TODO review
-// NO LONGER USED SINCE WE HAVE URL OBJECT
-// /**
-// * decores url parameters form <code>queryString</code> into <code>parameters</code> map
-// *
-// * @param queryString
-// * @param parameters
-// */
-// public static void decodeUrlParameters(String queryString, Map<String, String[]> parameters)
-// {
-// Map<String, List<String>> temp = new HashMap<String, List<String>>();
-// final String[] paramTuples = queryString.split("&");
-// for (int t = 0; t < paramTuples.length; t++)
-// {
-// final String[] bits = paramTuples[t].split("=");
-// final String key;
-// final String value;
-// key = WicketURLDecoder.QUERY_INSTANCE.decode(bits[0]);
-// if (bits.length == 2)
-// {
-// value = WicketURLDecoder.QUERY_INSTANCE.decode(bits[1]);
-// }
-// else
-// {
-// value = "";
-// }
-// List<String> l = temp.get(key);
-// if (l == null)
-// {
-// l = new ArrayList<String>();
-// temp.put(key, l);
-// }
-// l.add(value);
-// }
-//
-// for (Map.Entry<String, List<String>> entry : temp.entrySet())
-// {
-// String s[] = new String[entry.getValue().size()];
-// entry.getValue().toArray(s);
-// parameters.put(entry.getKey(), s);
-// }
-// }
-
/**
* Remove occurrences of ".." from the path
*
@@ -177,7 +134,7 @@ public final class RequestUtils
if (relativePagePath.startsWith("../"))
{
- StringBuilder tempRelative = new StringBuilder(relativePagePath);
+ StringBuilder tempRelative = new StringBuilder(relativePagePath);
// Go up through hierarchy until we find most common directory for both pathes.
while (tempRelative.indexOf("../") == 0)
@@ -222,6 +179,10 @@ public final class RequestUtils
return RequestCycle.get().getRequest().getCharset();
}
+ /**
+ * @param request
+ * @return the request's charset
+ */
public static Charset getCharset(HttpServletRequest request)
{
String charsetName = null;
Modified: wicket/trunk/wicket-core/src/main/java/org/apache/wicket/protocol/http/mock/MockHttpServletRequest.java
URL: http://svn.apache.org/viewvc/wicket/trunk/wicket-core/src/main/java/org/apache/wicket/protocol/http/mock/MockHttpServletRequest.java?rev=1096119&r1=1096118&r2=1096119&view=diff
==============================================================================
--- wicket/trunk/wicket-core/src/main/java/org/apache/wicket/protocol/http/mock/MockHttpServletRequest.java (original)
+++ wicket/trunk/wicket-core/src/main/java/org/apache/wicket/protocol/http/mock/MockHttpServletRequest.java Sat Apr 23 07:55:49 2011
@@ -219,6 +219,9 @@ public class MockHttpServletRequest impl
cookies.add(cookie);
}
+ /**
+ * @param cookies
+ */
public void addCookies(Iterable<Cookie> cookies)
{
for (Cookie cookie : cookies)
@@ -227,7 +230,6 @@ public class MockHttpServletRequest impl
}
}
-
/**
* Add an uploaded file to the request. Use this to simulate a file that has been uploaded to a
* field.
@@ -400,6 +402,10 @@ public class MockHttpServletRequest impl
return "/context";
}
+ /**
+ * @param name
+ * @return Cookie
+ */
public Cookie getCookie(String name)
{
Cookie[] cookies = getCookies();
@@ -967,7 +973,8 @@ public class MockHttpServletRequest impl
/**
* Set the server name.
*
- *@param serverName content of 'Host' header
+ * @param serverName
+ * content of 'Host' header
*/
public void setServerName(final String serverName)
{
@@ -1243,6 +1250,10 @@ public class MockHttpServletRequest impl
}
}
+ /**
+ * @param name
+ * @param value
+ */
public void addParameter(final String name, final String value)
{
if (value == null)
@@ -1647,11 +1658,17 @@ public class MockHttpServletRequest impl
return 80;
}
+ /**
+ * @param url
+ */
public void setUrl(Url url)
{
setURL(url.toString());
}
+ /**
+ * @return request url
+ */
public Url getUrl()
{
String url = getRequestURI();
@@ -1659,12 +1676,17 @@ public class MockHttpServletRequest impl
return Url.parse(url, Charset.forName(getCharacterEncoding()));
}
+ /**
+ * @return post parameters
+ */
public MockRequestParameters getPostParameters()
{
return post;
}
-
+ /**
+ * @return filter prefix
+ */
public String getFilterPrefix()
{
return getServletPath().substring(1);
@@ -1672,6 +1694,9 @@ public class MockHttpServletRequest impl
private final MockRequestParameters post = new MockRequestParameters();
+ /**
+ * @return ServletContext
+ */
public ServletContext getServletContext()
{
return context;
Modified: wicket/trunk/wicket-core/src/main/java/org/apache/wicket/protocol/http/mock/MockHttpServletResponse.java
URL: http://svn.apache.org/viewvc/wicket/trunk/wicket-core/src/main/java/org/apache/wicket/protocol/http/mock/MockHttpServletResponse.java?rev=1096119&r1=1096118&r2=1096119&view=diff
==============================================================================
--- wicket/trunk/wicket-core/src/main/java/org/apache/wicket/protocol/http/mock/MockHttpServletResponse.java (original)
+++ wicket/trunk/wicket-core/src/main/java/org/apache/wicket/protocol/http/mock/MockHttpServletResponse.java Sat Apr 23 07:55:49 2011
@@ -800,6 +800,9 @@ public class MockHttpServletResponse imp
return getDocument();
}
+ /**
+ * @return binary response
+ */
public String getBinaryResponse()
{
String ctheader = getHeader("Content-Length");
@@ -813,6 +816,10 @@ public class MockHttpServletResponse imp
}
}
+ /**
+ * @param name
+ * @return headers with given name
+ */
public Collection<String> getHeaders(String name)
{
return Collections.singletonList(headers.get(name).toString());
Modified: wicket/trunk/wicket-core/src/main/java/org/apache/wicket/protocol/http/servlet/ServletWebRequest.java
URL: http://svn.apache.org/viewvc/wicket/trunk/wicket-core/src/main/java/org/apache/wicket/protocol/http/servlet/ServletWebRequest.java?rev=1096119&r1=1096118&r2=1096119&view=diff
==============================================================================
--- wicket/trunk/wicket-core/src/main/java/org/apache/wicket/protocol/http/servlet/ServletWebRequest.java (original)
+++ wicket/trunk/wicket-core/src/main/java/org/apache/wicket/protocol/http/servlet/ServletWebRequest.java Sat Apr 23 07:55:49 2011
@@ -246,6 +246,7 @@ public class ServletWebRequest extends W
IRequestParameters queryParams = getQueryParameters();
+ @SuppressWarnings("unchecked")
Map<String, String[]> params = getContainerRequest().getParameterMap();
for (Map.Entry<String, String[]> param : params.entrySet())
{
Modified: wicket/trunk/wicket-core/src/main/java/org/apache/wicket/request/component/IRequestableComponent.java
URL: http://svn.apache.org/viewvc/wicket/trunk/wicket-core/src/main/java/org/apache/wicket/request/component/IRequestableComponent.java?rev=1096119&r1=1096118&r2=1096119&view=diff
==============================================================================
--- wicket/trunk/wicket-core/src/main/java/org/apache/wicket/request/component/IRequestableComponent.java (original)
+++ wicket/trunk/wicket-core/src/main/java/org/apache/wicket/request/component/IRequestableComponent.java Sat Apr 23 07:55:49 2011
@@ -72,7 +72,7 @@ public interface IRequestableComponent
* is first called for the behavior until the behavior has been removed from the component
*
* @param behavior
- * @return
+ * @return a stable id for the specified behavior
*/
public int getBehaviorId(Behavior behavior);
Modified: wicket/trunk/wicket-core/src/main/java/org/apache/wicket/request/handler/resource/ResourceStreamRequestHandler.java
URL: http://svn.apache.org/viewvc/wicket/trunk/wicket-core/src/main/java/org/apache/wicket/request/handler/resource/ResourceStreamRequestHandler.java?rev=1096119&r1=1096118&r2=1096119&view=diff
==============================================================================
--- wicket/trunk/wicket-core/src/main/java/org/apache/wicket/request/handler/resource/ResourceStreamRequestHandler.java (original)
+++ wicket/trunk/wicket-core/src/main/java/org/apache/wicket/request/handler/resource/ResourceStreamRequestHandler.java Sat Apr 23 07:55:49 2011
@@ -171,11 +171,18 @@ public class ResourceStreamRequestHandle
fileName + ", contentDisposition=" + contentDisposition + "]";
}
+ /**
+ * @return ContentDisposition
+ */
public final ContentDisposition getContentDisposition()
{
return contentDisposition;
}
+ /**
+ * @param contentDisposition
+ * @return this
+ */
public final ResourceStreamRequestHandler setContentDisposition(
ContentDisposition contentDisposition)
{
Modified: wicket/trunk/wicket-core/src/main/java/org/apache/wicket/request/resource/DynamicImageResource.java
URL: http://svn.apache.org/viewvc/wicket/trunk/wicket-core/src/main/java/org/apache/wicket/request/resource/DynamicImageResource.java?rev=1096119&r1=1096118&r2=1096119&view=diff
==============================================================================
--- wicket/trunk/wicket-core/src/main/java/org/apache/wicket/request/resource/DynamicImageResource.java (original)
+++ wicket/trunk/wicket-core/src/main/java/org/apache/wicket/request/resource/DynamicImageResource.java Sat Apr 23 07:55:49 2011
@@ -26,6 +26,9 @@ import javax.imageio.ImageIO;
import org.apache.wicket.WicketRuntimeException;
import org.apache.wicket.util.time.Time;
+/**
+ * Base class for dynamically generated ImageResources.
+ */
public abstract class DynamicImageResource extends AbstractResource
{
private static final long serialVersionUID = 1L;
@@ -37,6 +40,9 @@ public abstract class DynamicImageResour
private Time lastModifiedTime;
+ /**
+ * Construct.
+ */
public DynamicImageResource()
{
}
Modified: wicket/trunk/wicket-core/src/main/java/org/apache/wicket/request/resource/JavaScriptResourceReference.java
URL: http://svn.apache.org/viewvc/wicket/trunk/wicket-core/src/main/java/org/apache/wicket/request/resource/JavaScriptResourceReference.java?rev=1096119&r1=1096118&r2=1096119&view=diff
==============================================================================
--- wicket/trunk/wicket-core/src/main/java/org/apache/wicket/request/resource/JavaScriptResourceReference.java (original)
+++ wicket/trunk/wicket-core/src/main/java/org/apache/wicket/request/resource/JavaScriptResourceReference.java Sat Apr 23 07:55:49 2011
@@ -27,12 +27,34 @@ public class JavaScriptResourceReference
{
private static final long serialVersionUID = 1L;
+ /**
+ * Construct.
+ *
+ * @param scope
+ * mandatory parameter
+ * @param name
+ * mandatory parameter
+ * @param locale
+ * resource locale
+ * @param style
+ * resource style
+ * @param variation
+ * resource variation
+ */
public JavaScriptResourceReference(Class<?> scope, String name, Locale locale, String style,
String variation)
{
super(scope, name, locale, style, variation);
}
+ /**
+ * Construct.
+ *
+ * @param scope
+ * mandatory parameter
+ * @param name
+ * mandatory parameter
+ */
public JavaScriptResourceReference(Class<?> scope, String name)
{
super(scope, name);
Modified: wicket/trunk/wicket-core/src/main/java/org/apache/wicket/request/resource/PackageResourceReference.java
URL: http://svn.apache.org/viewvc/wicket/trunk/wicket-core/src/main/java/org/apache/wicket/request/resource/PackageResourceReference.java?rev=1096119&r1=1096118&r2=1096119&view=diff
==============================================================================
--- wicket/trunk/wicket-core/src/main/java/org/apache/wicket/request/resource/PackageResourceReference.java (original)
+++ wicket/trunk/wicket-core/src/main/java/org/apache/wicket/request/resource/PackageResourceReference.java Sat Apr 23 07:55:49 2011
@@ -27,6 +27,9 @@ import org.apache.wicket.util.resource.I
import org.apache.wicket.util.resource.locator.IResourceStreamLocator;
import org.apache.wicket.util.time.Time;
+/**
+ * TODO javadoc
+ */
public class PackageResourceReference extends ResourceReference
{
private static final long serialVersionUID = 1L;
Modified: wicket/trunk/wicket-core/src/main/java/org/apache/wicket/request/resource/ResourceStreamResource.java
URL: http://svn.apache.org/viewvc/wicket/trunk/wicket-core/src/main/java/org/apache/wicket/request/resource/ResourceStreamResource.java?rev=1096119&r1=1096118&r2=1096119&view=diff
==============================================================================
--- wicket/trunk/wicket-core/src/main/java/org/apache/wicket/request/resource/ResourceStreamResource.java (original)
+++ wicket/trunk/wicket-core/src/main/java/org/apache/wicket/request/resource/ResourceStreamResource.java Sat Apr 23 07:55:49 2011
@@ -30,6 +30,9 @@ import org.slf4j.Logger;
import org.slf4j.LoggerFactory;
+/**
+ * TODO javadoc
+ */
public class ResourceStreamResource extends AbstractResource
{
private static final long serialVersionUID = 1L;
@@ -42,24 +45,41 @@ public class ResourceStreamResource exte
private String textEncoding;
private String mimeType;
+ /**
+ * Construct.
+ *
+ * @param stream
+ */
public ResourceStreamResource(IResourceStream stream)
{
Args.notNull(stream, "stream");
this.stream = stream;
}
+ /**
+ * @param fileName
+ * @return this
+ */
public ResourceStreamResource setFileName(String fileName)
{
this.fileName = fileName;
return this;
}
+ /**
+ * @param contentDisposition
+ * @return thsi
+ */
public ResourceStreamResource setContentDisposition(ContentDisposition contentDisposition)
{
this.contentDisposition = contentDisposition;
return this;
}
+ /**
+ * @param textEncoding
+ * @return this
+ */
public ResourceStreamResource setTextEncoding(String textEncoding)
{
this.textEncoding = textEncoding;
Modified: wicket/trunk/wicket-core/src/main/java/org/apache/wicket/request/resource/SharedResourceReference.java
URL: http://svn.apache.org/viewvc/wicket/trunk/wicket-core/src/main/java/org/apache/wicket/request/resource/SharedResourceReference.java?rev=1096119&r1=1096118&r2=1096119&view=diff
==============================================================================
--- wicket/trunk/wicket-core/src/main/java/org/apache/wicket/request/resource/SharedResourceReference.java (original)
+++ wicket/trunk/wicket-core/src/main/java/org/apache/wicket/request/resource/SharedResourceReference.java Sat Apr 23 07:55:49 2011
@@ -22,21 +22,52 @@ import javax.servlet.http.HttpServletRes
import org.apache.wicket.Application;
+/**
+ * TODO javadoc
+ */
public class SharedResourceReference extends ResourceReference
{
private static final long serialVersionUID = 1L;
+ /**
+ * Construct.
+ *
+ * @param scope
+ * mandatory parameter
+ * @param name
+ * mandatory parameter
+ * @param locale
+ * resource locale
+ * @param style
+ * resource style
+ * @param variation
+ * resource variation
+ */
public SharedResourceReference(Class<?> scope, String name, Locale locale, String style,
String variation)
{
super(scope, name, locale, style, variation);
}
+ /**
+ * Construct.
+ *
+ * @param scope
+ * mandatory parameter
+ * @param name
+ * mandatory parameter
+ */
public SharedResourceReference(Class<?> scope, String name)
{
super(scope, name);
}
+ /**
+ * Construct.
+ *
+ * @param name
+ * resource name
+ */
public SharedResourceReference(String name)
{
super(name);
Modified: wicket/trunk/wicket-core/src/main/java/org/apache/wicket/resource/ResourceUtil.java
URL: http://svn.apache.org/viewvc/wicket/trunk/wicket-core/src/main/java/org/apache/wicket/resource/ResourceUtil.java?rev=1096119&r1=1096118&r2=1096119&view=diff
==============================================================================
--- wicket/trunk/wicket-core/src/main/java/org/apache/wicket/resource/ResourceUtil.java (original)
+++ wicket/trunk/wicket-core/src/main/java/org/apache/wicket/resource/ResourceUtil.java Sat Apr 23 07:55:49 2011
@@ -84,6 +84,9 @@ public class ResourceUtil
/**
* read string with platform default encoding from resource stream
*
+ * @param resourceStream
+ * @return string read from resource stream
+ *
* @see #readString(org.apache.wicket.util.resource.IResourceStream, java.nio.charset.Charset)
*/
public static String readString(IResourceStream resourceStream)
Modified: wicket/trunk/wicket-core/src/main/java/org/apache/wicket/resource/dependencies/ResourceDependentResourceReference.java
URL: http://svn.apache.org/viewvc/wicket/trunk/wicket-core/src/main/java/org/apache/wicket/resource/dependencies/ResourceDependentResourceReference.java?rev=1096119&r1=1096118&r2=1096119&view=diff
==============================================================================
--- wicket/trunk/wicket-core/src/main/java/org/apache/wicket/resource/dependencies/ResourceDependentResourceReference.java (original)
+++ wicket/trunk/wicket-core/src/main/java/org/apache/wicket/resource/dependencies/ResourceDependentResourceReference.java Sat Apr 23 07:55:49 2011
@@ -41,6 +41,7 @@ public class ResourceDependentResourceRe
* @param name
* @param locale
* @param style
+ * @param variation
* @param dependencies
*/
public ResourceDependentResourceReference(Class<?> scope, String name, Locale locale,
Modified: wicket/trunk/wicket-core/src/main/java/org/apache/wicket/util/lang/PropertyResolver.java
URL: http://svn.apache.org/viewvc/wicket/trunk/wicket-core/src/main/java/org/apache/wicket/util/lang/PropertyResolver.java?rev=1096119&r1=1096118&r2=1096119&view=diff
==============================================================================
--- wicket/trunk/wicket-core/src/main/java/org/apache/wicket/util/lang/PropertyResolver.java (original)
+++ wicket/trunk/wicket-core/src/main/java/org/apache/wicket/util/lang/PropertyResolver.java Sat Apr 23 07:55:49 2011
@@ -61,6 +61,7 @@ import org.slf4j.LoggerFactory;
*
* @author jcompagner
*/
+@SuppressWarnings("unused")
public final class PropertyResolver
{
/** Log. */
Modified: wicket/trunk/wicket-core/src/main/java/org/apache/wicket/util/tester/WicketTesterHelper.java
URL: http://svn.apache.org/viewvc/wicket/trunk/wicket-core/src/main/java/org/apache/wicket/util/tester/WicketTesterHelper.java?rev=1096119&r1=1096118&r2=1096119&view=diff
==============================================================================
--- wicket/trunk/wicket-core/src/main/java/org/apache/wicket/util/tester/WicketTesterHelper.java (original)
+++ wicket/trunk/wicket-core/src/main/java/org/apache/wicket/util/tester/WicketTesterHelper.java Sat Apr 23 07:55:49 2011
@@ -149,7 +149,7 @@ public class WicketTesterHelper
*/
public static String asLined(final Collection<?> objects)
{
- StringBuilder lined = new StringBuilder();
+ StringBuilder lined = new StringBuilder();
for (Iterator<?> iter = objects.iterator(); iter.hasNext();)
{
String objectString = iter.next().toString();
@@ -163,6 +163,11 @@ public class WicketTesterHelper
return lined.toString();
}
+ /**
+ * @param component
+ * @param event
+ * @return AjaxEventBehavior or null
+ */
public static AjaxEventBehavior findAjaxEventBehavior(Component component, String event)
{
for (Behavior behavior : component.getBehaviors())
@@ -178,8 +183,12 @@ public class WicketTesterHelper
return null;
}
- public static Behavior findBehavior(Component component,
- Class<? extends Behavior> behaviorClass)
+ /**
+ * @param component
+ * @param behaviorClass
+ * @return Behavior or null
+ */
+ public static Behavior findBehavior(Component component, Class<? extends Behavior> behaviorClass)
{
for (Behavior behavior : component.getBehaviors())
{
Modified: wicket/trunk/wicket-core/src/test/java/org/apache/wicket/BehaviorRequestTest.java
URL: http://svn.apache.org/viewvc/wicket/trunk/wicket-core/src/test/java/org/apache/wicket/BehaviorRequestTest.java?rev=1096119&r1=1096118&r2=1096119&view=diff
==============================================================================
--- wicket/trunk/wicket-core/src/test/java/org/apache/wicket/BehaviorRequestTest.java (original)
+++ wicket/trunk/wicket-core/src/test/java/org/apache/wicket/BehaviorRequestTest.java Sat Apr 23 07:55:49 2011
@@ -46,12 +46,18 @@ public class BehaviorRequestTest extends
tester.startPage(page);
}
+ /**
+ *
+ */
public void testEnabledBehaviorRequest()
{
tester.executeUrl(urlForBehavior(page.enabledBehavior));
assertTrue(page.enabledBehavior.wasCalled());
}
+ /**
+ *
+ */
public void testDisabledBehaviorRequest()
{
try
@@ -76,12 +82,19 @@ public class BehaviorRequestTest extends
return tester.urlFor(handler).toString();
}
+ /**
+ */
public static class TestPage extends WebPage implements IMarkupResourceStreamProvider
{
+ private static final long serialVersionUID = 1L;
+
private WebMarkupContainer container;
private TestCallbackBehavior enabledBehavior;
private TestCallbackBehavior disabledBehavior;
+ /**
+ * Construct.
+ */
public TestPage()
{
enabledBehavior = new TestCallbackBehavior();
@@ -101,8 +114,12 @@ public class BehaviorRequestTest extends
}
}
+ /**
+ */
private static class TestCallbackBehavior extends Behavior implements IBehaviorListener
{
+ private static final long serialVersionUID = 1L;
+
private boolean enabled;
private boolean called;
Modified: wicket/trunk/wicket-core/src/test/java/org/apache/wicket/BehaviorUrlTest.java
URL: http://svn.apache.org/viewvc/wicket/trunk/wicket-core/src/test/java/org/apache/wicket/BehaviorUrlTest.java?rev=1096119&r1=1096118&r2=1096119&view=diff
==============================================================================
--- wicket/trunk/wicket-core/src/test/java/org/apache/wicket/BehaviorUrlTest.java (original)
+++ wicket/trunk/wicket-core/src/test/java/org/apache/wicket/BehaviorUrlTest.java Sat Apr 23 07:55:49 2011
@@ -32,6 +32,8 @@ import org.apache.wicket.util.string.Str
import org.apache.wicket.util.string.Strings;
+/**
+ */
public class BehaviorUrlTest extends WicketTestCase
{
/**
@@ -73,11 +75,18 @@ public class BehaviorUrlTest extends Wic
}
+ /**
+ */
public static class TestPage extends WebPage implements IMarkupResourceStreamProvider
{
+ private static final long serialVersionUID = 1L;
+
private WebMarkupContainer container;
private TestCallbackBehavior callbackBehavior;
+ /**
+ * Construct.
+ */
public TestPage()
{
callbackBehavior = new TestCallbackBehavior();
@@ -96,8 +105,12 @@ public class BehaviorUrlTest extends Wic
}
}
+ /**
+ */
private static class TestTemporaryBehavior extends Behavior
{
+ private static final long serialVersionUID = 1L;
+
@Override
public boolean isTemporary(Component c)
{
@@ -105,8 +118,12 @@ public class BehaviorUrlTest extends Wic
}
}
+ /**
+ */
private static class TestCallbackBehavior extends Behavior implements IBehaviorListener
{
+ private static final long serialVersionUID = 1L;
+
@Override
public void onComponentTag(Component component, ComponentTag tag)
{
Modified: wicket/trunk/wicket-core/src/test/java/org/apache/wicket/ComponentWithLazyModelCreationTest.java
URL: http://svn.apache.org/viewvc/wicket/trunk/wicket-core/src/test/java/org/apache/wicket/ComponentWithLazyModelCreationTest.java?rev=1096119&r1=1096118&r2=1096119&view=diff
==============================================================================
--- wicket/trunk/wicket-core/src/test/java/org/apache/wicket/ComponentWithLazyModelCreationTest.java (original)
+++ wicket/trunk/wicket-core/src/test/java/org/apache/wicket/ComponentWithLazyModelCreationTest.java Sat Apr 23 07:55:49 2011
@@ -45,7 +45,8 @@ public class ComponentWithLazyModelCreat
*/
public void testUrlReferingSomeBehavior()
{
- TestPage page = new TestPage(new CompoundPropertyModel(this));
+ TestPage page = new TestPage(new CompoundPropertyModel<ComponentWithLazyModelCreationTest>(
+ this));
tester.startPage(page);
tester.executeUrl(page.mainCallbackBehavior.statefullUrl);
@@ -60,7 +61,8 @@ public class ComponentWithLazyModelCreat
*/
public void testUrlDontCallOtherBehavior()
{
- TestPage page = new TestPage(new CompoundPropertyModel(this));
+ TestPage page = new TestPage(new CompoundPropertyModel<ComponentWithLazyModelCreationTest>(
+ this));
tester.startPage(page);
tester.executeUrl(page.brotherCallbackBehavior.statefullUrl);
@@ -70,12 +72,20 @@ public class ComponentWithLazyModelCreat
assertFalse("mainCallbackBehavior was not requested", page.mainCallbackBehavior.requested);
}
+ /**
+ */
public static class TestPage extends WebPage implements IMarkupResourceStreamProvider
{
+ private static final long serialVersionUID = 1L;
private TestCallbackBehavior mainCallbackBehavior;
private TestCallbackBehavior brotherCallbackBehavior;
- public TestPage(IModel model)
+ /**
+ * Construct.
+ *
+ * @param model
+ */
+ public TestPage(IModel<ComponentWithLazyModelCreationTest> model)
{
super(model);
mainCallbackBehavior = new TestCallbackBehavior();
@@ -96,6 +106,7 @@ public class ComponentWithLazyModelCreat
private static class TestCallbackBehavior extends Behavior implements IBehaviorListener
{
+ private static final long serialVersionUID = 1L;
private boolean requested;
// simulating the callback URL generated for component aware behaviors
private String statefullUrl;
Modified: wicket/trunk/wicket-core/src/test/java/org/apache/wicket/ajax/AjaxBehaviorAndMetaDataPage.java
URL: http://svn.apache.org/viewvc/wicket/trunk/wicket-core/src/test/java/org/apache/wicket/ajax/AjaxBehaviorAndMetaDataPage.java?rev=1096119&r1=1096118&r2=1096119&view=diff
==============================================================================
--- wicket/trunk/wicket-core/src/test/java/org/apache/wicket/ajax/AjaxBehaviorAndMetaDataPage.java (original)
+++ wicket/trunk/wicket-core/src/test/java/org/apache/wicket/ajax/AjaxBehaviorAndMetaDataPage.java Sat Apr 23 07:55:49 2011
@@ -20,12 +20,15 @@ import org.apache.wicket.markup.html.Web
import org.apache.wicket.markup.html.WebPage;
import org.apache.wicket.util.time.Duration;
+
+/** */
public class AjaxBehaviorAndMetaDataPage extends WebPage implements IAjaxIndicatorAware
{
private static final long serialVersionUID = 1L;
private final AjaxSelfUpdatingTimerBehavior ajaxIndicatorAppender;
+ /** */
public AjaxBehaviorAndMetaDataPage()
{
Modified: wicket/trunk/wicket-core/src/test/java/org/apache/wicket/ajax/AjaxBehaviorAndMetaDataTest.java
URL: http://svn.apache.org/viewvc/wicket/trunk/wicket-core/src/test/java/org/apache/wicket/ajax/AjaxBehaviorAndMetaDataTest.java?rev=1096119&r1=1096118&r2=1096119&view=diff
==============================================================================
--- wicket/trunk/wicket-core/src/test/java/org/apache/wicket/ajax/AjaxBehaviorAndMetaDataTest.java (original)
+++ wicket/trunk/wicket-core/src/test/java/org/apache/wicket/ajax/AjaxBehaviorAndMetaDataTest.java Sat Apr 23 07:55:49 2011
@@ -46,6 +46,7 @@ public class AjaxBehaviorAndMetaDataTest
tester.destroy();
}
+ /** */
public void testRender()
{
tester.startPage(AjaxBehaviorAndMetaDataPage.class);
Modified: wicket/trunk/wicket-core/src/test/java/org/apache/wicket/ajax/AjaxHeaderContributionTest.java
URL: http://svn.apache.org/viewvc/wicket/trunk/wicket-core/src/test/java/org/apache/wicket/ajax/AjaxHeaderContributionTest.java?rev=1096119&r1=1096118&r2=1096119&view=diff
==============================================================================
--- wicket/trunk/wicket-core/src/test/java/org/apache/wicket/ajax/AjaxHeaderContributionTest.java (original)
+++ wicket/trunk/wicket-core/src/test/java/org/apache/wicket/ajax/AjaxHeaderContributionTest.java Sat Apr 23 07:55:49 2011
@@ -38,6 +38,9 @@ public class AjaxHeaderContributionTest
}
+ /**
+ * @throws Exception
+ */
public void testDoubleAjaxHeaderContribution() throws Exception
{
tester.startPage(AjaxHeaderContributionPage2.class);
Modified: wicket/trunk/wicket-core/src/test/java/org/apache/wicket/ajax/DomReadyOrderPage.java
URL: http://svn.apache.org/viewvc/wicket/trunk/wicket-core/src/test/java/org/apache/wicket/ajax/DomReadyOrderPage.java?rev=1096119&r1=1096118&r2=1096119&view=diff
==============================================================================
--- wicket/trunk/wicket-core/src/test/java/org/apache/wicket/ajax/DomReadyOrderPage.java (original)
+++ wicket/trunk/wicket-core/src/test/java/org/apache/wicket/ajax/DomReadyOrderPage.java Sat Apr 23 07:55:49 2011
@@ -35,7 +35,7 @@ public class DomReadyOrderPage extends W
add(new Link("test"));
}
- private static class Link extends AjaxFallbackLink
+ private static class Link extends AjaxFallbackLink<Void>
{
private static final long serialVersionUID = 1L;
Modified: wicket/trunk/wicket-core/src/test/java/org/apache/wicket/ajax/form/AjaxFormSubmitBehaviorTest.java
URL: http://svn.apache.org/viewvc/wicket/trunk/wicket-core/src/test/java/org/apache/wicket/ajax/form/AjaxFormSubmitBehaviorTest.java?rev=1096119&r1=1096118&r2=1096119&view=diff
==============================================================================
--- wicket/trunk/wicket-core/src/test/java/org/apache/wicket/ajax/form/AjaxFormSubmitBehaviorTest.java (original)
+++ wicket/trunk/wicket-core/src/test/java/org/apache/wicket/ajax/form/AjaxFormSubmitBehaviorTest.java Sat Apr 23 07:55:49 2011
@@ -35,6 +35,7 @@ public class AjaxFormSubmitBehaviorTest
tester = new WicketTester();
}
+ /** */
public void testAjaxFormSubmitBehavior()
{
// start and render the test page
Modified: wicket/trunk/wicket-core/src/test/java/org/apache/wicket/ajax/form/AjaxFormSubmitBehaviorTestPage.java
URL: http://svn.apache.org/viewvc/wicket/trunk/wicket-core/src/test/java/org/apache/wicket/ajax/form/AjaxFormSubmitBehaviorTestPage.java?rev=1096119&r1=1096118&r2=1096119&view=diff
==============================================================================
--- wicket/trunk/wicket-core/src/test/java/org/apache/wicket/ajax/form/AjaxFormSubmitBehaviorTestPage.java (original)
+++ wicket/trunk/wicket-core/src/test/java/org/apache/wicket/ajax/form/AjaxFormSubmitBehaviorTestPage.java Sat Apr 23 07:55:49 2011
@@ -32,11 +32,17 @@ public class AjaxFormSubmitBehaviorTestP
private static final long serialVersionUID = 1L;
private final TestForm form;
+ /**
+ * Construct.
+ */
public AjaxFormSubmitBehaviorTestPage()
{
add(form = new TestForm("form"));
}
+ /**
+ * @return form
+ */
public TestForm getForm()
{
return form;
@@ -47,15 +53,17 @@ class TestForm extends Form<Void>
{
private static final long serialVersionUID = 1L;
private final Button submitButton;
- private final TextField textField;
+ private final TextField<String> textField;
private boolean submitedByAjaxBehavior;
public TestForm(String id)
{
super(id);
- textField = new TextField("textField", new Model());
+ textField = new TextField<String>("textField", new Model<String>());
textField.add(new AjaxFormSubmitBehavior("onchange")
{
+ private static final long serialVersionUID = 1L;
+
@Override
protected void onError(AjaxRequestTarget target)
{
@@ -70,6 +78,8 @@ class TestForm extends Form<Void>
add(textField);
add(new SubmitLink("ajaxSubmitLink")
{
+ private static final long serialVersionUID = 1L;
+
@Override
public void onSubmit()
{
@@ -79,6 +89,7 @@ class TestForm extends Form<Void>
add((submitButton = new Button("submit")
{
+ private static final long serialVersionUID = 1L;
@Override
public void onSubmit()
@@ -92,7 +103,7 @@ class TestForm extends Form<Void>
/**
* @return the textField
*/
- public TextField getTextField()
+ public TextField<String> getTextField()
{
return textField;
}
Modified: wicket/trunk/wicket-core/src/test/java/org/apache/wicket/ajax/form/AjaxFormSubmitTestPage.java
URL: http://svn.apache.org/viewvc/wicket/trunk/wicket-core/src/test/java/org/apache/wicket/ajax/form/AjaxFormSubmitTestPage.java?rev=1096119&r1=1096118&r2=1096119&view=diff
==============================================================================
--- wicket/trunk/wicket-core/src/test/java/org/apache/wicket/ajax/form/AjaxFormSubmitTestPage.java (original)
+++ wicket/trunk/wicket-core/src/test/java/org/apache/wicket/ajax/form/AjaxFormSubmitTestPage.java Sat Apr 23 07:55:49 2011
@@ -58,7 +58,7 @@ public class AjaxFormSubmitTestPage exte
public AjaxFormSubmitTestPage()
{
super(new CompoundPropertyModel<ValueMap>(new ValueMap("txt1=foo,txt2=bar")));
- Form<?> form = new Form("form")
+ Form<?> form = new Form<Void>("form")
{
private static final long serialVersionUID = 1L;
Modified: wicket/trunk/wicket-core/src/test/java/org/apache/wicket/ajax/form/OnChangeAjaxBehaviorTestPage.java
URL: http://svn.apache.org/viewvc/wicket/trunk/wicket-core/src/test/java/org/apache/wicket/ajax/form/OnChangeAjaxBehaviorTestPage.java?rev=1096119&r1=1096118&r2=1096119&view=diff
==============================================================================
--- wicket/trunk/wicket-core/src/test/java/org/apache/wicket/ajax/form/OnChangeAjaxBehaviorTestPage.java (original)
+++ wicket/trunk/wicket-core/src/test/java/org/apache/wicket/ajax/form/OnChangeAjaxBehaviorTestPage.java Sat Apr 23 07:55:49 2011
@@ -34,10 +34,10 @@ public class OnChangeAjaxBehaviorTestPag
*/
public OnChangeAjaxBehaviorTestPage()
{
- Form form = new Form("form");
+ Form<Void> form = new Form<Void>("form");
add(form);
- TextField field = new TextField("field");
+ TextField<String> field = new TextField<String>("field");
field.add(new OnChangeAjaxBehavior()
{
private static final long serialVersionUID = 1L;
@@ -50,7 +50,7 @@ public class OnChangeAjaxBehaviorTestPag
});
form.add(field);
- DropDownChoice choice = new DropDownChoice("dropDown");
+ DropDownChoice<?> choice = new DropDownChoice<Object>("dropDown");
choice.add(new OnChangeAjaxBehavior()
{
private static final long serialVersionUID = 1L;
Modified: wicket/trunk/wicket-core/src/test/java/org/apache/wicket/markup/html/basic/SimpleResponsePageClass.java
URL: http://svn.apache.org/viewvc/wicket/trunk/wicket-core/src/test/java/org/apache/wicket/markup/html/basic/SimpleResponsePageClass.java?rev=1096119&r1=1096118&r2=1096119&view=diff
==============================================================================
--- wicket/trunk/wicket-core/src/test/java/org/apache/wicket/markup/html/basic/SimpleResponsePageClass.java (original)
+++ wicket/trunk/wicket-core/src/test/java/org/apache/wicket/markup/html/basic/SimpleResponsePageClass.java Sat Apr 23 07:55:49 2011
@@ -33,7 +33,7 @@ public class SimpleResponsePageClass ext
*/
public SimpleResponsePageClass()
{
- Form form = new Form("form")
+ Form<Void> form = new Form<Void>("form")
{
private static final long serialVersionUID = 1L;
Modified: wicket/trunk/wicket-core/src/test/java/org/apache/wicket/markup/html/basic/SimpleResponsePageClassTest.java
URL: http://svn.apache.org/viewvc/wicket/trunk/wicket-core/src/test/java/org/apache/wicket/markup/html/basic/SimpleResponsePageClassTest.java?rev=1096119&r1=1096118&r2=1096119&view=diff
==============================================================================
--- wicket/trunk/wicket-core/src/test/java/org/apache/wicket/markup/html/basic/SimpleResponsePageClassTest.java (original)
+++ wicket/trunk/wicket-core/src/test/java/org/apache/wicket/markup/html/basic/SimpleResponsePageClassTest.java Sat Apr 23 07:55:49 2011
@@ -33,7 +33,7 @@ public class SimpleResponsePageClassTest
tester.startPage(SimpleResponsePageClass.class);
SimpleResponsePageClass manageBook = (SimpleResponsePageClass)tester.getLastRenderedPage();
- Form form = (Form)manageBook.get("form");
+ Form<?> form = (Form<?>)manageBook.get("form");
tester.submitForm(form);
Modified: wicket/trunk/wicket-core/src/test/java/org/apache/wicket/markup/html/border/ComponentBorderTest.java
URL: http://svn.apache.org/viewvc/wicket/trunk/wicket-core/src/test/java/org/apache/wicket/markup/html/border/ComponentBorderTest.java?rev=1096119&r1=1096118&r2=1096119&view=diff
==============================================================================
--- wicket/trunk/wicket-core/src/test/java/org/apache/wicket/markup/html/border/ComponentBorderTest.java (original)
+++ wicket/trunk/wicket-core/src/test/java/org/apache/wicket/markup/html/border/ComponentBorderTest.java Sat Apr 23 07:55:49 2011
@@ -76,7 +76,7 @@ public class ComponentBorderTest extends
Page page = tester.getLastRenderedPage();
Border border = (Border)page.get("hideable");
assertNotNull(border);
- AjaxLink link = (AjaxLink)border.get("hideLink");
+ AjaxLink<?> link = (AjaxLink<?>)border.get("hideLink");
assertNotNull(link);
WebMarkupContainer wrapper = (WebMarkupContainer)border.get("wrapper");
assertNotNull(wrapper);
Modified: wicket/trunk/wicket-core/src/test/java/org/apache/wicket/markup/html/border/FormBorder.java
URL: http://svn.apache.org/viewvc/wicket/trunk/wicket-core/src/test/java/org/apache/wicket/markup/html/border/FormBorder.java?rev=1096119&r1=1096118&r2=1096119&view=diff
==============================================================================
--- wicket/trunk/wicket-core/src/test/java/org/apache/wicket/markup/html/border/FormBorder.java (original)
+++ wicket/trunk/wicket-core/src/test/java/org/apache/wicket/markup/html/border/FormBorder.java Sat Apr 23 07:55:49 2011
@@ -30,7 +30,7 @@ public class FormBorder extends Border
{
private static final long serialVersionUID = 1L;
- private final Form form;
+ private final Form<Void> form;
/**
*
Modified: wicket/trunk/wicket-core/src/test/java/org/apache/wicket/markup/html/form/AbstractTextComponentConvertEmptyStringsToNullTest.java
URL: http://svn.apache.org/viewvc/wicket/trunk/wicket-core/src/test/java/org/apache/wicket/markup/html/form/AbstractTextComponentConvertEmptyStringsToNullTest.java?rev=1096119&r1=1096118&r2=1096119&view=diff
==============================================================================
--- wicket/trunk/wicket-core/src/test/java/org/apache/wicket/markup/html/form/AbstractTextComponentConvertEmptyStringsToNullTest.java (original)
+++ wicket/trunk/wicket-core/src/test/java/org/apache/wicket/markup/html/form/AbstractTextComponentConvertEmptyStringsToNullTest.java Sat Apr 23 07:55:49 2011
@@ -30,9 +30,14 @@ import org.apache.wicket.util.resource.S
import org.apache.wicket.util.string.Strings;
import org.apache.wicket.util.tester.WicketTester;
+/**
+ */
public class AbstractTextComponentConvertEmptyStringsToNullTest extends TestCase
{
+ /**
+ * @throws Exception
+ */
public void test() throws Exception
{
WicketTester tester = new WicketTester();
@@ -45,13 +50,21 @@ public class AbstractTextComponentConver
assertEquals(0, page.array.length);
}
+ /**
+ */
public static class StringArrayPage extends WebPage implements IMarkupResourceStreamProvider
{
+ private static final long serialVersionUID = 1L;
+ /** */
public String[] array = new String[0];
+ /** */
public Form<Void> form;
+ /**
+ * Construct.
+ */
public StringArrayPage()
{
@@ -60,6 +73,8 @@ public class AbstractTextComponentConver
form.add(new TextField<String[]>("array", new PropertyModel<String[]>(this, "array"))
{
+ private static final long serialVersionUID = 1L;
+
@Override
@SuppressWarnings("unchecked")
public <C> IConverter<C> getConverter(Class<C> type)
@@ -71,6 +86,8 @@ public class AbstractTextComponentConver
private class StringArrayConverter implements IConverter<String[]>
{
+ private static final long serialVersionUID = 1L;
+
public String[] convertToObject(String value, Locale locale)
{
return Strings.split(value, ',');