You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@beam.apache.org by kennknowles <gi...@git.apache.org> on 2017/06/28 14:16:46 UTC

[GitHub] beam pull request #3459: [BEAM-2529] Only use letters to generate Spanner da...

GitHub user kennknowles opened a pull request:

    https://github.com/apache/beam/pull/3459

    [BEAM-2529] Only use letters to generate Spanner database names

    Be sure to do all of the following to help us incorporate your contribution
    quickly and easily:
    
     - [ ] Make sure the PR title is formatted like:
       `[BEAM-<Jira issue #>] Description of pull request`
     - [ ] Make sure tests pass via `mvn clean verify`.
     - [ ] Replace `<Jira issue #>` in the title with the actual Jira issue
           number, if there is one.
     - [ ] If this contribution is large, please file an Apache
           [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
    
    ---
    
    We are seeing NPEs in SpannerWriteIT, [like this one](https://builds.apache.org/job/beam_PostCommit_Java_MavenInstall/org.apache.beam$beam-runners-google-cloud-dataflow-java/lastCompletedBuild/testReport/org.apache.beam.sdk.io.gcp.spanner/SpannerWriteIT/testWrite_2/).

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/kennknowles/beam SpannerWriteIT

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/beam/pull/3459.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #3459
    
----
commit f8fcd49cfb6bd8fb599846bc862a142f5e5e34d7
Author: Kenneth Knowles <kl...@google.com>
Date:   2017-06-28T14:12:51Z

    Only use letters to generate Spanner database names

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] beam pull request #3459: [BEAM-2529] Only use ASCII a-z to generate Spanner ...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/beam/pull/3459


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---