You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by rxin <gi...@git.apache.org> on 2015/09/24 22:42:12 UTC

[GitHub] spark pull request: StreamFrame API alternatives.

GitHub user rxin opened a pull request:

    https://github.com/apache/spark/pull/8906

    StreamFrame API alternatives.

    This pull request proposes 3 alternatives for StreamFrame API.
    
    - A1: A single StreamFrame abstraction for both non-windowed and windowed stream. Blocking operations work also on non-windowed streams, as they just return a new stream with tuples emitted for every update.
    - A2: A single StreamFrame abstraction for both non-windowed and windowed stream. Blocking operations throw runtime exceptions on non-windowed stream.
    - B: Two abstractions: StreamFrame and WindowedStreamFrame.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/rxin/spark streamframe-api

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/spark/pull/8906.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #8906
    
----
commit 0a8c5c3ead26fe8c3df13b463b40331a6dd40970
Author: Reynold Xin <rx...@databricks.com>
Date:   2015-09-24T20:27:27Z

    StreamFrame API alternatives.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request: StreamFrame API alternatives.

Posted by rxin <gi...@git.apache.org>.
Github user rxin closed the pull request at:

    https://github.com/apache/spark/pull/8906


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request: StreamFrame API alternatives.

Posted by rxin <gi...@git.apache.org>.
Github user rxin commented on a diff in the pull request:

    https://github.com/apache/spark/pull/8906#discussion_r40370276
  
    --- Diff: sql/core/src/main/scala/org/apache/spark/sql/streamv1/WindowSpec.scala ---
    @@ -0,0 +1,28 @@
    +package org.apache.spark.sql.streamv1
    +
    +trait WindowSpec
    --- End diff --
    
    Please ignore this file for now.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org