You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2022/05/15 11:14:40 UTC
[GitHub] [incubator-nuttx] xiaoxiang781216 opened a new pull request, #6275: boards/arm: Remove "LDFLAGS += -g" whichi is already added by Toolchain.defs
xiaoxiang781216 opened a new pull request, #6275:
URL: https://github.com/apache/incubator-nuttx/pull/6275
## Summary
risc-v: Move "LDFLAGS += -melf32lriscv" from Make.defs to Toolchain.defs
## Impact
Code refactor
## Testing
Pass CI
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a diff in pull request #6275: boards/arm: Remove "LDFLAGS += -g" whichi is already added by Toolchain.defs
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on code in PR #6275:
URL: https://github.com/apache/incubator-nuttx/pull/6275#discussion_r873226010
##########
boards/arm/lpc214x/mcu123-lpc214x/scripts/Make.defs:
##########
@@ -69,7 +69,3 @@ NXFLATLDFLAGS2 = $(NXFLATLDFLAGS1) \
-T$(TOPDIR)/binfmt/libnxflat/gnu-nxflat-gotoff.ld \
-no-check-sections
LDNXFLATFLAGS = -e main -s 2048
-
-ifeq ($(CONFIG_DEBUG_FEATURES),y)
Review Comment:
Done.
##########
boards/arm/lpc2378/olimex-lpc2378/scripts/Make.defs:
##########
@@ -69,7 +69,3 @@ NXFLATLDFLAGS2 = $(NXFLATLDFLAGS1) \
-T$(TOPDIR)/binfmt/libnxflat/gnu-nxflat-gotoff.ld \
-no-check-sections
LDNXFLATFLAGS = -e main -s 2048
-
-ifeq ($(CONFIG_DEBUG_FEATURES),y)
Review Comment:
Done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a diff in pull request #6275: boards/arm: Remove "LDFLAGS += -g" whichi is already added by Toolchain.defs
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on code in PR #6275:
URL: https://github.com/apache/incubator-nuttx/pull/6275#discussion_r873225960
##########
boards/arm/c5471/c5471evm/scripts/Make.defs:
##########
@@ -69,7 +69,3 @@ NXFLATLDFLAGS2 = $(NXFLATLDFLAGS1) \
-T$(TOPDIR)/binfmt/libnxflat/gnu-nxflat-gotoff.ld \
-no-check-sections
LDNXFLATFLAGS = -e main -s 2048
-
-ifeq ($(CONFIG_DEBUG_FEATURES),y)
Review Comment:
Done.
##########
boards/arm/lpc214x/zp214xpa/scripts/Make.defs:
##########
@@ -69,7 +69,3 @@ NXFLATLDFLAGS2 = $(NXFLATLDFLAGS1) \
-T$(TOPDIR)/binfmt/libnxflat/gnu-nxflat-gotoff.ld \
-no-check-sections
LDNXFLATFLAGS = -e main -s 2048
-
-ifeq ($(CONFIG_DEBUG_FEATURES),y)
Review Comment:
Done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] pkarashchenko commented on a diff in pull request #6275: boards/arm: Remove "LDFLAGS += -g" whichi is already added by Toolchain.defs
Posted by GitBox <gi...@apache.org>.
pkarashchenko commented on code in PR #6275:
URL: https://github.com/apache/incubator-nuttx/pull/6275#discussion_r873223511
##########
boards/arm/c5471/c5471evm/scripts/Make.defs:
##########
@@ -69,7 +69,3 @@ NXFLATLDFLAGS2 = $(NXFLATLDFLAGS1) \
-T$(TOPDIR)/binfmt/libnxflat/gnu-nxflat-gotoff.ld \
-no-check-sections
LDNXFLATFLAGS = -e main -s 2048
-
-ifeq ($(CONFIG_DEBUG_FEATURES),y)
Review Comment:
Let's remove
```
ifeq ("${CONFIG_DEBUG_FEATURES}","y")
ARCHOPTIMIZATION = -g
endif
```
as well
##########
boards/arm/lpc214x/mcu123-lpc214x/scripts/Make.defs:
##########
@@ -69,7 +69,3 @@ NXFLATLDFLAGS2 = $(NXFLATLDFLAGS1) \
-T$(TOPDIR)/binfmt/libnxflat/gnu-nxflat-gotoff.ld \
-no-check-sections
LDNXFLATFLAGS = -e main -s 2048
-
-ifeq ($(CONFIG_DEBUG_FEATURES),y)
Review Comment:
Let's remove
```
ifeq ("${CONFIG_DEBUG_FEATURES}","y")
ARCHOPTIMIZATION = -g
endif
```
as well
##########
boards/arm/lpc2378/olimex-lpc2378/scripts/Make.defs:
##########
@@ -69,7 +69,3 @@ NXFLATLDFLAGS2 = $(NXFLATLDFLAGS1) \
-T$(TOPDIR)/binfmt/libnxflat/gnu-nxflat-gotoff.ld \
-no-check-sections
LDNXFLATFLAGS = -e main -s 2048
-
-ifeq ($(CONFIG_DEBUG_FEATURES),y)
Review Comment:
Let's remove
```
ifeq ("${CONFIG_DEBUG_FEATURES}","y")
ARCHOPTIMIZATION = -g
endif
```
as well
##########
boards/arm/lpc214x/zp214xpa/scripts/Make.defs:
##########
@@ -69,7 +69,3 @@ NXFLATLDFLAGS2 = $(NXFLATLDFLAGS1) \
-T$(TOPDIR)/binfmt/libnxflat/gnu-nxflat-gotoff.ld \
-no-check-sections
LDNXFLATFLAGS = -e main -s 2048
-
-ifeq ($(CONFIG_DEBUG_FEATURES),y)
Review Comment:
Let's remove
```
ifeq ("${CONFIG_DEBUG_FEATURES}","y")
ARCHOPTIMIZATION = -g
endif
```
as well
##########
boards/arm/str71x/olimex-strp711/scripts/Make.defs:
##########
@@ -69,7 +69,3 @@ NXFLATLDFLAGS2 = $(NXFLATLDFLAGS1) \
-T$(TOPDIR)/binfmt/libnxflat/gnu-nxflat-gotoff.ld \
-no-check-sections
LDNXFLATFLAGS = -e main -s 2048
-
-ifeq ($(CONFIG_DEBUG_FEATURES),y)
Review Comment:
Let's remove
```
ifeq ("${CONFIG_DEBUG_FEATURES}","y")
ARCHOPTIMIZATION = -g
endif
```
as well
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] pkarashchenko merged pull request #6275: boards/arm: Remove "LDFLAGS += -g" whichi is already added by Toolchain.defs
Posted by GitBox <gi...@apache.org>.
pkarashchenko merged PR #6275:
URL: https://github.com/apache/incubator-nuttx/pull/6275
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a diff in pull request #6275: boards/arm: Remove "LDFLAGS += -g" whichi is already added by Toolchain.defs
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on code in PR #6275:
URL: https://github.com/apache/incubator-nuttx/pull/6275#discussion_r873226070
##########
boards/arm/str71x/olimex-strp711/scripts/Make.defs:
##########
@@ -69,7 +69,3 @@ NXFLATLDFLAGS2 = $(NXFLATLDFLAGS1) \
-T$(TOPDIR)/binfmt/libnxflat/gnu-nxflat-gotoff.ld \
-no-check-sections
LDNXFLATFLAGS = -e main -s 2048
-
-ifeq ($(CONFIG_DEBUG_FEATURES),y)
Review Comment:
Done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org